[json] Use base::BitField instead of C++ bitfields [v8/v8 : main]

0 views
Skip to first unread message

Victor Gomes (Gerrit)

unread,
10:22 AM (13 hours ago) 10:22 AM
to Patrick Thier, v8-re...@googlegroups.com
Attention needed from Patrick Thier

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Victor Gomes . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Thier
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I3998aa5b2d73860748165a7687e6bcb3b646dd3c
Gerrit-Change-Number: 7416350
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Patrick Thier <pth...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 15:22:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Patrick Thier (Gerrit)

unread,
10:37 AM (13 hours ago) 10:37 AM
to Victor Gomes, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Victor Gomes

Patrick Thier voted and added 1 comment

Votes added by Patrick Thier

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Patrick Thier . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I3998aa5b2d73860748165a7687e6bcb3b646dd3c
Gerrit-Change-Number: 7416350
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 15:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
10:59 AM (13 hours ago) 10:59 AM
to Victor Gomes, Patrick Thier, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[json] Use base::BitField instead of C++ bitfields
Bug: 467004383
Change-Id: I3998aa5b2d73860748165a7687e6bcb3b646dd3c
Reviewed-by: Patrick Thier <pth...@chromium.org>
Commit-Queue: Patrick Thier <pth...@chromium.org>
Auto-Submit: Victor Gomes <victo...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104605}
Files:
  • M src/json/json-parser.cc
  • M src/json/json-parser.h
Change size: S
Delta: 2 files changed, 25 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Patrick Thier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I3998aa5b2d73860748165a7687e6bcb3b646dd3c
Gerrit-Change-Number: 7416350
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages