PPC: use P10 prefixed instructions in macro assembler [v8/v8 : main]

2 views
Skip to first unread message

Milad Farazmand (Gerrit)

unread,
Jun 8, 2022, 1:46:35 PM6/8/22
to Junliang Yan, Vasili Skurydzin, v8-re...@googlegroups.com

Attention is currently required from: Junliang Yan.

View Change

    To view, visit change 3695383. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I2300e4b1f0edfca107dc9f39c20898da57cac358
    Gerrit-Change-Number: 3695383
    Gerrit-PatchSet: 3
    Gerrit-Owner: Milad Farazmand <mfar...@redhat.com>
    Gerrit-Reviewer: Junliang Yan <jun...@redhat.com>
    Gerrit-CC: Vasili Skurydzin <vasili.s...@ibm.com>
    Gerrit-Attention: Junliang Yan <jun...@redhat.com>
    Gerrit-Comment-Date: Wed, 08 Jun 2022 17:46:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Junliang Yan (Gerrit)

    unread,
    Jun 8, 2022, 10:22:36 PM6/8/22
    to Milad Farazmand, Vasili Skurydzin, v8-re...@googlegroups.com

    Attention is currently required from: Milad Farazmand.

    Patch set 3:Code-Review +1

    View Change

      To view, visit change 3695383. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: I2300e4b1f0edfca107dc9f39c20898da57cac358
      Gerrit-Change-Number: 3695383
      Gerrit-PatchSet: 3
      Gerrit-Owner: Milad Farazmand <mfar...@redhat.com>
      Gerrit-Reviewer: Junliang Yan <jun...@redhat.com>
      Gerrit-CC: Vasili Skurydzin <vasili.s...@ibm.com>
      Gerrit-Attention: Milad Farazmand <mfar...@redhat.com>
      Gerrit-Comment-Date: Thu, 09 Jun 2022 02:22:30 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Milad Farazmand (Gerrit)

      unread,
      Jun 9, 2022, 10:12:56 AM6/9/22
      to Junliang Yan, Vasili Skurydzin, v8-re...@googlegroups.com

      Attention is currently required from: Milad Farazmand.

      Patch set 3:Commit-Queue +2

      View Change

        To view, visit change 3695383. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: v8/v8
        Gerrit-Branch: main
        Gerrit-Change-Id: I2300e4b1f0edfca107dc9f39c20898da57cac358
        Gerrit-Change-Number: 3695383
        Gerrit-PatchSet: 3
        Gerrit-Owner: Milad Farazmand <mfar...@redhat.com>
        Gerrit-Reviewer: Junliang Yan <jun...@redhat.com>
        Gerrit-Reviewer: Milad Farazmand <mfar...@redhat.com>
        Gerrit-CC: Vasili Skurydzin <vasili.s...@ibm.com>
        Gerrit-Attention: Milad Farazmand <mfar...@redhat.com>
        Gerrit-Comment-Date: Thu, 09 Jun 2022 14:12:49 +0000

        V8 LUCI CQ (Gerrit)

        unread,
        Jun 9, 2022, 11:52:44 AM6/9/22
        to Milad Farazmand, Junliang Yan, Vasili Skurydzin, v8-re...@googlegroups.com

        V8 LUCI CQ submitted this change.

        View Change


        Approvals: Milad Farazmand: Commit Junliang Yan: Looks good to me
        PPC: use P10 prefixed instructions in macro assembler

        Operations are divided into 3 categories:
        - Load/Store ops including prefixed.
        - Load/Store ops including prefixed, with alignment requirements
        for their non-prefixed version.
        - Non-prefixed Load/Store.

        We first check if a non-prefixed instruction can be emitted
        and if so will emit that instead while making sure to check
        for its alignment (if needed).

        Change-Id: I2300e4b1f0edfca107dc9f39c20898da57cac358
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695383
        Commit-Queue: Milad Farazmand <mfar...@redhat.com>
        Reviewed-by: Junliang Yan <jun...@redhat.com>
        Cr-Commit-Position: refs/heads/main@{#81044}
        ---
        M src/codegen/ppc/macro-assembler-ppc.cc
        1 file changed, 123 insertions(+), 22 deletions(-)


        To view, visit change 3695383. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: v8/v8
        Gerrit-Branch: main
        Gerrit-Change-Id: I2300e4b1f0edfca107dc9f39c20898da57cac358
        Gerrit-Change-Number: 3695383
        Gerrit-PatchSet: 4
        Gerrit-Owner: Milad Farazmand <mfar...@redhat.com>
        Gerrit-Reviewer: Junliang Yan <jun...@redhat.com>
        Gerrit-Reviewer: Milad Farazmand <mfar...@redhat.com>
        Gerrit-CC: Vasili Skurydzin <vasili.s...@ibm.com>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages