[ppc] Replace direct ip usage with UseScratchRegisterScope in liftoff [v8/v8 : main]

0 views
Skip to first unread message

John (Gerrit)

unread,
2:18 PM (7 hours ago) 2:18 PM
to Milad Farazmand, v8-re...@googlegroups.com, was...@google.com
Attention needed from Milad Farazmand

John voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Milad Farazmand
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I1924b1dc80c4dccf16b940bc395ed487edc62ded
Gerrit-Change-Number: 7859910
Gerrit-PatchSet: 2
Gerrit-Owner: John <jun...@ibm.com>
Gerrit-Reviewer: John <jun...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-Attention: Milad Farazmand <mfar...@ibm.com>
Gerrit-Comment-Date: Tue, 19 May 2026 18:18:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

rt-node-js-v8 (Gerrit)

unread,
3:18 PM (6 hours ago) 3:18 PM
to John, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Milad Farazmand, v8-re...@googlegroups.com, was...@google.com
Attention needed from John and Milad Farazmand

Message from rt-node-js-v8

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • John
  • Milad Farazmand
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I1924b1dc80c4dccf16b940bc395ed487edc62ded
Gerrit-Change-Number: 7859910
Gerrit-PatchSet: 2
Gerrit-Owner: John <jun...@ibm.com>
Gerrit-Reviewer: John <jun...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-CC: rt-node-js-v8 <rt-node-js...@ibm.com>
Gerrit-Attention: John <jun...@ibm.com>
Gerrit-Attention: Milad Farazmand <mfar...@ibm.com>
Gerrit-Comment-Date: Tue, 19 May 2026 19:18:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Milad Farazmand (Gerrit)

unread,
3:19 PM (6 hours ago) 3:19 PM
to John, rt-node-js-v8, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com, was...@google.com
Attention needed from John

Milad Farazmand voted and added 2 comments

Votes added by Milad Farazmand

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Milad Farazmand . resolved

Nice, LGTM with a nit.

File src/wasm/baseline/ppc/liftoff-assembler-ppc-inl.h
Line 3112, Patchset 2 (Latest): Register scratch1 = r0;
Milad Farazmand . unresolved

nit: move scratch2 here under scratch1 since it is only used in this scope (for now).

Open in Gerrit

Related details

Attention is currently required from:
  • John
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I1924b1dc80c4dccf16b940bc395ed487edc62ded
Gerrit-Change-Number: 7859910
Gerrit-PatchSet: 2
Gerrit-Owner: John <jun...@ibm.com>
Gerrit-Reviewer: John <jun...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-CC: rt-node-js-v8 <rt-node-js...@ibm.com>
Gerrit-Attention: John <jun...@ibm.com>
Gerrit-Comment-Date: Tue, 19 May 2026 19:19:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

John (Gerrit)

unread,
6:51 PM (2 hours ago) 6:51 PM
to Milad Farazmand, rt-node-js-v8, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com, was...@google.com

John voted and added 1 comment

Votes added by John

Commit-Queue+2

1 comment

File src/wasm/baseline/ppc/liftoff-assembler-ppc-inl.h
Line 3112, Patchset 2: Register scratch1 = r0;
Milad Farazmand . resolved

nit: move scratch2 here under scratch1 since it is only used in this scope (for now).

John

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I1924b1dc80c4dccf16b940bc395ed487edc62ded
    Gerrit-Change-Number: 7859910
    Gerrit-PatchSet: 3
    Gerrit-Owner: John <jun...@ibm.com>
    Gerrit-Reviewer: John <jun...@ibm.com>
    Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
    Gerrit-CC: rt-node-js-v8 <rt-node-js...@ibm.com>
    Gerrit-Comment-Date: Tue, 19 May 2026 22:51:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Milad Farazmand <mfar...@ibm.com>
    satisfied_requirement
    open
    diffy

    v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    7:30 PM (2 hours ago) 7:30 PM
    to John, Milad Farazmand, rt-node-js-v8, v8-re...@googlegroups.com, was...@google.com

    v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes

    Unreviewed changes

    2 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: src/wasm/baseline/ppc/liftoff-assembler-ppc-inl.h
    Insertions: 2, Deletions: 2.

    @@ -3096,8 +3096,6 @@
     
       // Then execute the parallel register move and also move values to parameter
       // stack slots.
    -  UseScratchRegisterScope temps(this);
    -  Register scratch2 = temps.Acquire();
       int reg_args = 0;
       int stack_args = 0;
       ParallelMove parallel_move{this};
    @@ -3110,6 +3108,8 @@
               (kStackFrameExtraParamSlot + stack_args) * kSystemPointerSize;
           MemOperand dst{sp, offset};
           Register scratch1 = r0;
    +      UseScratchRegisterScope temps(this);
    +      Register scratch2 = temps.Acquire();
           if (arg.is_reg()) {
             switch (arg.kind()) {
               case kI16:
    ```

    Change information

    Commit message:
    [ppc] Replace direct ip usage with UseScratchRegisterScope in liftoff

    - Replace ~80 direct ip (r12) usages with UseScratchRegisterScope
      across 34 functions/macros in liftoff-assembler-ppc-inl.h
    - Simplify Load function's float cases by removing ip collision
      handling (push/pop fallback no longer needed)
    - Fulfill TODO(miladfarca) in emit_i64x2_mul by using
      UseScratchRegisterScope instead of GetRegisterThatIsNotOneOf
    - Fix Spill(WasmValue) which created UseScratchRegisterScope but
      ignored it and used ip directly
    IT: 8
    Change-Id: I1924b1dc80c4dccf16b940bc395ed487edc62ded
    Reviewed-by: Milad Farazmand <mfar...@ibm.com>
    Commit-Queue: John <jun...@ibm.com>
    Cr-Commit-Position: refs/heads/main@{#107437}
    Files:
    • M src/wasm/baseline/ppc/liftoff-assembler-ppc-inl.h
    Change size: L
    Delta: 1 file changed, 159 insertions(+), 119 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Milad Farazmand
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I1924b1dc80c4dccf16b940bc395ed487edc62ded
    Gerrit-Change-Number: 7859910
    Gerrit-PatchSet: 4
    Gerrit-Owner: John <jun...@ibm.com>
    Gerrit-Reviewer: John <jun...@ibm.com>
    Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages