[turbofan] Accept megamorphic generator loads [v8/v8 : main]
0 views
Skip to first unread message
Victor Gomes (Gerrit)
Mar 10, 2026, 11:58:15 AMMar 10
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Mar 11, 2026, 6:23:48 AMMar 11
to Victor Gomes, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Victor Gomes
Darius Mercadier voted and added 2 comments![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
2 comments
Patchset-level comments
File src/compiler/js-call-reducer.cc
Line 6790, Patchset 4 (Latest):
simplified()->CheckIf(DeoptimizeReason::kWrongInstanceType,Darius Mercadier . unresolved
`kSmi`
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Mar 11, 2026, 6:46:39 AMMar 11
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Victor Gomes voted and added 2 comments![]( "Open in Gerrit")
Votes added by Victor Gomes
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File src/compiler/js-call-reducer.cc
Line 6790, Patchset 4:
simplified()->CheckIf(DeoptimizeReason::kWrongInstanceType,Darius Mercadier . resolved
Victor Gomes`kSmi`
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 11, 2026, 7:25:05 AMMar 11
to Victor Gomes, Darius Mercadier, chrom...@appspot.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/compiler/js-call-reducer.cc
Insertions: 2, Deletions: 3.
@@ -6787,9 +6787,8 @@
Node* is_smi = graph()->NewNode(simplified()->ObjectIsSmi(), receiver);
Node* is_not_smi = graph()->NewNode(simplified()->BooleanNot(), is_smi);
effect = graph()->NewNode(
- simplified()->CheckIf(DeoptimizeReason::kWrongInstanceType,
- p.feedback()),
- is_not_smi, effect, control);
+ simplified()->CheckIf(DeoptimizeReason::kSmi, p.feedback()), is_not_smi,
+ effect, control);
// 2. Check if receiver's InstanceType is JS_GENERATOR_OBJECT_TYPE.
Node* receiver_map = effect =
```
Change information
Commit message:
[turbofan] Accept megamorphic generator loads
... when inlining GeneratorPrototypeNext.
Bug: 491263706
Change-Id: I07c32a336d5dd73063ebd4a7425836311e424a68
Commit-Queue: Victor Gomes <victo...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105723}
Files:
- M src/compiler/js-call-reducer.cc
Change size: S
Delta: 1 file changed, 30 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages