[turboshaft][wasm] Fix inferred type for allocations with custom desc [v8/v8 : main]

0 views
Skip to first unread message

Matthias Liedtke (Gerrit)

unread,
5:32 PM (4 hours ago) 5:32 PM
to Jakob Kummerow, Daniel Lehmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Jakob Kummerow

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Matthias Liedtke . resolved

@jkum...@chromium.org: PTAL
@dleh...@chromium.org: This touches the turbolev-graph-builder, so adding you here as well, taking the enabled features from the `NativeModule` should do the right thing, even with OTs and all that stuff, so I guess, this should be a good solution (hopefully).

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Lehmann
  • Jakob Kummerow
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4783ae6926b28b6579d993f378f928045f28cf33
Gerrit-Change-Number: 7859361
Gerrit-PatchSet: 3
Gerrit-Owner: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Tue, 19 May 2026 21:32:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages