[compiler] Backwards instruction scheduling. [v8/v8 : main]

2 views
Skip to first unread message

Sam Parker-Haynes (Gerrit)

unread,
Jun 17, 2026, 8:46:24 AMJun 17
to Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann

Sam Parker-Haynes voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Jun 2026 12:46:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 9:45:17 AMJun 17
to Sam Parker-Haynes, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

😿 Job mac-m4-mini-perf/jetstream-main.crossbench failed.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/138a7e42c90000

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
  • Sam Parker-Haynes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Comment-Date: Wed, 17 Jun 2026 13:45:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 9:46:59 AMJun 17
to Sam Parker-Haynes, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1787ee94c90000

Gerrit-Comment-Date: Wed, 17 Jun 2026 13:46:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 9:49:34 AMJun 17
to Sam Parker-Haynes, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/105e0de0c90000

Gerrit-Comment-Date: Wed, 17 Jun 2026 13:49:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Sam Parker-Haynes (Gerrit)

unread,
Jun 17, 2026, 10:00:08 AMJun 17
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Sam Parker-Haynes . resolved

@dmerc...@chromium.org Any ideas what's causing the pinpoint failures?

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Jun 2026 14:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 10:15:19 AMJun 17
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-r350-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1187b616c90000

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
  • Sam Parker-Haynes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Comment-Date: Wed, 17 Jun 2026 14:15:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
Jun 17, 2026, 10:17:38 AMJun 17
to Sam Parker-Haynes, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Darius Mercadier added 1 comment

Patchset-level comments
Sam Parker-Haynes . resolved

@dmerc...@chromium.org Any ideas what's causing the pinpoint failures?

Darius Mercadier

I messed up the flags 😭 I re-started the pinpoint jobs with the correct flags.

Gerrit-Comment-Date: Wed, 17 Jun 2026 14:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam Parker-Haynes <sam.p...@arm.com>
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 10:17:50 AMJun 17
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

😿 Job linux-r350-perf/jetstream-main.crossbench failed.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16a692c8c90000

Gerrit-Comment-Date: Wed, 17 Jun 2026 14:17:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 11:28:11 AMJun 17
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

  • babylonjs-scene-es6: base median = 124.70531754379022 -> patched median = 113.27238490486054
  • ml: base median = 261.48781232427746 -> patched median = 237.85183693344402


See results at: https://pinpoint-dot-chromeperf.appspot.com/job/126ca722c90000

Gerrit-Comment-Date: Wed, 17 Jun 2026 15:28:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 11:29:05 AMJun 17
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-r350-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12e388fec90000

Gerrit-Comment-Date: Wed, 17 Jun 2026 15:29:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 11:38:04 AMJun 17
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12e1fd12c90000

Gerrit-Comment-Date: Wed, 17 Jun 2026 15:37:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 11:40:08 AMJun 17
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

  • ml: base median = 260.3321122376152 -> patched median = 236.61907597812996


See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12962312c90000

Gerrit-Comment-Date: Wed, 17 Jun 2026 15:39:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 11:50:16 AMJun 17
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-r350-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16fc7f7ec90000

Gerrit-Comment-Date: Wed, 17 Jun 2026 15:50:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Sam Parker-Haynes (Gerrit)

unread,
Jun 17, 2026, 11:52:23 AMJun 17
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments
Sam Parker-Haynes . resolved

Judging by the pinpoints, it's the same benchmarks looking bad as the original 'tweaks' patch. So, I'll revert the latency calculations so they don't just look at 'data' preds/succs and see if that makes this patch look more appealing.

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Jun 2026 15:52:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Sam Parker-Haynes (Gerrit)

unread,
Jun 18, 2026, 3:25:28 AM (14 days ago) Jun 18
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments
Sam Parker-Haynes . resolved

Judging by the pinpoints, it's the same benchmarks looking bad as the original 'tweaks' patch. So, I'll revert the latency calculations so they don't just look at 'data' preds/succs and see if that makes this patch look more appealing.

Sam Parker-Haynes

@dmerc...@chromium.org Can you kick off pinpoint again, please?

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 4
Gerrit-Comment-Date: Thu, 18 Jun 2026 07:25:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam Parker-Haynes <sam.p...@arm.com>
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
Jun 18, 2026, 3:45:52 AM (14 days ago) Jun 18
to Sam Parker-Haynes, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Darius Mercadier added 1 comment

Patchset-level comments
Sam Parker-Haynes . resolved

Judging by the pinpoints, it's the same benchmarks looking bad as the original 'tweaks' patch. So, I'll revert the latency calculations so they don't just look at 'data' preds/succs and see if that makes this patch look more appealing.

Sam Parker-Haynes

@dmerc...@chromium.org Can you kick off pinpoint again, please?

Darius Mercadier

done

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
  • Sam Parker-Haynes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 4
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Comment-Date: Thu, 18 Jun 2026 07:45:48 +0000
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 18, 2026, 4:25:09 AM (14 days ago) Jun 18
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

  • ml: base median = 261.5412363199325 -> patched median = 237.64728100026878


See results at: https://pinpoint-dot-chromeperf.appspot.com/job/147d71f2c90000

Gerrit-Comment-Date: Thu, 18 Jun 2026 08:25:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Sam Parker-Haynes (Gerrit)

unread,
Jun 18, 2026, 4:31:08 AM (14 days ago) Jun 18
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Darius Mercadier and Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments
Sam Parker-Haynes . resolved

Judging by the pinpoints, it's the same benchmarks looking bad as the original 'tweaks' patch. So, I'll revert the latency calculations so they don't just look at 'data' preds/succs and see if that makes this patch look more appealing.

Sam Parker-Haynes

@dmerc...@chromium.org Can you kick off pinpoint again, please?

Darius Mercadier

done

Sam Parker-Haynes

Could the experimental flag also be applied to the base..?

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
  • Nico Hartmann
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 4
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 08:31:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Darius Mercadier <dmerc...@chromium.org>
Comment-In-Reply-To: Sam Parker-Haynes <sam.p...@arm.com>
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
Jun 18, 2026, 4:35:54 AM (14 days ago) Jun 18
to Sam Parker-Haynes, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann and Sam Parker-Haynes

Darius Mercadier added 1 comment

Patchset-level comments
Sam Parker-Haynes . resolved

Judging by the pinpoints, it's the same benchmarks looking bad as the original 'tweaks' patch. So, I'll revert the latency calculations so they don't just look at 'data' preds/succs and see if that makes this patch look more appealing.

Sam Parker-Haynes

@dmerc...@chromium.org Can you kick off pinpoint again, please?

Darius Mercadier

done

Sam Parker-Haynes

Could the experimental flag also be applied to the base..?

Darius Mercadier

Yep yep, I've triggered 5 pinpoints when I said "done" above; only one of them doesn't have the expermental flag on the base but unfortunately it's the one that finished first 😄

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
  • Sam Parker-Haynes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 4
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Comment-Date: Thu, 18 Jun 2026 08:35:48 +0000
unsatisfied_requirement
open
diffy

Sam Parker-Haynes (Gerrit)

unread,
Jun 18, 2026, 4:43:38 AM (14 days ago) Jun 18
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Darius Mercadier and Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments
Sam Parker-Haynes . resolved

Judging by the pinpoints, it's the same benchmarks looking bad as the original 'tweaks' patch. So, I'll revert the latency calculations so they don't just look at 'data' preds/succs and see if that makes this patch look more appealing.

Sam Parker-Haynes

@dmerc...@chromium.org Can you kick off pinpoint again, please?

Darius Mercadier

done

Sam Parker-Haynes

Could the experimental flag also be applied to the base..?

Darius Mercadier

Yep yep, I've triggered 5 pinpoints when I said "done" above; only one of them doesn't have the expermental flag on the base but unfortunately it's the one that finished first 😄

Sam Parker-Haynes

Ah, cool, cheers. That will be interesting.

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
  • Nico Hartmann
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 4
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 08:43:34 +0000
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 18, 2026, 4:48:36 AM (14 days ago) Jun 18
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Darius Mercadier, Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/176ee8eac90000

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
  • Nico Hartmann
  • Sam Parker-Haynes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic275ebfa632e282c366601806cfb02038c0936dc
Gerrit-Change-Number: 7956338
Gerrit-PatchSet: 4
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Comment-Date: Thu, 18 Jun 2026 08:48:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 18, 2026, 4:49:50 AM (14 days ago) Jun 18
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Darius Mercadier, Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

  • ml: base median = 260.57989300336715 -> patched median = 236.77525534281747


See results at: https://pinpoint-dot-chromeperf.appspot.com/job/120b18dac90000

Gerrit-Comment-Date: Thu, 18 Jun 2026 08:49:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 18, 2026, 4:56:21 AM (14 days ago) Jun 18
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Darius Mercadier, Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-r350-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15b8cfa6c90000

Gerrit-Comment-Date: Thu, 18 Jun 2026 08:56:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 18, 2026, 5:03:29 AM (14 days ago) Jun 18
to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Darius Mercadier, Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-r350-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16603d16c90000

Gerrit-Comment-Date: Thu, 18 Jun 2026 09:03:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Gavin Mak (Gerrit)

unread,
2:07 PM (7 hours ago) 2:07 PM
to Sam Parker-Haynes, Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Gavin Mak abandoned this change.

View Change

Gavin Mak abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages