[gcmole] Fix virtual method suspects and Safepoint pattern [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
11:04 AM (10 hours ago) 11:04 AM
to Michael Lippautz, Maksim Ivanov, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov and Michael Lippautz
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Maksim Ivanov
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
11:37 AM (10 hours ago) 11:37 AM
to Leszek Swirski, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Maksim Ivanov, v8-re...@googlegroups.com
Attention needed from Leszek Swirski and Maksim Ivanov
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Leszek Swirski
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
11:53 AM (9 hours ago) 11:53 AM
to Leszek Swirski, Michael Lippautz, Maksim Ivanov, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[gcmole] Fix virtual method suspects and Safepoint pattern
Fix virtual method suspect propagation in the GCMole Clang plugin by
establishing virtual override links in the callgraph. When an overriding
virtual method is detected as causing GC, we conservatively mark the
overridden base method as also causing GC, ensuring callers of the base
method are correctly warned.
Also fix SAFEPOINT_PATTERN in the python driver to support qualified
names by adding a wildcard after the comma.
Update test expectations to match Clang 19 macro expansion formatting.
Bug: 42202654, 512734866
TAG=agy
CONV=a395481f-0408-4c4d-ae72-2e9d8e6f0eff
Change-Id: If7e6d3e3bb4107f32cb6ae1a70bcbd0a22f503e7
Auto-Submit: Leszek Swirski <les...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107430}
Files:
- M tools/gcmole/gcmole.cc
- M tools/gcmole/gcmole.py
Change size: S
Delta: 2 files changed, 30 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
11:53 AM (9 hours ago) 11:53 AM
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Leszek Swirski, Michael Lippautz, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Maksim Ivanov added 1 comment![]( "Open in Gerrit")
File tools/gcmole/gcmole.cc
Line 259, Patchset 2:
callgraph_[base_mangled] = callees = new CalleesSet();Maksim Ivanov . unresolved
I think depending on the order the AST traversal, this will result in either examining or skipping the inspection of the base class' method. Seems like a problem if the base method is nonempty.
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages