[profiling] Fix UAF in PerfJitLogger [v8/v8 : main]

0 views
Skip to first unread message

Camillo Bruni (Gerrit)

unread,
Dec 15, 2025, 10:03:14 AM (20 hours ago) Dec 15
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

Camillo Bruni added 1 comment

Patchset-level comments
File-level comment, Patchset 3:
Camillo Bruni . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I04e65f964a8d06d83ca6b60a62b206b469c426b5
Gerrit-Change-Number: 7252711
Gerrit-PatchSet: 7
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 15:03:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Igor Sheludko (Gerrit)

unread,
Dec 15, 2025, 10:10:32 AM (20 hours ago) Dec 15
to Camillo Bruni, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Camillo Bruni

Igor Sheludko voted and added 2 comments

Votes added by Igor Sheludko

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Igor Sheludko . resolved

lgtm with a nit

Commit Message
Line 9, Patchset 7 (Latest):- Use std::string as storage
Igor Sheludko . unresolved

This comment seems wrong.

Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I04e65f964a8d06d83ca6b60a62b206b469c426b5
Gerrit-Change-Number: 7252711
Gerrit-PatchSet: 7
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 15:10:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Camillo Bruni (Gerrit)

unread,
Dec 15, 2025, 10:38:14 AM (20 hours ago) Dec 15
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com

Camillo Bruni voted and added 1 comment

Votes added by Camillo Bruni

Commit-Queue+2

1 comment

Commit Message
Line 9, Patchset 7:- Use std::string as storage
Igor Sheludko . resolved

This comment seems wrong.

Camillo Bruni

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I04e65f964a8d06d83ca6b60a62b206b469c426b5
    Gerrit-Change-Number: 7252711
    Gerrit-PatchSet: 8
    Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 15:38:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Igor Sheludko <ish...@chromium.org>
    satisfied_requirement
    open
    diffy

    V8 LUCI CQ (Gerrit)

    unread,
    Dec 15, 2025, 10:40:45 AM (20 hours ago) Dec 15
    to Camillo Bruni, Igor Sheludko, v8-re...@googlegroups.com

    V8 LUCI CQ submitted the change

    Unreviewed changes

    7 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [profiling] Fix UAF in PerfJitLogger

    - Use separate name_storages for inline flattened script names
    - Use current_script instead of the out outer function
    Bug: 425405814
    Change-Id: I04e65f964a8d06d83ca6b60a62b206b469c426b5
    Reviewed-by: Igor Sheludko <ish...@chromium.org>
    Commit-Queue: Camillo Bruni <cbr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#104324}
    Files:
    • M src/diagnostics/perf-jit.cc
    Change size: XS
    Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Igor Sheludko
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I04e65f964a8d06d83ca6b60a62b206b469c426b5
    Gerrit-Change-Number: 7252711
    Gerrit-PatchSet: 9
    Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages