BranchTableIterator<ValidationTag> br_table_iterator(this, imm);
Since that's used a good 50 lines below, I added a bit more context to the name.
DCHECK(has_next());
Same here: enforce API for good measure.
DCHECK(has_next());
Probably a good idea to enforce the API contract here; analogously to br_table.
uint32_t br_table_length = iterator.length();
uint32_t try_table_length = try_table_iterator.length();
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
LGTM, thanks a lot!
BranchTableIterator<ValidationTag> br_table_iterator(this, imm);
Since that's used a good 50 lines below, I added a bit more context to the name.
Acknowledged
DCHECK(has_next());
Same here: enforce API for good measure.
Acknowledged
DCHECK(has_next());
Probably a good idea to enforce the API contract here; analogously to br_table.
Yes, thanks!
uint32_t br_table_length = iterator.length();
uint32_t try_table_length = try_table_iterator.length();
Reverted https://crrev.com/c/6618664 since no longer necessary.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[wasm][cleanup] Simplify decoder br/try/handler table iterators
Follow-up from https://crrev.com/c/7072273.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |