[interpreter] Don't cache closure slots [v8/v8 : main]

0 views
Skip to first unread message

Toon Verwaest (Gerrit)

unread,
Nov 18, 2025, 10:33:00 AM (22 hours ago) Nov 18
to Leszek Swirski, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Toon Verwaest voted and added 1 comment

Votes added by Toon Verwaest

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Toon Verwaest . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I68315a52fdc0556233aac41e4f79708eb678713e
Gerrit-Change-Number: 7164737
Gerrit-PatchSet: 1
Gerrit-Owner: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Nov 2025 15:32:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Nov 18, 2025, 11:04:52 AM (21 hours ago) Nov 18
to Toon Verwaest, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Toon Verwaest

Leszek Swirski voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I68315a52fdc0556233aac41e4f79708eb678713e
Gerrit-Change-Number: 7164737
Gerrit-PatchSet: 1
Gerrit-Owner: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Nov 2025 16:04:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Nov 18, 2025, 11:05:05 AM (21 hours ago) Nov 18
to Toon Verwaest, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Toon Verwaest

Leszek Swirski added 1 comment

Patchset-level comments
Leszek Swirski . resolved

I assume you checked git log etc?

Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I68315a52fdc0556233aac41e4f79708eb678713e
Gerrit-Change-Number: 7164737
Gerrit-PatchSet: 1
Gerrit-Owner: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Nov 2025 16:05:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Nov 18, 2025, 11:17:50 AM (21 hours ago) Nov 18
to Toon Verwaest, Leszek Swirski, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[interpreter] Don't cache closure slots

The cache can't ever hit anyway.
Change-Id: I68315a52fdc0556233aac41e4f79708eb678713e
Commit-Queue: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Leszek Swirski <les...@chromium.org>
Auto-Submit: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103794}
Files:
  • M src/interpreter/bytecode-generator.cc
  • M src/interpreter/bytecode-generator.h
Change size: S
Delta: 2 files changed, 5 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Leszek Swirski
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I68315a52fdc0556233aac41e4f79708eb678713e
Gerrit-Change-Number: 7164737
Gerrit-PatchSet: 2
Gerrit-Owner: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages