Embedding feedback in BytecodeArray for StrictEqual [v8/v8 : main]

[Yuheng Wei (Gerrit)]

Message from Yuheng Wei

Set Ready For Review

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I24390811c12755b0a19beaefe2b0319d75ceaf6c

Gerrit-Change-Number: 6986847

Gerrit-PatchSet: 1

Gerrit-Owner: Yuheng Wei <yuhen...@intel.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-Comment-Date: Fri, 26 Sep 2025 07:00:33 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Yuheng Wei (Gerrit)]

Attention needed from Leszek Swirski and Toon Verwaest

Yuheng Wei voted and added 1 comment

Votes added by Yuheng Wei

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Yuheng Wei . resolved

Hi Toon, hi Leszek, this patch is ready for review, PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Leszek Swirski
• Toon Verwaest

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I24390811c12755b0a19beaefe2b0319d75ceaf6c

Gerrit-Change-Number: 6986847

Gerrit-PatchSet: 1

Gerrit-Owner: Yuheng Wei <yuhen...@intel.com>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-Reviewer: Yuheng Wei <yuhen...@intel.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Hao A Xu <hao....@intel.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Toon Verwaest <verw...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Sep 2025 07:50:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Yuheng Wei (Gerrit)]

Attention needed from Leszek Swirski and Toon Verwaest

Yuheng Wei voted and added 1 comment

Votes added by Yuheng Wei

Commit-Queue

+1

1 comment

File src/interpreter/bytecodes.h

Line 316, Patchset 1 (Latest): OperandType::kReg, OperandType::kFlag16, OperandType::kFlag8) \

Yuheng Wei . unresolved

We add one padding byte to ensure that the feedback value can be stored at a 16-bit aligned address. This guarantees that atomic loads will always operate on an aligned address. We have a more detailed explanation of this in our design doc: https://docs.google.com/document/d/1QmkY6LEZ7B6kEu1xAr3Dzn4O5gFljmRwvqcA5eMmLsw/edit?disco=AAABrMA17pE.
Do you have any suggestions regarding this approach?

Open in Gerrit

Related details

Attention is currently required from:

• Leszek Swirski
• Toon Verwaest

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I24390811c12755b0a19beaefe2b0319d75ceaf6c

Gerrit-Change-Number: 6986847

Gerrit-PatchSet: 1

Gerrit-Owner: Yuheng Wei <yuhen...@intel.com>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-Reviewer: Yuheng Wei <yuhen...@intel.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Hao A Xu <hao....@intel.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Toon Verwaest <verw...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Sep 2025 07:53:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes