Fix test on big endian [v8/v8 : main]

0 views
Skip to first unread message

Milad Farazmand (Gerrit)

unread,
Mar 16, 2026, 10:12:43 AM (14 hours ago) Mar 16
to Victor Gomes, Marja Hölttä, John, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Victor Gomes

Milad Farazmand added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Milad Farazmand . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9faea77fd087c0b66785b1e64a1bad3049eadb56
Gerrit-Change-Number: 7670361
Gerrit-PatchSet: 3
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-CC: John <jun...@ibm.com>
Gerrit-CC: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Mon, 16 Mar 2026 14:12:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
Mar 16, 2026, 10:14:31 AM (14 hours ago) Mar 16
to Milad Farazmand, Marja Hölttä, John, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Milad Farazmand

Victor Gomes voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Milad Farazmand
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9faea77fd087c0b66785b1e64a1bad3049eadb56
Gerrit-Change-Number: 7670361
Gerrit-PatchSet: 3
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-CC: John <jun...@ibm.com>
Gerrit-CC: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Milad Farazmand <mfar...@ibm.com>
Gerrit-Comment-Date: Mon, 16 Mar 2026 14:14:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Milad Farazmand (Gerrit)

unread,
Mar 16, 2026, 10:19:20 AM (14 hours ago) Mar 16
to Victor Gomes, Marja Hölttä, John, V8 LUCI CQ, v8-re...@googlegroups.com

Milad Farazmand voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9faea77fd087c0b66785b1e64a1bad3049eadb56
Gerrit-Change-Number: 7670361
Gerrit-PatchSet: 3
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-CC: John <jun...@ibm.com>
Gerrit-CC: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 16 Mar 2026 14:19:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Mar 16, 2026, 10:51:39 AM (14 hours ago) Mar 16
to Milad Farazmand, Victor Gomes, Marja Hölttä, John, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
Fix test on big endian

We are reading the wrong byte on big-endian which is causing this
errors:
```
Failure: expected <128> found <0>
```
Using a `Dataview` to force little-ednian ordering.
Fixed: 491466705
Change-Id: I9faea77fd087c0b66785b1e64a1bad3049eadb56
Commit-Queue: Milad Farazmand <mfar...@ibm.com>
Reviewed-by: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105825}
Files:
  • M test/mjsunit/turbolev/regress-491466705.js
Change size: XS
Delta: 1 file changed, 6 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Victor Gomes
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9faea77fd087c0b66785b1e64a1bad3049eadb56
Gerrit-Change-Number: 7670361
Gerrit-PatchSet: 4
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages