Fix test on big endian [v8/v8 : main]
0 views
Skip to first unread message
Milad Farazmand (Gerrit)
Mar 16, 2026, 10:12:43 AM (14 hours ago) Mar 16
to Victor Gomes, Marja Hölttä, John, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Victor Gomes
Milad Farazmand added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Mar 16, 2026, 10:14:31 AM (14 hours ago) Mar 16
to Milad Farazmand, Marja Hölttä, John, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Milad Farazmand
Victor Gomes voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Milad Farazmand
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
Mar 16, 2026, 10:19:20 AM (14 hours ago) Mar 16
to Victor Gomes, Marja Hölttä, John, V8 LUCI CQ, v8-re...@googlegroups.com
Milad Farazmand voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 16, 2026, 10:51:39 AM (14 hours ago) Mar 16
to Milad Farazmand, Victor Gomes, Marja Hölttä, John, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix test on big endian
We are reading the wrong byte on big-endian which is causing this
errors:
```
Failure: expected <128> found <0>
```
Using a `Dataview` to force little-ednian ordering.
Fixed: 491466705
Change-Id: I9faea77fd087c0b66785b1e64a1bad3049eadb56
Commit-Queue: Milad Farazmand <mfar...@ibm.com>
Reviewed-by: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105825}
Files:
- M test/mjsunit/turbolev/regress-491466705.js
Change size: XS
Delta: 1 file changed, 6 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages