[map] Fix publishing of integrity-level transitions [v8/v8 : main]

0 views
Skip to first unread message

Olivier Flückiger (Gerrit)

unread,
8:43 AM (13 hours ago) 8:43 AM
to Toon Verwaest, v8-re...@googlegroups.com
Attention needed from Toon Verwaest

Olivier Flückiger voted and added 1 comment

Votes added by Olivier Flückiger

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Olivier Flückiger . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibfe62aa63e63873554420774a0b269e7f2cd594f
Gerrit-Change-Number: 7450862
Gerrit-PatchSet: 2
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 13:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Toon Verwaest (Gerrit)

unread,
10:52 AM (11 hours ago) 10:52 AM
to Olivier Flückiger, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Olivier Flückiger

Toon Verwaest voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Flückiger
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibfe62aa63e63873554420774a0b269e7f2cd594f
Gerrit-Change-Number: 7450862
Gerrit-PatchSet: 4
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 15:52:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
10:54 AM (11 hours ago) 10:54 AM
to Olivier Flückiger, Toon Verwaest, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[map] Fix publishing of integrity-level transitions

Integrity level transition target maps should not be published to the
map tree before they are fully initialized. Otherwise concurrent access
might pick up not fully updated target maps.

Drive-By: Fix a dcheck in the map-updater to not fire when an indirectly
reachable non-deprecatable map is deprecated due to the whole subtree
being deprecated.
Fixed: 473851441
Change-Id: Ibfe62aa63e63873554420774a0b269e7f2cd594f
Auto-Submit: Olivier Flückiger <ol...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104646}
Files:
  • M src/objects/map.cc
  • M src/objects/map.h
Change size: M
Delta: 2 files changed, 100 insertions(+), 63 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Toon Verwaest
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibfe62aa63e63873554420774a0b269e7f2cd594f
Gerrit-Change-Number: 7450862
Gerrit-PatchSet: 5
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages