[ic] Introduce CallNamedInterceptorSetter builtin [v8/v8 : main]
0 views
Skip to first unread message
Igor Sheludko (Gerrit)
Jan 30, 2026, 6:19:50 AM (5 days ago) Jan 30
to Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Patrick Thier
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 30, 2026, 6:47:36 AM (5 days ago) Jan 30
to Igor Sheludko, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko
Patrick Thier voted and added 2 comments![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
2 comments
Patchset-level comments
Patrick Thier . resolved
LGTM
File src/builtins/arm/builtins-arm.cc
Line 4373, Patchset 6 (Latest):
// sp[1]: STOnE (setter) | sp[1]: undefined <- kReturnValueIndexPatrick Thier . unresolved
nit: I assume that this stand for "Should Throw On Error"?
This was at first glance not obvious (and took me some time to realize).
Maybe just `throw?` is easier to understand? (Also in other architecture files)
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Jan 30, 2026, 7:15:01 AM (5 days ago) Jan 30
to Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Igor Sheludko voted and added 2 comments![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File src/builtins/arm/builtins-arm.cc
Line 4373, Patchset 6:
// sp[1]: STOnE (setter) | sp[1]: undefined <- kReturnValueIndexPatrick Thier . resolved
nit: I assume that this stand for "Should Throw On Error"?
This was at first glance not obvious (and took me some time to realize).
Maybe just `throw?` is easier to understand? (Also in other architecture files)
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Jan 31, 2026, 3:03:45 PM (4 days ago) Jan 31
to Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Igor Sheludko voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 31, 2026, 3:11:41 PM (4 days ago) Jan 31
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job linux-r350-perf/speedometer3 failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/160454c7710000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 31, 2026, 3:57:21 PM (4 days ago) Jan 31
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-r350-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13b90167710000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 31, 2026, 4:05:59 PM (4 days ago) Jan 31
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12ba89eb710000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Feb 2, 2026, 11:41:57 AM (2 days ago) Feb 2
to Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Igor Sheludko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Feb 2, 2026, 12:39:54 PM (2 days ago) Feb 2
to Igor Sheludko, Patrick Thier, chrom...@appspot.gserviceaccount.com, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/builtins/x64/builtins-x64.cc
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/builtins/arm/builtins-arm.cc
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/builtins/arm64/builtins-arm64.cc
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/builtins/ia32/builtins-ia32.cc
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[ic] Introduce CallNamedInterceptorSetter builtin
... and use it in IC dispatchers.
Bug: 455479513
Change-Id: I29596fc281902e452034f09e7a44611b9330a692
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105032}
Files:
- M src/api/api.cc
- M src/api/api.h
- M src/builtins/arm/builtins-arm.cc
- M src/builtins/arm64/builtins-arm64.cc
- M src/builtins/builtins-call-gen.cc
- M src/builtins/builtins-definitions.h
- M src/builtins/builtins.h
- M src/builtins/ia32/builtins-ia32.cc
- M src/builtins/loong64/builtins-loong64.cc
- M src/builtins/mips64/builtins-mips64.cc
- M src/builtins/ppc/builtins-ppc.cc
- M src/builtins/riscv/builtins-riscv.cc
- M src/builtins/s390/builtins-s390.cc
- M src/builtins/x64/builtins-x64.cc
- M src/codegen/arm/macro-assembler-arm.cc
- M src/codegen/arm64/macro-assembler-arm64.cc
- M src/codegen/external-reference.cc
- M src/codegen/external-reference.h
- M src/codegen/ia32/macro-assembler-ia32.cc
- M src/codegen/interface-descriptors-inl.h
- M src/codegen/interface-descriptors.h
- M src/codegen/loong64/macro-assembler-loong64.cc
- M src/codegen/mips64/macro-assembler-mips64.cc
- M src/codegen/ppc/macro-assembler-ppc.cc
- M src/codegen/riscv/macro-assembler-riscv.cc
- M src/codegen/s390/macro-assembler-s390.cc
- M src/codegen/x64/macro-assembler-x64.cc
- M src/execution/arm/simulator-arm.cc
- M src/execution/arm64/simulator-arm64.cc
- M src/execution/frame-constants.h
- M src/ic/accessor-assembler.cc
- M src/ic/handler-configuration-inl.h
- M src/ic/handler-configuration.cc
- M src/ic/handler-configuration.h
- M src/ic/ic.cc
- M src/objects/api-callbacks-inl.h
- M src/objects/api-callbacks.h
- M src/runtime/runtime.h
Change size: L
Delta: 38 files changed, 520 insertions(+), 157 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Patrick Thier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ji Qiu (Gerrit)
Feb 2, 2026, 10:19:27 PM (2 days ago) Feb 2
to Yahan Lu (LuYahan), V8 LUCI CQ, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Yahan Lu (LuYahan)
Ji Qiu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ji Qiu
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Yahan Lu (LuYahan)
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Feb 2, 2026, 10:21:06 PM (2 days ago) Feb 2
to Yahan Lu (LuYahan), Ji Qiu, v8-re...@googlegroups.com, v8-risc...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[riscv][ic] Introduce CallNamedInterceptorSetter builtin
Port commit 254cc758346f10be2a7e22e55d90d4defe9cad74
Bug: 455479513
Change-Id: I486d6843ff5d90b739763f19d75c68297b59c1aa
Commit-Queue: Ji Qiu <qi...@iscas.ac.cn>
Reviewed-by: Ji Qiu <qi...@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#105037}
Files:
- M src/builtins/riscv/builtins-riscv.cc
- M src/codegen/riscv/macro-assembler-riscv.cc
- M src/execution/riscv/simulator-riscv.cc
Change size: M
Delta: 3 files changed, 95 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ji Qiu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liu Yu (Gerrit)
Feb 3, 2026, 8:04:49 PM (8 hours ago) Feb 3
to Zhao Jiazhong, v8-loongar...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
Attention needed from Zhao Jiazhong
Liu Yu voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Zhao Jiazhong
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhao Jiazhong (Gerrit)
Feb 3, 2026, 8:20:22 PM (8 hours ago) Feb 3
to Liu Yu, v8-loongar...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
Attention needed from Liu Yu
Zhao Jiazhong voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zhao Jiazhong
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Liu Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhao Jiazhong (Gerrit)
Feb 3, 2026, 9:38:10 PM (7 hours ago) Feb 3
to Liu Yu, V8 LUCI CQ, v8-loongar...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
Attention needed from Liu Yu
Zhao Jiazhong voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Liu Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liu Yu (Gerrit)
Feb 3, 2026, 9:41:17 PM (7 hours ago) Feb 3
to Zhao Jiazhong, V8 LUCI CQ, v8-loongar...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
Attention needed from Zhao Jiazhong
Liu Yu voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Zhao Jiazhong
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Feb 3, 2026, 10:16:59 PM (6 hours ago) Feb 3
to Liu Yu, Zhao Jiazhong, v8-loongar...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[loong64][mips64][ic] Introduce CallNamedInterceptorSetter builtin
Port commit 254cc758346f10be2a7e22e55d90d4defe9cad74
Bug: 455479513
Change-Id: I53164f203ad674f84e9ebefd9b5a1e46458b9a30
Auto-Submit: Liu Yu <li...@loongson.cn>
Commit-Queue: Liu Yu <li...@loongson.cn>
Reviewed-by: Zhao Jiazhong <zhaojia...@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#105070}
Files:
- M src/builtins/loong64/builtins-loong64.cc
- M src/builtins/mips64/builtins-mips64.cc
- M src/codegen/loong64/macro-assembler-loong64.cc
- M src/codegen/mips64/macro-assembler-mips64.cc
- M src/execution/loong64/simulator-loong64.cc
- M src/execution/mips64/simulator-mips64.cc
Change size: M
Delta: 6 files changed, 193 insertions(+), 44 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Zhao Jiazhong
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages