[bigint][sandbox] Harden FromString against concurrent mutation [v8/v8 : main]
0 views
Skip to first unread message
Jakob Kummerow (Gerrit)
Jan 8, 2026, 9:34:17 AM (21 hours ago) Jan 8
to Jakob Kummerow, Clemens Backes, v8-re...@googlegroups.com
Attention needed from Clemens Backes
Jakob Kummerow voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jakob Kummerow . resolved
Line count negative and performance positive, yay! PTAL.
Related details
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Jan 8, 2026, 9:39:21 AM (21 hours ago) Jan 8
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Clemens Backes voted![]( "Open in Gerrit")
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 8, 2026, 10:19:50 AM (20 hours ago) Jan 8
to Jakob Kummerow, Clemens Backes, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[bigint][sandbox] Harden FromString against concurrent mutation
Reusing the in-sandbox memory that will later hold the final result
for intermediate results causes code to operate on a mix of
in-sandbox and out-of-sandbox memory, which can spread corruption.
This patch avoids that by allocating more out-of-sandbox temp memory.
Fixed: 474041332
Change-Id: Ie88d5ea051719cd6aa1243df15290603229fa06f
Commit-Queue: Clemens Backes <clem...@chromium.org>
Auto-Submit: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104562}
Files:
- M src/bigint/fromstring.cc
Change size: S
Delta: 1 file changed, 11 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Clemens Backes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages