[maglev non-eager inlining] Use type info from CheckInstanceType [v8/v8 : main]
0 views
Skip to first unread message
Marja Hölttä (Gerrit)
10:38 AM (12 hours ago) 10:38 AM
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Marja Hölttä added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
10:52 AM (11 hours ago) 10:52 AM
to Marja Hölttä, Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä and Victor Gomes
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job mac-m1_mini_2020-perf/jetstream-main.crossbench failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11e37585b10000
Related details
Attention is currently required from:
- Marja Hölttä
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
11:06 AM (11 hours ago) 11:06 AM
to Marja Hölttä, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä
Victor Gomes voted and added 3 comments![]( "Open in Gerrit")
Votes added by Victor Gomes
| Code-Review | +1 |
3 comments
Patchset-level comments
Victor Gomes . resolved
LGTM % nit
File src/maglev/maglev-graph-optimizer.cc
Line 528, Patchset 1 (Latest):
if (IsEmptyNodeType(
IntersectType(known_node_aspects().GetType(broker(), input),
NodeType::kAnyHeapObject))) {
return DeoptAndTruncate(DeoptimizeReason::kSmi);
}
if (known_node_aspects().EnsureType(broker(), input,
NodeType::kAnyHeapObject)) {
return ProcessResult::kRemove;
}Victor Gomes . unresolved
I guess this will become a common pattern. I wonder if we should introduce a helper for it.
```
REMOVE_AND_RETURN_IF_DONE(EnsureType(input, Type, DeoptReason::kSmi));
```
then a
```
ReduceResult EnsureType(ValueNode *input, NodeType type, DeoptimizeReason reason = DeoptimizeReason::WrongValue) {
if (IsEmptyNodeType(
IntersectType(known_node_aspects().GetType(broker(), input),
type))) {
return EmitUnconditionalDeopt(reason);
}
if (!known_node_aspects().EnsureType(broker(), input, type)) {
return {};
}
return ReduceResult::Done();
}
```
```
#define REMOVE_AND_RETURN_IF_DONE(result) \
do { \
auto res = (result); \
if (IsDoneWithAbort(res)) { \
return ProcessResult::kTruncateBlock; \
} else if (IsDone(res)) {
return ProcessResult::kRemove; \
DCHECK(IsFail(result)); \
} while (false)
```
Line 737, Patchset 1 (Latest):
if (IsEmptyNodeType(
IntersectType(known_node_aspects().GetType(broker(), input),
NodeType::kJSReceiver))) {
return DeoptAndTruncate(DeoptimizeReason::kWrongInstanceType);
}
if (known_node_aspects().EnsureType(broker(), input,
NodeType::kJSReceiver)) {
return ProcessResult::kRemove;
}Victor Gomes . unresolved
REMOVE_AND_RETURN_IF_DONE(EnsureType(input, kJSReceiver, DeoptReason::kWrongInstanceType));
Related details
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages