PPC/S390[wasm-wide-arith]: wide multiplication implementation in turboshaft and liftoff [v8/v8 : main]
0 views
Skip to first unread message
rt-node-js-v8 (Gerrit)
3:30 PM (6 hours ago) 3:30 PM
to Milad Farazmand, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Milad Farazmand
Message from rt-node-js-v8![]( "Open in Gerrit")
LGTM
Related details
Attention is currently required from:
- Milad Farazmand
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
3:35 PM (6 hours ago) 3:35 PM
to John, Jakob Kummerow, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow and John
Milad Farazmand added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Jakob Kummerow
- John
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
4:02 PM (5 hours ago) 4:02 PM
to Milad Farazmand, Jakob Kummerow, John, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from John and Milad Farazmand
Jakob Kummerow voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Code-Review | +1 |
1 comment
Patchset-level comments
Jakob Kummerow . resolved
Non-platform-specific files LGTM; rubberstamping the ppc/s390 specific files as usual.
Related details
Attention is currently required from:
- John
- Milad Farazmand
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
4:04 PM (5 hours ago) 4:04 PM
to Jakob Kummerow, John, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from John
Milad Farazmand added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jakob Kummerow . resolved
Non-platform-specific files LGTM; rubberstamping the ppc/s390 specific files as usual.
Milad Farazmand
Thank you for reviewing.
Related details
Attention is currently required from:
- John
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
8:26 PM (1 hour ago) 8:26 PM
to Jakob Kummerow, John, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from John
Milad Farazmand added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Milad Farazmand . resolved
@junyan Could you take a look as well when you get a sec, thanks.
Related details
Attention is currently required from:
- John
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages