[cleanup] Remove references to CodePointerTable [v8/v8 : main]

0 views
Skip to first unread message

Arash Kazemi (Gerrit)

unread,
Jun 9, 2026, 12:08:52 PM (2 days ago) Jun 9
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Michael Lippautz

Arash Kazemi added 1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Arash Kazemi . resolved

During a rebase I noticed that there were still some unused references for the CPT, PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id52b244a3571f8ddf11af483497bd71f5edd2553
Gerrit-Change-Number: 7893537
Gerrit-PatchSet: 9
Gerrit-Owner: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 16:08:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Jun 9, 2026, 12:28:33 PM (2 days ago) Jun 9
to Arash Kazemi, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Arash Kazemi

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Arash Kazemi
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id52b244a3571f8ddf11af483497bd71f5edd2553
Gerrit-Change-Number: 7893537
Gerrit-PatchSet: 9
Gerrit-Owner: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Arash Kazemi <ara...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 16:28:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Arash Kazemi (Gerrit)

unread,
Jun 10, 2026, 1:46:51 AM (yesterday) Jun 10
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, was...@google.com

Arash Kazemi voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id52b244a3571f8ddf11af483497bd71f5edd2553
Gerrit-Change-Number: 7893537
Gerrit-PatchSet: 9
Gerrit-Owner: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Wed, 10 Jun 2026 05:46:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 10, 2026, 3:07:53 AM (yesterday) Jun 10
to Arash Kazemi, Michael Lippautz, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, was...@google.com

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[cleanup] Remove references to CodePointerTable

Removes unused constants, replaces CodePointerHandle with
IndirectPointerHandle, and renames constants for the wasm CPT.

TAG=agy
Bug: 498510170
Change-Id: Id52b244a3571f8ddf11af483497bd71f5edd2553
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Arash Kazemi <ara...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107871}
Files:
  • M docs/sandbox/architecture.md
  • M include/v8-internal.h
  • M src/common/globals.h
  • M src/objects/code-inl.h
  • M src/wasm/wasm-code-pointer-table.h
Change size: S
Delta: 5 files changed, 7 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id52b244a3571f8ddf11af483497bd71f5edd2553
Gerrit-Change-Number: 7893537
Gerrit-PatchSet: 10
Gerrit-Owner: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages