[typed arrays] Fix ElementsKinds switcheroo with Atomics [v8/v8 : main]

24 views
Skip to first unread message

Marja Hölttä (Gerrit)

unread,
Mar 10, 2026, 9:41:58 AMMar 10
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

Marja Hölttä voted and added 1 comment

Votes added by Marja Hölttä

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Marja Hölttä . resolved

ptal, lmk if you need more context

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2359ff752df3760ffaf246e218f92c448f26d84e
Gerrit-Change-Number: 7651904
Gerrit-PatchSet: 2
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 13:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Igor Sheludko (Gerrit)

unread,
Mar 10, 2026, 1:22:12 PMMar 10
to Marja Hölttä, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Marja Hölttä

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Code-Review+1

1 comment

Patchset-level comments
Igor Sheludko . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Marja Hölttä
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2359ff752df3760ffaf246e218f92c448f26d84e
Gerrit-Change-Number: 7651904
Gerrit-PatchSet: 2
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 17:22:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Marja Hölttä (Gerrit)

unread,
Mar 11, 2026, 3:13:28 AMMar 11
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com

Marja Hölttä voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2359ff752df3760ffaf246e218f92c448f26d84e
Gerrit-Change-Number: 7651904
Gerrit-PatchSet: 2
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Mar 2026 07:13:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Mar 11, 2026, 3:16:47 AMMar 11
to Marja Hölttä, Igor Sheludko, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[typed arrays] Fix ElementsKinds switcheroo with Atomics
Fixed: 488927521
Change-Id: I2359ff752df3760ffaf246e218f92c448f26d84e
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Marja Hölttä <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105715}
Files:
  • M src/builtins/builtins-sharedarraybuffer-gen.cc
  • M src/codegen/code-stub-assembler.cc
  • M src/codegen/code-stub-assembler.h
  • A test/mjsunit/sandbox/regress-488927521.js
Change size: M
Delta: 4 files changed, 113 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Igor Sheludko
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2359ff752df3760ffaf246e218f92c448f26d84e
Gerrit-Change-Number: 7651904
Gerrit-PatchSet: 3
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages