[heap] Add notes for preempting/finishing jobs [v8/v8 : main]
0 views
Skip to first unread message
Omer Katz (Gerrit)
Dec 15, 2025, 9:26:33 AM (23 hours ago) Dec 15
to Michael Lippautz, V8 LUCI CQ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Omer Katz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Dec 15, 2025, 10:04:49 AM (23 hours ago) Dec 15
to Omer Katz, V8 LUCI CQ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
2 comments
Patchset-level comments
Michael Lippautz . resolved
lgtm
File src/heap/array-buffer-sweeper.cc
Line 458, Patchset 1 (Latest):
TRACE_GC_NOTE("ArrayBufferSweeper Finished");Michael Lippautz . unresolved
How are the notes visible in a trace?
Related details
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Dec 15, 2025, 11:22:35 AM (21 hours ago) Dec 15
to Michael Lippautz, V8 LUCI CQ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Omer Katz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Omer Katz
| Commit-Queue | +2 |
1 comment
File src/heap/array-buffer-sweeper.cc
Line 458, Patchset 1 (Latest):
TRACE_GC_NOTE("ArrayBufferSweeper Finished");Michael Lippautz . resolved
How are the notes visible in a trace?
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 15, 2025, 11:24:06 AM (21 hours ago) Dec 15
to Omer Katz, Michael Lippautz, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Add notes for preempting/finishing jobs
Help distinguish on a trace which concurrent jobs end because of
preemption and which end because they run out of work.
Notes are added only to jobs that can yield.
Bug: 42204085
Change-Id: If3064174cc6ccfda50230b906589f456983e46a9
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104328}
Files:
- M src/heap/array-buffer-sweeper.cc
- M src/heap/concurrent-marking.cc
- M src/heap/cppgc/concurrent-marker.cc
- M src/heap/cppgc/stats-collector.h
- M src/heap/cppgc/sweeper.cc
- M src/heap/scavenger.cc
- M src/heap/sweeper.cc
- M src/heap/sweeper.h
Change size: S
Delta: 8 files changed, 34 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages