[fuzzing] Add a fallback to load the wasm-module-builder [v8/v8 : main]
Michael Achenbach (Gerrit)
Michael Achenbach voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Achenbach
| Commit-Queue | +1 |
2 comments
This is an initial, slightly hacky suggestion. Is there a better place to put this?
Would we want this more generically?
Related details
- Clemens Backes
- Samuel Groß
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Michael Achenbach added 1 comment![]( "Open in Gerrit")
I'm actually checking if the d8 change is needed at all. See http://b/490084113#comment8 - need to investigate CF code.
Related details
- Clemens Backes
- Samuel Groß
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Michael Achenbach voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Achenbach
| Commit-Queue | +1 |
1 comment
I'm actually checking if the d8 change is needed at all. See http://b/490084113#comment8 - need to investigate CF code.
Hold off... I think I can just drop the d8 change again.
Related details
- Clemens Backes
- Michael Achenbach
- Samuel Groß
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Michael Achenbach voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Achenbach
| Commit-Queue | +1 |
2 comments
directory, assuming that Clusterfuzz runs V8 from the build
directory.Related details
- Clemens Backes
- Samuel Groß
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Clemens Backes voted Code-Review+1![]( "Open in Gerrit")
- Michael Achenbach
- Samuel Groß
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Michael Achenbach added 1 comment![]( "Open in Gerrit")
This is an initial, slightly hacky suggestion. Is there a better place to put this?
Would we want this more generically?
- Samuel Groß
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Michael Achenbach voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
- Samuel Groß
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[fuzzing] Add a fallback to load the wasm-module-builder
This makes it possible to run test cases that lack access to the
wasm module builder but reference in their code:
d8.file.execute('test/mjsunit/wasm/wasm-module-builder.js');
For Clusterfuzz archives, the file is bundled in the build
directory, assuming that Clusterfuzz runs V8 from the build
directory.
- M BUILD.gn
Code-Review: +1 by Clemens Backes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Corry (Gerrit)
Erik Corry added 1 comment![]( "Open in Gerrit")
This breaks the build for me. Now it just removes the js file from my checkout and then the build fails.
$ ninja -C out.gn/x64.release
ninja: Entering directory `out.gn/x64.release'
[0/1] Regenerating ninja files
[1132/5216] COPY ../../test/mjsunit/wasm/wasm-module-builder.js test/mjsunit/wasm/wasm-module-builder.js
FAILED: test/mjsunit/wasm/wasm-module-builder.js
ln -f ../../test/mjsunit/wasm/wasm-module-builder.js test/mjsunit/wasm/wasm-module-builder.js 2>/dev/null || (rm -rf test/mjsunit/wasm/wasm-module-builder.js && cp -af ../../test/mjsunit/wasm/wasm-module-builder.js test/mjsunit/wasm/wasm-module-builder.js)
cp: cannot stat '../../test/mjsunit/wasm/wasm-module-builder.js': No such file or directory
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Michael Achenbach added 1 comment![]( "Open in Gerrit")
This breaks the build for me. Now it just removes the js file from my checkout and then the build fails.
$ ninja -C out.gn/x64.release
ninja: Entering directory `out.gn/x64.release'
[0/1] Regenerating ninja files
[1132/5216] COPY ../../test/mjsunit/wasm/wasm-module-builder.js test/mjsunit/wasm/wasm-module-builder.js
FAILED: test/mjsunit/wasm/wasm-module-builder.js
ln -f ../../test/mjsunit/wasm/wasm-module-builder.js test/mjsunit/wasm/wasm-module-builder.js 2>/dev/null || (rm -rf test/mjsunit/wasm/wasm-module-builder.js && cp -af ../../test/mjsunit/wasm/wasm-module-builder.js test/mjsunit/wasm/wasm-module-builder.js)
cp: cannot stat '../../test/mjsunit/wasm/wasm-module-builder.js': No such file or directory
Strange, I don't see that behavior. What GN flags do you use? Is this in connection to this cluster build maybe? In this case, feel free to skip this target behind this GN flag.
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |