[frames] Track stack frame iteration depth in StackFrameIterator [v8/v8 : main]

3 views
Skip to first unread message

Jakob Linke (Gerrit)

unread,
Dec 1, 2025, 6:13:34 AM12/1/25
to Yahan Lu (LuYahan), V8 LUCI CQ, Ji Qiu, Kasper Lund, Igor Sheludko, v8-re...@googlegroups.com
Attention needed from Igor Sheludko, Ji Qiu, Kasper Lund and Yahan Lu (LuYahan)

Jakob Linke added 1 comment

Commit Message
Line 9, Patchset 8 (Latest):This change adds a mechanism to track the depth of frame iteration. The iteration depth is stored in the StackFrameState
Jakob Linke . unresolved

I'm missing some context. What is the motivation? And why store the depth both in the state and the iterator?

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
  • Ji Qiu
  • Kasper Lund
  • Yahan Lu (LuYahan)
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
Gerrit-Change-Number: 7206634
Gerrit-PatchSet: 8
Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 11:13:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Yahan Lu (LuYahan) (Gerrit)

unread,
Dec 1, 2025, 7:58:11 PM12/1/25
to V8 LUCI CQ, Ji Qiu, Kasper Lund, Jakob Linke, Igor Sheludko, v8-re...@googlegroups.com
Attention needed from Igor Sheludko, Jakob Linke, Ji Qiu and Kasper Lund

Yahan Lu (LuYahan) added 1 comment

Commit Message
Line 9, Patchset 8 (Latest):This change adds a mechanism to track the depth of frame iteration. The iteration depth is stored in the StackFrameState
Jakob Linke . unresolved

I'm missing some context. What is the motivation? And why store the depth both in the state and the iterator?

Yahan Lu (LuYahan)

I want to support RISC-V ShdaowStack. When PointerAuthentication::ReplacePC modiys pc on stack, RISC-V ShdaowStack need the info for depth. I think I can only store depth in state.

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
  • Jakob Linke
  • Ji Qiu
  • Kasper Lund
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
Gerrit-Change-Number: 7206634
Gerrit-PatchSet: 8
Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 00:58:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakob Linke <jgr...@chromium.org>
unsatisfied_requirement
open
diffy

Jakob Linke (Gerrit)

unread,
Dec 4, 2025, 12:27:16 AM12/4/25
to Yahan Lu (LuYahan), V8 LUCI CQ, Ji Qiu, Kasper Lund, Igor Sheludko, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-risc...@chromium.org, victorgo...@chromium.org, was...@google.com, v8-re...@googlegroups.com
Attention needed from Igor Sheludko, Ji Qiu, Kasper Lund and Yahan Lu (LuYahan)

Jakob Linke voted and added 2 comments

Votes added by Jakob Linke

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Jakob Linke . resolved

lg from my side

Commit Message
Line 9, Patchset 8:This change adds a mechanism to track the depth of frame iteration. The iteration depth is stored in the StackFrameState
Jakob Linke . resolved

I'm missing some context. What is the motivation? And why store the depth both in the state and the iterator?

Yahan Lu (LuYahan)

I want to support RISC-V ShdaowStack. When PointerAuthentication::ReplacePC modiys pc on stack, RISC-V ShdaowStack need the info for depth. I think I can only store depth in state.

Jakob Linke

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
  • Ji Qiu
  • Kasper Lund
  • Yahan Lu (LuYahan)
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
    Gerrit-Change-Number: 7206634
    Gerrit-PatchSet: 12
    Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
    Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
    Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
    Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
    Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
    Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
    Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
    Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
    Gerrit-Comment-Date: Thu, 04 Dec 2025 05:27:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Jakob Linke <jgr...@chromium.org>
    Comment-In-Reply-To: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Igor Sheludko (Gerrit)

    unread,
    Dec 4, 2025, 4:33:17 AM12/4/25
    to Yahan Lu (LuYahan), Jakob Linke, V8 LUCI CQ, Ji Qiu, Kasper Lund, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-risc...@chromium.org, victorgo...@chromium.org, was...@google.com, v8-re...@googlegroups.com
    Attention needed from Ji Qiu, Kasper Lund and Yahan Lu (LuYahan)

    Igor Sheludko added 3 comments

    Patchset-level comments
    Igor Sheludko . resolved

    nits

    Commit Message
    Line 9, Patchset 12 (Latest):This change adds a mechanism to track the depth of frame iteration. The iteration depth is stored in the StackFrameState
    Igor Sheludko . unresolved

    Please format the comment to fit into 72 chars and please add `.` at the end.

    File src/execution/frames.h
    Line 186, Patchset 12 (Latest): int iterate_depth = -1;
    Igor Sheludko . unresolved

    `iteration_depth` sounds a bit better and please add a comment.

    Please consider making the value `uint32_t` and initializing it to `0` - this would avoid the need to modify `Reset` functions below. I guess it's fare to assume that a stack iterator that wasn't advanced yet points to a frame of depth zero.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ji Qiu
    • Kasper Lund
    • Yahan Lu (LuYahan)
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
      Gerrit-Change-Number: 7206634
      Gerrit-PatchSet: 12
      Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
      Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
      Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
      Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
      Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
      Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
      Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
      Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
      Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
      Gerrit-Comment-Date: Thu, 04 Dec 2025 09:33:12 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Yahan Lu (LuYahan) (Gerrit)

      unread,
      Dec 9, 2025, 3:10:31 AM12/9/25
      to Jakob Linke, V8 LUCI CQ, Ji Qiu, Kasper Lund, Igor Sheludko, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-risc...@chromium.org, victorgo...@chromium.org, was...@google.com, v8-re...@googlegroups.com
      Attention needed from Igor Sheludko, Ji Qiu and Kasper Lund

      Yahan Lu (LuYahan) voted and added 2 comments

      Votes added by Yahan Lu (LuYahan)

      Auto-Submit+1

      2 comments

      Commit Message
      Line 9, Patchset 12:This change adds a mechanism to track the depth of frame iteration. The iteration depth is stored in the StackFrameState
      Igor Sheludko . resolved

      Please format the comment to fit into 72 chars and please add `.` at the end.

      Yahan Lu (LuYahan)

      Done

      File src/execution/frames.h
      Line 186, Patchset 12: int iterate_depth = -1;
      Igor Sheludko . resolved

      `iteration_depth` sounds a bit better and please add a comment.

      Please consider making the value `uint32_t` and initializing it to `0` - this would avoid the need to modify `Reset` functions below. I guess it's fare to assume that a stack iterator that wasn't advanced yet points to a frame of depth zero.

      Yahan Lu (LuYahan)

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Igor Sheludko
      • Ji Qiu
      • Kasper Lund
      Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: v8/v8
        Gerrit-Branch: main
        Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
        Gerrit-Change-Number: 7206634
        Gerrit-PatchSet: 14
        Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
        Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
        Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
        Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
        Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
        Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
        Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
        Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
        Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
        Gerrit-Comment-Date: Tue, 09 Dec 2025 08:10:26 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Igor Sheludko <ish...@chromium.org>
        satisfied_requirement
        open
        diffy

        Igor Sheludko (Gerrit)

        unread,
        Dec 9, 2025, 3:50:23 AM12/9/25
        to Yahan Lu (LuYahan), Jakob Linke, V8 LUCI CQ, Ji Qiu, Kasper Lund, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-risc...@chromium.org, victorgo...@chromium.org, was...@google.com, v8-re...@googlegroups.com
        Attention needed from Ji Qiu, Kasper Lund and Yahan Lu (LuYahan)

        Igor Sheludko voted and added 3 comments

        Votes added by Igor Sheludko

        Code-Review+1

        3 comments

        Patchset-level comments
        File-level comment, Patchset 14 (Latest):
        Igor Sheludko . resolved

        lgtm with nits

        Commit Message
        Line 10, Patchset 14 (Latest):The iteration depth is stored in the StackFrameState.
        Igor Sheludko . unresolved

        Since there's no tracking bug for this work (or maybe you have one?), could you please add a comment why are you doing this or/and maybe add a tracking `Bug:` too.

        File src/execution/frames.h
        Line 187, Patchset 14 (Latest): // see StackFrameIterator::Advance
        Igor Sheludko . unresolved

        Please finish comments with `.`.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Ji Qiu
        • Kasper Lund
        • Yahan Lu (LuYahan)
          Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement is not satisfiedNo-Unresolved-Comments
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: v8/v8
            Gerrit-Branch: main
            Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
            Gerrit-Change-Number: 7206634
            Gerrit-PatchSet: 14
            Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
            Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
            Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
            Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
            Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
            Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
            Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
            Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
            Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
            Gerrit-Comment-Date: Tue, 09 Dec 2025 08:50:18 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Yahan Lu (LuYahan) (Gerrit)

            unread,
            Dec 9, 2025, 4:58:45 AM12/9/25
            to Igor Sheludko, Jakob Linke, V8 LUCI CQ, Ji Qiu, Kasper Lund, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-risc...@chromium.org, victorgo...@chromium.org, was...@google.com, v8-re...@googlegroups.com
            Attention needed from Ji Qiu and Kasper Lund

            Yahan Lu (LuYahan) voted and added 2 comments

            Votes added by Yahan Lu (LuYahan)

            Auto-Submit+1

            2 comments

            Commit Message
            Line 10, Patchset 14:The iteration depth is stored in the StackFrameState.
            Igor Sheludko . resolved

            Since there's no tracking bug for this work (or maybe you have one?), could you please add a comment why are you doing this or/and maybe add a tracking `Bug:` too.

            Yahan Lu (LuYahan)

            Done

            File src/execution/frames.h
            Line 187, Patchset 14: // see StackFrameIterator::Advance
            Igor Sheludko . resolved

            Please finish comments with `.`.

            Yahan Lu (LuYahan)

            Done

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Ji Qiu
            • Kasper Lund
            Submit Requirements:
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: v8/v8
              Gerrit-Branch: main
              Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
              Gerrit-Change-Number: 7206634
              Gerrit-PatchSet: 16
              Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
              Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
              Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
              Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
              Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
              Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
              Gerrit-Comment-Date: Tue, 09 Dec 2025 09:58:40 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              Comment-In-Reply-To: Igor Sheludko <ish...@chromium.org>
              satisfied_requirement
              open
              diffy

              Yahan Lu (LuYahan) (Gerrit)

              unread,
              Dec 9, 2025, 4:58:55 AM12/9/25
              to Igor Sheludko, Jakob Linke, V8 LUCI CQ, Ji Qiu, Kasper Lund, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-risc...@chromium.org, victorgo...@chromium.org, was...@google.com, v8-re...@googlegroups.com
              Attention needed from Ji Qiu and Kasper Lund

              Yahan Lu (LuYahan) voted Commit-Queue+2

              Commit-Queue+2
              Gerrit-Comment-Date: Tue, 09 Dec 2025 09:58:49 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              open
              diffy

              Igor Sheludko (Gerrit)

              unread,
              Dec 9, 2025, 8:23:10 AM12/9/25
              to Yahan Lu (LuYahan), Jakob Linke, V8 LUCI CQ, Ji Qiu, Kasper Lund, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-risc...@chromium.org, victorgo...@chromium.org, was...@google.com, v8-re...@googlegroups.com
              Attention needed from Ji Qiu, Kasper Lund and Yahan Lu (LuYahan)

              Igor Sheludko voted and added 1 comment

              Votes added by Igor Sheludko

              Code-Review+1

              1 comment

              Patchset-level comments
              Igor Sheludko . resolved

              lgtm

              Open in Gerrit

              Related details

              Attention is currently required from:
              • Ji Qiu
              • Kasper Lund
              • Yahan Lu (LuYahan)
              Submit Requirements:
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: v8/v8
              Gerrit-Branch: main
              Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
              Gerrit-Change-Number: 7206634
              Gerrit-PatchSet: 17
              Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
              Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
              Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
              Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
              Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
              Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
              Gerrit-Comment-Date: Tue, 09 Dec 2025 13:23:05 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              open
              diffy

              Yahan Lu (LuYahan) (Gerrit)

              unread,
              Dec 9, 2025, 7:40:27 PM12/9/25
              to Igor Sheludko, Jakob Linke, V8 LUCI CQ, Ji Qiu, Kasper Lund, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-risc...@chromium.org, victorgo...@chromium.org, was...@google.com, v8-re...@googlegroups.com
              Attention needed from Ji Qiu and Kasper Lund

              Yahan Lu (LuYahan) voted Commit-Queue+2

              Commit-Queue+2
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Ji Qiu
              • Kasper Lund
              Submit Requirements:
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: v8/v8
              Gerrit-Branch: main
              Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
              Gerrit-Change-Number: 7206634
              Gerrit-PatchSet: 17
              Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
              Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
              Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
              Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
              Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
              Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
              Gerrit-Comment-Date: Wed, 10 Dec 2025 00:40:22 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              open
              diffy

              V8 LUCI CQ (Gerrit)

              unread,
              Dec 9, 2025, 7:42:24 PM12/9/25
              to Yahan Lu (LuYahan), Igor Sheludko, Jakob Linke, Ji Qiu, Kasper Lund, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, pthier...@chromium.org, v8-flag...@chromium.org, v8-risc...@chromium.org, victorgo...@chromium.org, was...@google.com, v8-re...@googlegroups.com

              V8 LUCI CQ submitted the change

              Change information

              Commit message:
              [frames] Track stack frame iteration depth in StackFrameIterator


              This change adds a mechanism to track the depth of frame iteration.
              The iteration depth is stored in the StackFrameState.

              Bug:454180124
              Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
              Reviewed-by: Jakob Linke <jgr...@chromium.org>
              Reviewed-by: Igor Sheludko <ish...@chromium.org>
              Commit-Queue: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Auto-Submit: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Cr-Commit-Position: refs/heads/main@{#104217}
              Files:
              • M src/execution/frames.cc
              • M src/execution/frames.h
              • M src/execution/isolate.cc
              Change size: S
              Delta: 3 files changed, 7 insertions(+), 3 deletions(-)
              Branch: refs/heads/main
              Submit Requirements:
              • requirement satisfiedCode-Review: +1 by Igor Sheludko, +1 by Jakob Linke
              Open in Gerrit
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: merged
              Gerrit-Project: v8/v8
              Gerrit-Branch: main
              Gerrit-Change-Id: Ifa32fe859d3b233ffa872ed7158cef3b921fbf59
              Gerrit-Change-Number: 7206634
              Gerrit-PatchSet: 18
              Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
              Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
              Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
              Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
              Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
              open
              diffy
              satisfied_requirement
              Reply all
              Reply to author
              Forward
              0 new messages