[wasm][shared] Implement waitqueue with a global lock [v8/v8 : main]
0 views
Skip to first unread message
Manos Koukoutos (Gerrit)
8:32 AM (14 hours ago) 8:32 AM
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Manos Koukoutos voted and added 1 comment![]( "Open in Gerrit")
Votes added by Manos Koukoutos
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
11:53 AM (11 hours ago) 11:53 AM
to Manos Koukoutos, Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manos Koukoutos (Gerrit)
12:49 PM (10 hours ago) 12:49 PM
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Manos Koukoutos voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
12:51 PM (10 hours ago) 12:51 PM
to Manos Koukoutos, Jakob Kummerow, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm][shared] Implement waitqueue with a global lock
To get to a correct state when it comes to waitqueue, implement it
with a global lock for now. In the future we will try to refine the
locking mechanism so each waitqueue has its own lock.
Drive-by: in `NotifyWake()`, change the `interrupted_` flag of the
`FutexWaitListNode` before waking the respective thread.
Bug: 42204563, 475455008
Change-Id: Idcb37c9256e223cd0e30964337383ff8a5279fe3
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Manos Koukoutos <mano...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105828}
Files:
- M src/execution/futex-emulation.cc
- M src/execution/futex-emulation.h
Change size: S
Delta: 2 files changed, 9 insertions(+), 33 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages