[regexp] Support unaligned reads in bytecode [v8/v8 : main]
0 views
Skip to first unread message
Patrick Thier (Gerrit)
Sep 4, 2025, 3:47:14 AM (3 days ago) Sep 4
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Patrick Thier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Sep 4, 2025, 4:32:56 AM (3 days ago) Sep 4
to Patrick Thier, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Jakob Linke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Linke
| Code-Review | +1 |
1 comment
File src/regexp/regexp-bytecodes.h
Line 24, Patchset 1 (Latest):
// In the new bytecode layout we only support packing of up to 2 bytes.Jakob Linke . unresolved
```suggestion
// We only support packing of up to 2 bytes.
```
Imo we shouldn't mention the old layout anymore in new comments.
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Sep 4, 2025, 8:17:06 AM (3 days ago) Sep 4
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Patrick Thier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Thier
| Commit-Queue | +2 |
1 comment
File src/regexp/regexp-bytecodes.h
Line 24, Patchset 1:
// In the new bytecode layout we only support packing of up to 2 bytes.Jakob Linke . resolved
```suggestion
// We only support packing of up to 2 bytes.
```Imo we shouldn't mention the old layout anymore in new comments.
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 4, 2025, 8:53:57 AM (3 days ago) Sep 4
to Patrick Thier, Jakob Linke, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/regexp/regexp-bytecodes.h
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[regexp] Support unaligned reads in bytecode
Previously RegExp bytecode didn't support unaligned reads, to be able
to run on all architectures. But RegExp bytecode is not shared across
architectures so we can support unaligned reads also for bytecode
if the architecture supports it.
Drive-by fixes:
- Add missing AndCheckNot4Chars lowering to RegExpCodeGenerator
- Limit first argument packing in bytecode to 2 byte
Bug: 437003349
Change-Id: Ifb74b4b904514ac0753167aa39a7d88ff8ba58c7
Reviewed-by: Jakob Linke <jgr...@chromium.org>
Commit-Queue: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102245}
Files:
- M src/regexp/mips64/regexp-macro-assembler-mips64.cc
- M src/regexp/mips64/regexp-macro-assembler-mips64.h
- M src/regexp/regexp-bytecode-generator.h
- M src/regexp/regexp-bytecodes.h
- M src/regexp/regexp-code-generator.cc
- M src/regexp/regexp-macro-assembler-arch.h
- M src/regexp/regexp-macro-assembler-tracer.h
- M src/regexp/regexp-macro-assembler.cc
- M src/regexp/regexp-macro-assembler.h
- M src/regexp/riscv/regexp-macro-assembler-riscv.cc
- M src/regexp/riscv/regexp-macro-assembler-riscv.h
Change size: M
Delta: 11 files changed, 29 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Linke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages