[scope-info] Hash module variable names in large module scopes [v8/v8 : main]

[Samuel Attard (Gerrit)]

Attention needed from Jakob Kummerow, Jakob Linke and Toon Verwaest

Samuel Attard added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Samuel Attard . resolved

Hey folks, pretty standard perf win for modules with lots of bindings, ScopeInfo::ModuleIndex was a linear scan over module_variables, so I gave large module scopes a name→index hashtable like context locals already have. Measured ~23ms→1ms per load under ModuleIndex on a real app (115 ESM chunks); PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Jakob Kummerow
• Jakob Linke
• Toon Verwaest

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I211704c5a713ec9df89d87ec40a0cafb282d5bd9

Gerrit-Change-Number: 8259941

Gerrit-PatchSet: 2

Gerrit-Owner: Samuel Attard <samuel....@gmail.com>

Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>

Gerrit-Reviewer: Samuel Attard <samuel....@gmail.com>

Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Toon Verwaest <verw...@chromium.org>

Gerrit-Attention: Jakob Linke <jgr...@chromium.org>

Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Comment-Date: Sat, 15 Aug 2026 00:02:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No