Add check_bazel_deps.py tool to monitor and update Bzlmod dependencies [v8/v8 : main]
Victor Gomes (Gerrit)
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Related details
- Michael Achenbach
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Michael Achenbach voted and added 3 comments![]( "Open in Gerrit")
Votes added by Michael Achenbach
| Code-Review | +1 |
3 comments
Thanks! I only did a very light review. I assume the AI is going to maintain this script in the future. Furthermore I assume that we'll review the CLs produced by this script and that also the bazel bot needs to pass on them. Hence the bar for any mischief is high...
"--file", "-f", default="MODULE.bazel", help="Path to MODULE.bazel file")Can we default this to the file in the V8 base dir relative to this script? In the current version it would only work if the CWD is the V8 base dir, which is not granted when executing scripts on bots.
print("Please run `bazel mod tidy` to regenerate MODULE.bazel.lock.")Is that needed? I don't see such a file in our repo.
Related details
- Victor Gomes
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Victor Gomes voted and added 4 comments![]( "Open in Gerrit")
Votes added by Victor Gomes
| Auto-Submit | +1 |
| Commit-Queue | +2 |
Thanks! I only did a very light review. I assume the AI is going to maintain this script in the future. Furthermore I assume that we'll review the CLs produced by this script and that also the bazel bot needs to pass on them. Hence the bar for any mischief is high...
Yeah, I also think so.
"--file", "-f", default="MODULE.bazel", help="Path to MODULE.bazel file")Can we default this to the file in the V8 base dir relative to this script? In the current version it would only work if the CWD is the V8 base dir, which is not granted when executing scripts on bots.
Done
print("Please run `bazel mod tidy` to regenerate MODULE.bazel.lock.")Is that needed? I don't see such a file in our repo.
We don't use it. AI slop! 😊
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tools/check_bazel_deps.py
Insertions: 5, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Add check_bazel_deps.py tool to monitor and update Bzlmod dependencies
This script parses MODULE.bazel for bazel_dep declarations and queries the Bazel Central Registry to check for newer versions. It distinguishes between stable releases and pre-releases (such as release candidates).
It also supports automatically updating MODULE.bazel in-place using the --update flag.
TAG=agy
CONV=a02928b1-06a9-426a-8821-743388252a94
- A tools/check_bazel_deps.py
Code-Review: +1 by Michael Achenbach
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |