[turbolev] Enable range analysis [v8/v8 : main]

0 views
Skip to first unread message

Victor Gomes (Gerrit)

unread,
Jun 9, 2026, 9:01:36 AM (22 hours ago) Jun 9
to Leszek Swirski, Darius Mercadier, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Victor Gomes . resolved

As discussed offline. PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7b7e6288ca670e3d689b5b643b028b19f76bf7d2
Gerrit-Change-Number: 7910746
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-CC: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 13:01:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
Jun 9, 2026, 9:02:57 AM (22 hours ago) Jun 9
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Leszek Swirski, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski and Victor Gomes

Darius Mercadier voted and added 2 comments

Votes added by Darius Mercadier

Code-Review+1

2 comments

Patchset-level comments
Darius Mercadier . resolved

Let's go!!! :)

File src/flags/flag-definitions.h
Line 709, Patchset 1 (Latest):// TODO(victorgomes): Consider renaming this to turbolev range analysis, since
// it doesn't not enable this pass in the maglev pipeline?
Darius Mercadier . resolved

Yea please do :)

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
  • Victor Gomes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7b7e6288ca670e3d689b5b643b028b19f76bf7d2
Gerrit-Change-Number: 7910746
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 13:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
Jun 9, 2026, 10:51:43 AM (20 hours ago) Jun 9
to Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Leszek Swirski, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Victor Gomes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7b7e6288ca670e3d689b5b643b028b19f76bf7d2
Gerrit-Change-Number: 7910746
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 14:51:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 9, 2026, 12:13:21 PM (19 hours ago) Jun 9
to Victor Gomes, Darius Mercadier, Leszek Swirski, v8-flag...@chromium.org, v8-re...@googlegroups.com

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[turbolev] Enable range analysis
Bug: 447172725
Change-Id: I7b7e6288ca670e3d689b5b643b028b19f76bf7d2
Auto-Submit: Victor Gomes <victo...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107866}
Files:
  • M src/flags/flag-definitions.h
Change size: XS
Delta: 1 file changed, 4 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darius Mercadier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7b7e6288ca670e3d689b5b643b028b19f76bf7d2
Gerrit-Change-Number: 7910746
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages