[wasmfx] Reload memory cache after suspend [v8/v8 : main]

1 view
Skip to first unread message

Thibaud Michaud (Gerrit)

unread,
Mar 10, 2026, 8:27:36 AMMar 10
to Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow

Thibaud Michaud voted and added 1 comment

Votes added by Thibaud Michaud

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thibaud Michaud . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7318d502200a14d1e50880c6b35d3211c8ae11be
Gerrit-Change-Number: 7651903
Gerrit-PatchSet: 1
Gerrit-Owner: Thibaud Michaud <thib...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 12:27:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jakob Kummerow (Gerrit)

unread,
Mar 10, 2026, 8:31:00 AMMar 10
to Thibaud Michaud, Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Thibaud Michaud

Jakob Kummerow voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thibaud Michaud
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7318d502200a14d1e50880c6b35d3211c8ae11be
Gerrit-Change-Number: 7651903
Gerrit-PatchSet: 1
Gerrit-Owner: Thibaud Michaud <thib...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
Gerrit-Attention: Thibaud Michaud <thib...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 12:30:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thibaud Michaud (Gerrit)

unread,
Mar 10, 2026, 8:32:07 AMMar 10
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com

Thibaud Michaud voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7318d502200a14d1e50880c6b35d3211c8ae11be
Gerrit-Change-Number: 7651903
Gerrit-PatchSet: 1
Gerrit-Owner: Thibaud Michaud <thib...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 12:32:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Mar 10, 2026, 9:02:21 AMMar 10
to Thibaud Michaud, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[wasmfx] Reload memory cache after suspend

The memory can grow while the stack is suspended.

R=jkum...@chromium.org
Fixed: 489349562
Change-Id: I7318d502200a14d1e50880c6b35d3211c8ae11be
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Thibaud Michaud <thib...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105701}
Files:
  • M src/wasm/turboshaft-graph-interface.cc
  • A test/mjsunit/regress/wasm/regress-489349562.js
Change size: M
Delta: 2 files changed, 61 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jakob Kummerow
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7318d502200a14d1e50880c6b35d3211c8ae11be
Gerrit-Change-Number: 7651903
Gerrit-PatchSet: 2
Gerrit-Owner: Thibaud Michaud <thib...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages