[turboshaft] Enable Turboshaft CSA pipeline [v8/v8 : main]
14 views
Skip to first unread message
Darius Mercadier (Gerrit)
Apr 2, 2024, 11:33:29 AM4/2/24
to Nico Hartmann, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Darius Mercadier voted and added 4 comments![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
4 comments
Patchset-level comments
File src/compiler/backend/arm64/code-generator-arm64.cc
Line 1988, Patchset 11 (Latest):
__ uxtw(i.InputRegister64(1), i.InputRegister64(1));
__ orr(i.InputRegister64(0), i.InputRegister64(1),
Operand(i.InputRegister64(0), LSL, 32));Darius Mercadier . unresolved
As discussed offline, you shouldn't clobber input registers here.
File src/compiler/turboshaft/graph-builder.cc
Line 553, Patchset 11 (Latest):
return __ Word64Equal(V<Word64>::Cast(__ BitcastTaggedToWordPtr(Darius Mercadier . unresolved
This Cast shouldn't be needed.
Line 559, Patchset 11 (Latest):
V<Word64>::Cast(__ BitcastTaggedToWordPtr(Darius Mercadier . unresolved
Same thing, I don't think that this cast is needed.
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 2, 2024, 12:11:34 PM4/2/24
to Nico Hartmann, Darius Mercadier, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/104e736e3e0000
Related details
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 2, 2024, 1:31:27 PM4/2/24
to Nico Hartmann, Darius Mercadier, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12fcad353e0000
Related details
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Apr 3, 2024, 10:06:11 AM4/3/24
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Nico Hartmann added 1 comment![]( "Open in Gerrit")
File src/compiler/backend/arm64/code-generator-arm64.cc
Line 1988, Patchset 11:
__ uxtw(i.InputRegister64(1), i.InputRegister64(1));
__ orr(i.InputRegister64(0), i.InputRegister64(1),
Operand(i.InputRegister64(0), LSL, 32));Darius Mercadier . resolved
As discussed offline, you shouldn't clobber input registers here.
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Apr 3, 2024, 10:10:36 AM4/3/24
to Nico Hartmann, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 3, 2024, 1:02:33 PM4/3/24
to Nico Hartmann, Darius Mercadier, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16a7c3353e0000
Related details
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 3, 2024, 2:16:20 PM4/3/24
to Nico Hartmann, Darius Mercadier, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12edc18d3e0000
Related details
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Apr 4, 2024, 4:36:01 AM4/4/24
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Nico Hartmann voted and added 4 comments![]( "Open in Gerrit")
Votes added by Nico Hartmann
| Commit-Queue | +1 |
4 comments
Patchset-level comments
File src/compiler/turboshaft/graph-builder.cc
Line 553, Patchset 11:
return __ Word64Equal(V<Word64>::Cast(__ BitcastTaggedToWordPtr(Darius Mercadier . resolved
This Cast shouldn't be needed.
Nico Hartmann
Unfortunately, it is in the case when `WordPtr` is `Word32` (which is then unreachable though).
Same thing, I don't think that this cast is needed.
Nico Hartmann
Same here.
File src/flags/flag-definitions.h
Line 1350, Patchset 9:
DEFINE_BOOL(turboshaft_csa, true, "run the CSA pipeline with turboshaft")Nico Hartmann . resolved
Nico HartmannRevert this before landing and flip in a separate CL.
Done
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Apr 4, 2024, 4:45:50 AM4/4/24
to Nico Hartmann, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Apr 4, 2024, 4:47:24 AM4/4/24
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Nico Hartmann voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Apr 4, 2024, 4:47:50 AM4/4/24
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, Michael Hablich, almuthan...@chromium.org, saelo...@chromium.org, v8-re...@googlegroups.com
Nico Hartmann removed a vote from this change![]( "Open in Gerrit")
Removed Commit-Queue+2 by Nico Hartmann <nicoha...@chromium.org>
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages