[heap] Fix more GC unsafe casts [v8/v8 : main]

0 views
Skip to first unread message

Omer Katz (Gerrit)

unread,
4:32 AM (7 hours ago) 4:32 AM
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz

Omer Katz added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6bb2fc0061fbad4a0485bb72f0ef4df01fab1b94
Gerrit-Change-Number: 6988307
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 08:32:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
5:49 AM (6 hours ago) 5:49 AM
to Omer Katz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Omer Katz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6bb2fc0061fbad4a0485bb72f0ef4df01fab1b94
Gerrit-Change-Number: 6988307
Gerrit-PatchSet: 2
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Omer Katz <omer...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 09:49:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Omer Katz (Gerrit)

unread,
5:50 AM (6 hours ago) 5:50 AM
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com

Omer Katz voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6bb2fc0061fbad4a0485bb72f0ef4df01fab1b94
Gerrit-Change-Number: 6988307
Gerrit-PatchSet: 2
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 09:50:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
5:52 AM (6 hours ago) 5:52 AM
to Omer Katz, Michael Lippautz, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[heap] Fix more GC unsafe casts

Two more casts during dirty JSFinalizationRegistry processing that
weren't accounting for potentially pinned objects during Scavneger.
Bug: 447307176, 340777103, 447499415
Change-Id: I6bb2fc0061fbad4a0485bb72f0ef4df01fab1b94
Commit-Queue: Omer Katz <omer...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102783}
Files:
  • M src/heap/heap-visitor.cc
Change size: S
Delta: 1 file changed, 11 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6bb2fc0061fbad4a0485bb72f0ef4df01fab1b94
Gerrit-Change-Number: 6988307
Gerrit-PatchSet: 3
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages