Issue 7703 in v8: Compressed pointers in V8

[ish… via monorail]

Status: Assigned
Owner: ish...@chromium.org
Type: Bug

New issue 7703 by ish...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703

This is a tracking bug for implementing pointer compression in V8.

The design doc is here: https://docs.google.com/document/d/1TJTIYHNyG8KCCLQTu46VW3enRNtnC425eEobUp0eUQA/

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[ish… via monorail]

Updates:
Cc: sla...@chromium.org hpa...@chromium.org mlip...@chromium.org verwa...@chromium.org

Comment #1 on issue 7703 by ish...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c1

(No comment was entered for this change.)

[bugdro… via monorail]

Comment #2 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c2

The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/41e7e17338ac346152261ce68ea52ea4a9fe2bdd

commit 41e7e17338ac346152261ce68ea52ea4a9fe2bdd
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue May 15 14:59:16 2018

[heap-stats] Also collect object field stats.

In particular:
* number of pointer fields
* number embedder fields
* number boxed fields
* number of unboxed double field
* number of raw data fields

Bug: v8:7703
Change-Id: I22a310d941317a0f34f67536e55fbfab5f5354cd
Reviewed-on: https://chromium-review.googlesource.com/1056532
Reviewed-by: Camillo Bruni <cbr...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53188}
[modify] https://crrev.com/41e7e17338ac346152261ce68ea52ea4a9fe2bdd/src/heap/object-stats.cc
[modify] https://crrev.com/41e7e17338ac346152261ce68ea52ea4a9fe2bdd/src/heap/object-stats.h
[modify] https://crrev.com/41e7e17338ac346152261ce68ea52ea4a9fe2bdd/tools/heap-stats/details-selection.html
[modify] https://crrev.com/41e7e17338ac346152261ce68ea52ea4a9fe2bdd/tools/heap-stats/details-selection.js
[modify] https://crrev.com/41e7e17338ac346152261ce68ea52ea4a9fe2bdd/tools/heap-stats/global-timeline.js
[modify] https://crrev.com/41e7e17338ac346152261ce68ea52ea4a9fe2bdd/tools/heap-stats/histogram-viewer.js
[modify] https://crrev.com/41e7e17338ac346152261ce68ea52ea4a9fe2bdd/tools/heap-stats/trace-file-reader.js

[bugdro… via monorail]

Comment #4 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c4

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/d2234d5a3d8dfa97437c9de5de535bc6ffbb2c6d

commit d2234d5a3d8dfa97437c9de5de535bc6ffbb2c6d
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed May 23 12:10:22 2018

[heap-stats] Compute average percentage of ptr compression memory savings.

Bug: v8:7703
Change-Id: Icdeb42690f5a4db1318b51e234405d99275dabb7
Reviewed-on: https://chromium-review.googlesource.com/1068917
Reviewed-by: Camillo Bruni <cbr...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53300}
[modify] https://crrev.com/d2234d5a3d8dfa97437c9de5de535bc6ffbb2c6d/tools/heap-stats/global-timeline.js

[bugdro… via monorail]

Comment #5 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c5

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/7a45af140e9035c0b2c6fc37d7782267396d78fd

commit 7a45af140e9035c0b2c6fc37d7782267396d78fd
Author: Igor Sheludko <ish...@chromium.org>
Date: Mon May 28 14:27:27 2018

[ptr-compr] Unify SmiTag/SmiUntag operations in hand-written assembly code.

The result of SmiUntag is a sign-extended word-size value.

Bug: v8:7703
Change-Id: I85dc87b541cab78286e47e2147c16c6a0939f509
Reviewed-on: https://chromium-review.googlesource.com/1073232
Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53389}
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/arm64/macro-assembler-arm64-inl.h
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/compiler/x64/code-generator-x64.cc
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/src/x64/macro-assembler-x64.h
[modify] https://crrev.com/7a45af140e9035c0b2c6fc37d7782267396d78fd/test/cctest/test-macro-assembler-x64.cc

[bugdro… via monorail]

Comment #6 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c6

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/d123f30b6df5507b2acda8e85ad63e05de8ca8a7

commit d123f30b6df5507b2acda8e85ad63e05de8ca8a7
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Jun 05 11:37:35 2018

[ptr-compr] Support 31-bit Smis in lower half-word on 64-bit architectures.

This CL introduces a new gn argument: v8_enable_pointer_compression which is
false by default. All the changes done in this CL are made under this flag.

Upper half-word of a Smi word must be properly sign-extended according to the
sign of the lower-half containing the actual Smi value.

Bug: v8:7703
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I2b52ab49cd18c7c613130705de445fef44c30ac5
Reviewed-on: https://chromium-review.googlesource.com/1061175
Reviewed-by: Yang Guo <yan...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Reviewed-by: Ben Titzer <tit...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53519}
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/BUILD.gn
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/include/v8.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/arm64/assembler-arm64-inl.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/arm64/macro-assembler-arm64-inl.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/arm64/simulator-arm64.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/code-stub-assembler.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/code-stub-assembler.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/compiler/code-assembler.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/compiler/effect-control-linearizer.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/compiler/wasm-compiler.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/globals.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/layout-descriptor-inl.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/layout-descriptor.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/layout-descriptor.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/mips64/macro-assembler-mips64.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/string-search.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/arm/liftoff-assembler-arm.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/arm64/liftoff-assembler-arm64.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/ia32/liftoff-assembler-ia32.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/liftoff-assembler.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/liftoff-compiler.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/mips/liftoff-assembler-mips.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/mips64/liftoff-assembler-mips64.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/ppc/liftoff-assembler-ppc.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/s390/liftoff-assembler-s390.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/wasm/baseline/x64/liftoff-assembler-x64.h
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/test/cctest/test-log-stack-tracer.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/test/cctest/test-macro-assembler-x64.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/test/cctest/test-unboxed-doubles.cc
[modify] https://crrev.com/d123f30b6df5507b2acda8e85ad63e05de8ca8a7/test/cctest/trace-extension.cc

[bugdro… via monorail]

Comment #7 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c7

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/9c07c61c92f6a111b4cd169d81ea86de2bcdb865

commit 9c07c61c92f6a111b4cd169d81ea86de2bcdb865
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Jun 06 08:19:47 2018

[turbofan] Support CallDescriptor::kFixedTargetRegister for [tail]calls to code objects.

In order to port CompileLazy and DeserializeLazy builtins to CSA we need to
support this mode to be able to tail call to compiled or deserialized JS code
object.

Bug: v8:5269, v8:7703
Change-Id: I6abdc989af16774f6454b2ea0a97b1ce5ece5125
Reviewed-on: https://chromium-review.googlesource.com/1087452
Reviewed-by: Michael Starzinger <mstar...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53543}
[modify] https://crrev.com/9c07c61c92f6a111b4cd169d81ea86de2bcdb865/src/compiler/arm/code-generator-arm.cc
[modify] https://crrev.com/9c07c61c92f6a111b4cd169d81ea86de2bcdb865/src/compiler/arm64/code-generator-arm64.cc
[modify] https://crrev.com/9c07c61c92f6a111b4cd169d81ea86de2bcdb865/src/compiler/ia32/code-generator-ia32.cc
[modify] https://crrev.com/9c07c61c92f6a111b4cd169d81ea86de2bcdb865/src/compiler/mips/code-generator-mips.cc
[modify] https://crrev.com/9c07c61c92f6a111b4cd169d81ea86de2bcdb865/src/compiler/mips64/code-generator-mips64.cc
[modify] https://crrev.com/9c07c61c92f6a111b4cd169d81ea86de2bcdb865/src/compiler/ppc/code-generator-ppc.cc
[modify] https://crrev.com/9c07c61c92f6a111b4cd169d81ea86de2bcdb865/src/compiler/s390/code-generator-s390.cc
[modify] https://crrev.com/9c07c61c92f6a111b4cd169d81ea86de2bcdb865/src/compiler/x64/code-generator-x64.cc

[bugdro… via monorail]

Comment #8 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c8

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/afd6351dcd742ffa005dce8c15231b0ad7cb3b60

commit afd6351dcd742ffa005dce8c15231b0ad7cb3b60
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Jun 07 18:21:55 2018

[csa][builtins] Port CompileLazy* to CSA.

This CL introduces CSA::TailCallJSCode() for tail calling code objects
with JSCall linkage.

Bug: v8:5269, v8:7703

Change-Id: I97370dc4355dc658a9cd62166efcbe7f03d6daca
Reviewed-on: https://chromium-review.googlesource.com/1087459
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Michael Starzinger <mstar...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53590}
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/BUILD.gn
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/arm/interface-descriptors-arm.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/arm64/interface-descriptors-arm64.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/builtins-definitions.h
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/builtins-internal-gen.cc
[add] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/builtins-lazy-gen.cc
[add] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/builtins-lazy-gen.h
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/code-stub-assembler.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/code-stub-assembler.h
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/compiler/code-assembler.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/compiler/code-assembler.h
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/ia32/interface-descriptors-ia32.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/interface-descriptors.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/interface-descriptors.h
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/mips/interface-descriptors-mips.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/mips64/interface-descriptors-mips64.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/objects-printer.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/ppc/interface-descriptors-ppc.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/s390/interface-descriptors-s390.cc
[modify] https://crrev.com/afd6351dcd742ffa005dce8c15231b0ad7cb3b60/src/x64/interface-descriptors-x64.cc

[bugdro… via monorail]

Comment #9 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c9

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/d9daf859742d90e19aaf70b504aaf28350c6a62e

commit d9daf859742d90e19aaf70b504aaf28350c6a62e
Author: Igor Sheludko <ish...@chromium.org>
Date: Fri Jun 08 09:55:00 2018

[csa][builtins] Port DeserializeLazy to CSA.

Bug: v8:5269, v8:7703

Change-Id: I0b766ab4ca55edc05d1849745fd3604be6c726d6
Reviewed-on: https://chromium-review.googlesource.com/1087460
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53607}
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/builtins-definitions.h
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/builtins-lazy-gen.cc
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/d9daf859742d90e19aaf70b504aaf28350c6a62e/src/builtins/x64/builtins-x64.cc

[bugdro… via monorail]

Comment #10 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c10

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/fb450de77032542b975d03bb5fd4ce001ace9a6a

commit fb450de77032542b975d03bb5fd4ce001ace9a6a
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Jun 12 15:09:16 2018

[builtins] Cleanup Array[No,Single,N]ArgumentsConstructorDescriptor.

This is a necessary cleanup before porting Array[No,Single,N]ArgumentsConstructor
builtins to CSA.

Bug: v8:5269, v8:7703

Change-Id: I40a2dd83faab1f8c3c180d461ef62fa4d8578f5e
Reviewed-on: https://chromium-review.googlesource.com/1097079

Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#53671}
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/arm/interface-descriptors-arm.cc
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/arm64/interface-descriptors-arm64.cc
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/ia32/interface-descriptors-ia32.cc
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/interface-descriptors.cc
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/interface-descriptors.h
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/mips/interface-descriptors-mips.cc
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/mips64/interface-descriptors-mips64.cc
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/ppc/interface-descriptors-ppc.cc
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/s390/interface-descriptors-s390.cc
[modify] https://crrev.com/fb450de77032542b975d03bb5fd4ce001ace9a6a/src/x64/interface-descriptors-x64.cc

[w… via monorail]

Comment #11 on issue 7703 by w...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c11

The design doc in #0 is not accessible.

[bugdro… via monorail]

Comment #12 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c12

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968

commit 7ebbda48bbda2de11b5b339e7f1a4a03aaad7968
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Jun 13 09:07:18 2018

[csa][builtins] Port ArrayNArgumentsConstructor builtin to CSA.

Bug: v8:5269, v8:7703

Change-Id: Ib9934e1c3685f731ba588f12e253fce24c03b151
Reviewed-on: https://chromium-review.googlesource.com/1097485
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53688}
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/builtins-array-gen.h
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/builtins-definitions.h
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/code-stub-assembler.cc
[modify] https://crrev.com/7ebbda48bbda2de11b5b339e7f1a4a03aaad7968/src/code-stub-assembler.h

[bugdro… via monorail]

Comment #13 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c13

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/7745c73a824417436f3869449c688a7a2d2e98fe

commit 7745c73a824417436f3869449c688a7a2d2e98fe
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Jun 13 10:33:58 2018

[csa][builtin] Port ArrayConstructor builtin to CSA.

Bug: v8:5269, v8:7703

Change-Id: If80923b767b6bf3533b4d53039b1b5125c670cf1
Reviewed-on: https://chromium-review.googlesource.com/1097486

Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#53693}
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/builtins-definitions.h
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/7745c73a824417436f3869449c688a7a2d2e98fe/src/builtins/x64/builtins-x64.cc

[bugdro… via monorail]

Comment #14 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c14

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/7664dc27c36a81aa864dfa3c308d8e718dbcc61d

commit 7664dc27c36a81aa864dfa3c308d8e718dbcc61d
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Jun 14 15:59:33 2018

[csa][builtins] Port ArrayConstructorImpl builtin to CSA.

Bug: v8:5269, v8:7703

Change-Id: I3e1f8a7892192a06ce6a71563cc16a47c51f9d89
Reviewed-on: https://chromium-review.googlesource.com/1097487

Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#53740}
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/builtins-array-gen.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/builtins-array-gen.h
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/builtins-constructor-gen.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/builtins-constructor-gen.h
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/builtins-definitions.h
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/code-stub-assembler.cc
[modify] https://crrev.com/7664dc27c36a81aa864dfa3c308d8e718dbcc61d/src/code-stub-assembler.h

[ish… via monorail]

Comment #15 on issue 7703 by ish...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c15

This is a tracking bug for implementing pointer compression in V8.

The design doc is here: https://docs.google.com/document/d/10qh2-b4C5OtSg-xLwyZpEI5ZihVBPtn1xwKBbQC26yI/

[ish… via monorail]

Comment #16 on issue 7703 by ish...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c16

The link to design doc was updated.

[bugdro… via monorail]

Comment #17 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c17

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/bf1e47e6ff10734045b2d6a501da49d20980f742

commit bf1e47e6ff10734045b2d6a501da49d20980f742
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Aug 21 13:06:31 2018

[ptr-compr] Switch Smis to 31-bit on 64-bit platforms.

This is prerequisite for V8 heap pointer compression.

Bug: v8:7703
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng

Change-Id: I2cdf02bd4cd535beb78a5db5b7cbdf67433a6d16
Reviewed-on: https://chromium-review.googlesource.com/1181136
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55269}
[modify] https://crrev.com/bf1e47e6ff10734045b2d6a501da49d20980f742/include/v8.h

[bugdro… via monorail]

Comment #18 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c18

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/628d846da9242973fdfcdca117156c3bf1f468e9

commit 628d846da9242973fdfcdca117156c3bf1f468e9
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Aug 23 09:17:55 2018

Revert "[ptr-compr] Switch Smis to 31-bit on 64-bit platforms."

This reverts commit bf1e47e6ff10734045b2d6a501da49d20980f742.

Reason for revert: chromium:876631

Original change's description:

> [ptr-compr] Switch Smis to 31-bit on 64-bit platforms.
>
> This is prerequisite for V8 heap pointer compression.
>
> Bug: v8:7703
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: I2cdf02bd4cd535beb78a5db5b7cbdf67433a6d16
> Reviewed-on: https://chromium-review.googlesource.com/1181136
> Commit-Queue: Igor Sheludko <ish...@chromium.org>
> Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55269}

TBR=ul...@chromium.org,ish...@chromium.org,verw...@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7703
Change-Id: I6d8662a6ff0b352e4975d31330d63a705ed55cd5
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1186341
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55333}
[modify] https://crrev.com/628d846da9242973fdfcdca117156c3bf1f468e9/include/v8.h

[bugdro… via monorail]

Comment #19 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c19

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/57c8c85b9f06d4be03ce3c12d1b286b8f2245030

commit 57c8c85b9f06d4be03ce3c12d1b286b8f2245030
Author: Igor Sheludko <ish...@chromium.org>
Date: Fri Aug 24 09:17:36 2018

[ptr-compr] Fix assert in LayoutDescriptor which failed with 31-bit Smis.

Bug: v8:7703, chromium:876696
Change-Id: Ida3243414215b2ef75a9875ca31cf5a68274f7e0
Reviewed-on: https://chromium-review.googlesource.com/1185186
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55383}
[modify] https://crrev.com/57c8c85b9f06d4be03ce3c12d1b286b8f2245030/src/layout-descriptor.cc

[bugdro… via monorail]

Comment #21 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c21

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/0aac3884c9e02b34861d526d2d5c62f8628483f3

commit 0aac3884c9e02b34861d526d2d5c62f8628483f3
Author: Benedikt Meurer <bme...@chromium.org>
Date: Thu Aug 30 11:40:27 2018

[turbofan] Be more consistent about Smi comparisons.

This changes SimplifiedLowering to be more consistent when chosing Smi
representation as input for Number comparisons. We already had some
isolated logic for doing (speculative) Number comparisons on Smis, but
only in the case where that decision was based on type feedback, not on
information already present in the graph.

Bug: v8:7703
Change-Id: I25370ade630917675a6ac79b5ae6a8afd253dfc7
Reviewed-on: https://chromium-review.googlesource.com/1196422
Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Commit-Queue: Benedikt Meurer <bme...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55518}
[modify] https://crrev.com/0aac3884c9e02b34861d526d2d5c62f8628483f3/src/compiler/representation-change.cc
[modify] https://crrev.com/0aac3884c9e02b34861d526d2d5c62f8628483f3/src/compiler/simplified-lowering.cc

[bugdro… via monorail]

Comment #22 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c22

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/77abc64d24aa7f3f3f650a3624b7df73b81213a6

commit 77abc64d24aa7f3f3f650a3624b7df73b81213a6
Author: Benedikt Meurer <bme...@chromium.org>
Date: Fri Sep 07 11:50:21 2018

Revert "[turbofan] Be more consistent about Smi comparisons."

This reverts commit 0aac3884c9e02b34861d526d2d5c62f8628483f3.

Reason for revert: Various performance regressions (Blink and JSTests).

Original change's description:

> [turbofan] Be more consistent about Smi comparisons.
>
> This changes SimplifiedLowering to be more consistent when chosing Smi
> representation as input for Number comparisons. We already had some
> isolated logic for doing (speculative) Number comparisons on Smis, but
> only in the case where that decision was based on type feedback, not on
> information already present in the graph.
>
> Bug: v8:7703
> Change-Id: I25370ade630917675a6ac79b5ae6a8afd253dfc7
> Reviewed-on: https://chromium-review.googlesource.com/1196422
> Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
> Commit-Queue: Benedikt Meurer <bme...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55518}

TBR=ja...@chromium.org,bme...@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7703, chromium:881758, chromium:881759, chromium:881760
Change-Id: I4af9c0b0ad37dea17ceabeb721c92a7cc978987a
Reviewed-on: https://chromium-review.googlesource.com/1213185
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Commit-Queue: Benedikt Meurer <bme...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55720}
[modify] https://crrev.com/77abc64d24aa7f3f3f650a3624b7df73b81213a6/src/compiler/representation-change.cc
[modify] https://crrev.com/77abc64d24aa7f3f3f650a3624b7df73b81213a6/src/compiler/simplified-lowering.cc

[lloz… via monorail]

Updates:
Cc: llo...@chromium.org manoj...@chromium.org g...@chromium.org

Comment #25 on issue 7703 by llo...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c25

(No comment was entered for this change.)

[bugdro… via monorail]

Comment #27 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c27

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/b8e8b0de4f89bcddf3c621f41bec266acf56dab1

commit b8e8b0de4f89bcddf3c621f41bec266acf56dab1
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Nov 06 14:21:44 2018

[ptr-compr] Fix incorrectly used machine types

in TurboFan, CSA, Wasm and compiler tests. Tagged values decompression
logic will depend on the machine type of the value being loaded so it must
be correct.

Bug: v8:7703
Change-Id: Ia9e7cc1e273e5a458d9de8aaa4adb0c970413b8b
Reviewed-on: https://chromium-review.googlesource.com/c/1319573
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Michael Starzinger <mstar...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57280}
[modify] https://crrev.com/b8e8b0de4f89bcddf3c621f41bec266acf56dab1/src/builtins/builtins-constructor-gen.cc
[modify] https://crrev.com/b8e8b0de4f89bcddf3c621f41bec266acf56dab1/src/code-stub-assembler.h
[modify] https://crrev.com/b8e8b0de4f89bcddf3c621f41bec266acf56dab1/src/compiler/effect-control-linearizer.cc
[modify] https://crrev.com/b8e8b0de4f89bcddf3c621f41bec266acf56dab1/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/b8e8b0de4f89bcddf3c621f41bec266acf56dab1/src/ic/accessor-assembler.cc
[modify] https://crrev.com/b8e8b0de4f89bcddf3c621f41bec266acf56dab1/src/machine-type.h
[modify] https://crrev.com/b8e8b0de4f89bcddf3c621f41bec266acf56dab1/test/cctest/compiler/test-run-load-store.cc

[bugdro… via monorail]

Comment #28 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c28

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/045756f32b5d45def4afa5e3338eb68f03bdd32d

commit 045756f32b5d45def4afa5e3338eb68f03bdd32d
Author: Michael Achenbach <mache...@chromium.org>
Date: Tue Nov 06 18:10:54 2018

Revert "[ptr-compr] Fix incorrectly used machine types"

This reverts commit b8e8b0de4f89bcddf3c621f41bec266acf56dab1.

Reason for revert:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm%20-%20debug/8276

Original change's description:

> [ptr-compr] Fix incorrectly used machine types
>
> in TurboFan, CSA, Wasm and compiler tests. Tagged values decompression
> logic will depend on the machine type of the value being loaded so it must
> be correct.
>
> Bug: v8:7703
> Change-Id: Ia9e7cc1e273e5a458d9de8aaa4adb0c970413b8b
> Reviewed-on: https://chromium-review.googlesource.com/c/1319573
> Commit-Queue: Igor Sheludko <ish...@chromium.org>
> Reviewed-by: Michael Starzinger <mstar...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#57280}

TBR=mstar...@chromium.org,ish...@chromium.org

Change-Id: Ia97d5bfebf8d8fe1b2b7607f63024b60cf2c584f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7703
Reviewed-on: https://chromium-review.googlesource.com/c/1320349
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57294}
[modify] https://crrev.com/045756f32b5d45def4afa5e3338eb68f03bdd32d/src/builtins/builtins-constructor-gen.cc
[modify] https://crrev.com/045756f32b5d45def4afa5e3338eb68f03bdd32d/src/code-stub-assembler.h
[modify] https://crrev.com/045756f32b5d45def4afa5e3338eb68f03bdd32d/src/compiler/effect-control-linearizer.cc
[modify] https://crrev.com/045756f32b5d45def4afa5e3338eb68f03bdd32d/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/045756f32b5d45def4afa5e3338eb68f03bdd32d/src/ic/accessor-assembler.cc
[modify] https://crrev.com/045756f32b5d45def4afa5e3338eb68f03bdd32d/src/machine-type.h
[modify] https://crrev.com/045756f32b5d45def4afa5e3338eb68f03bdd32d/test/cctest/compiler/test-run-load-store.cc

[bugdro… via monorail]

Comment #29 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c29

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/6b7bd995740f7cafa2ea6c446eb5a54a9548d376

commit 6b7bd995740f7cafa2ea6c446eb5a54a9548d376
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Nov 07 11:29:32 2018

Reland "[ptr-compr] Fix incorrectly used machine types"

This is a reland of b8e8b0de4f89bcddf3c621f41bec266acf56dab1

Original change's description:
> [ptr-compr] Fix incorrectly used machine types
>
> in TurboFan, CSA, Wasm and compiler tests. Tagged values decompression
> logic will depend on the machine type of the value being loaded so it must
> be correct.
>
> Bug: v8:7703
> Change-Id: Ia9e7cc1e273e5a458d9de8aaa4adb0c970413b8b
> Reviewed-on: https://chromium-review.googlesource.com/c/1319573
> Commit-Queue: Igor Sheludko <ish...@chromium.org>
> Reviewed-by: Michael Starzinger <mstar...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#57280}

Bug: v8:7703
Change-Id: I2c740bab9a800520ebfb83334345bd5641b7e408
Reviewed-on: https://chromium-review.googlesource.com/c/1320850
Reviewed-by: Michael Starzinger <mstar...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57314}
[modify] https://crrev.com/6b7bd995740f7cafa2ea6c446eb5a54a9548d376/src/builtins/builtins-constructor-gen.cc
[modify] https://crrev.com/6b7bd995740f7cafa2ea6c446eb5a54a9548d376/src/code-stub-assembler.h
[modify] https://crrev.com/6b7bd995740f7cafa2ea6c446eb5a54a9548d376/src/compiler/effect-control-linearizer.cc
[modify] https://crrev.com/6b7bd995740f7cafa2ea6c446eb5a54a9548d376/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/6b7bd995740f7cafa2ea6c446eb5a54a9548d376/src/ic/accessor-assembler.cc
[modify] https://crrev.com/6b7bd995740f7cafa2ea6c446eb5a54a9548d376/src/machine-type.h
[modify] https://crrev.com/6b7bd995740f7cafa2ea6c446eb5a54a9548d376/test/cctest/compiler/test-run-load-store.cc

[bugdro… via monorail]

Comment #30 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c30

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/4001f86afa62143dab1e9b8a125d0bdabb6155f5

commit 4001f86afa62143dab1e9b8a125d0bdabb6155f5
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Nov 07 13:28:43 2018

[ptr-compr] Make cleared weak reference value pointer compression friendly

because otherwise cleared weak references require special treatment during
decompression.

Bug: v8:7703
Change-Id: I38761d656c606e7ba7fc3075dffbd855a9f72302
Reviewed-on: https://chromium-review.googlesource.com/c/1322909
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Marja Hölttä <ma...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57315}
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/arm/macro-assembler-arm.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/code-stub-assembler.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/feedback-vector.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/globals.h
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/heap/mark-compact.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/heap/spaces.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/ia32/macro-assembler-ia32.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/ic/accessor-assembler.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/mips64/macro-assembler-mips64.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/objects.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/objects/fixed-array.h
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/objects/maybe-object-inl.h
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/objects/maybe-object.h
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/ppc/macro-assembler-ppc.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/s390/macro-assembler-s390.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/4001f86afa62143dab1e9b8a125d0bdabb6155f5/test/cctest/heap/test-weak-references.cc

[lloz… via monorail]

Updates:
Cc: sirish.p...@samsung.com

Comment #31 on issue 7703 by llo...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c31

(No comment was entered for this change.)

[bugdro… via monorail]

Comment #32 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c32

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/6d692dbb2d01b63b011ec461accae2c6629af62c

commit 6d692dbb2d01b63b011ec461accae2c6629af62c
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Nov 08 13:50:20 2018

[ptr-compr][x64] Implement decompression snippets for x64

Currently, in debug mode the snippets check the result of decompression equals
to the full value stored in the field.

Bug: v8:7703
Change-Id: I0caa7fdaa7d346612084706ed96a4330fcb0c236
Reviewed-on: https://chromium-review.googlesource.com/c/1319575
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57354}
[modify] https://crrev.com/6d692dbb2d01b63b011ec461accae2c6629af62c/src/compiler/x64/code-generator-x64.cc
[modify] https://crrev.com/6d692dbb2d01b63b011ec461accae2c6629af62c/src/compiler/x64/instruction-codes-x64.h
[modify] https://crrev.com/6d692dbb2d01b63b011ec461accae2c6629af62c/src/compiler/x64/instruction-scheduler-x64.cc
[modify] https://crrev.com/6d692dbb2d01b63b011ec461accae2c6629af62c/src/compiler/x64/instruction-selector-x64.cc
[modify] https://crrev.com/6d692dbb2d01b63b011ec461accae2c6629af62c/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/6d692dbb2d01b63b011ec461accae2c6629af62c/src/x64/macro-assembler-x64.h

[bugdro… via monorail]

Comment #33 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c33

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/98de0a63dfbb3c3caa091b2d15bcd14853939aa5

commit 98de0a63dfbb3c3caa091b2d15bcd14853939aa5
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Nov 14 16:08:32 2018

[serializer][ptr-compr] Add byte code for cleared weak reference

in order to be able to properly deserialize the latter in case of enabled
pointer compression where the cleared weak reference value is Isolate-dependent.

Bug: v8:7703
Change-Id: Ied995bc15317c83fcc03cf27de3fbf135659a9d5
Reviewed-on: https://chromium-review.googlesource.com/c/1333676
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Yang Guo <yan...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57510}
[modify] https://crrev.com/98de0a63dfbb3c3caa091b2d15bcd14853939aa5/src/snapshot/deserializer.cc
[modify] https://crrev.com/98de0a63dfbb3c3caa091b2d15bcd14853939aa5/src/snapshot/serializer-common.h
[modify] https://crrev.com/98de0a63dfbb3c3caa091b2d15bcd14853939aa5/src/snapshot/serializer.cc

[jgru… via monorail]

Updates:
Cc: jgr...@chromium.org

Comment #34 on issue 7703 by jgr...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c34

(No comment was entered for this change.)

[bugdro… via monorail]

Comment #36 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c36

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/b5e9b8296257bec601dff4ae769dab01e55aa56c

commit b5e9b8296257bec601dff4ae769dab01e55aa56c
Author: Igor Sheludko <ish...@chromium.org>
Date: Mon Nov 19 17:02:30 2018

[ptr-compr] Add a header for pointer compression related code

Bug: v8:7703
Change-Id: I96fd746291aa2e1386ed40068d38f5140bb1e44f
Reviewed-on: https://chromium-review.googlesource.com/c/1342031
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57612}
[modify] https://crrev.com/b5e9b8296257bec601dff4ae769dab01e55aa56c/BUILD.gn
[modify] https://crrev.com/b5e9b8296257bec601dff4ae769dab01e55aa56c/src/isolate-allocator.cc
[modify] https://crrev.com/b5e9b8296257bec601dff4ae769dab01e55aa56c/src/isolate.cc
[add] https://crrev.com/b5e9b8296257bec601dff4ae769dab01e55aa56c/src/ptr-compr.h

[bugdro… via monorail]

Comment #37 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c37

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/d469fec064da93b4ba3753bbdb4e8f4fd1691a73

commit d469fec064da93b4ba3753bbdb4e8f4fd1691a73
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Nov 20 11:51:15 2018

[ptr-compr] Introduce EmbedderDataArray

for storing embedder data in native context. We can't use FixedArray because
with enabled pointer compression it would not be possible to fit raw aligned
pointer into 32-bits of a tagged value so we will need to store both tagged
and raw data in this array and therefore custom visitor is required.

Bug: v8:7703
Change-Id: Iae23d9aa76c79a572d5f0f1f3c0f924e8e407dd0
Reviewed-on: https://chromium-review.googlesource.com/c/1340295
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57639}
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/BUILD.gn
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/include/v8-internal.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/api.cc
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/bootstrapper.cc
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/compiler/types.cc
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/contexts.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/heap/factory.cc
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/heap/factory.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/heap/objects-visiting.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects-debug.cc
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects-definitions.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects-inl.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects-printer.cc
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects.cc
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects.h
[add] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects/embedder-data-array-inl.h
[add] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects/embedder-data-array.cc
[add] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects/embedder-data-array.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects/js-objects-inl.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects/js-objects.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/objects/map.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/roots.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/src/utils.h
[modify] https://crrev.com/d469fec064da93b4ba3753bbdb4e8f4fd1691a73/tools/v8heapconst.py

[bugdro… via monorail]

Comment #38 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c38

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/9bcb5eb590643db0c1f688fea316c7f1f4786a3c

commit 9bcb5eb590643db0c1f688fea316c7f1f4786a3c
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Nov 21 10:44:57 2018

[ptr-compr][cleanup] Refactor XxxSlot implementations

and prepare for adding an EmbedderDataSlot which will occupy two tagged slots.

Bug: v8:8477, v8:8238, v8:7703
Change-Id: I8aa0a0c9b64835ad7f847033bcc55dd3b3c43563
Reviewed-on: https://chromium-review.googlesource.com/c/1344153

Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#57669}
[modify] https://crrev.com/9bcb5eb590643db0c1f688fea316c7f1f4786a3c/src/base/macros.h
[modify] https://crrev.com/9bcb5eb590643db0c1f688fea316c7f1f4786a3c/src/objects/slots-atomic-inl.h
[modify] https://crrev.com/9bcb5eb590643db0c1f688fea316c7f1f4786a3c/src/objects/slots.h

[bugdro… via monorail]

Comment #39 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c39

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7

commit ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Nov 21 12:30:13 2018

[ptr-compr] Introduce EmbedderDataSlot

an abstraction that hides the details about how embedder data fields are
encoded in EmbedderDataArrays and JSObjects.

Bug: v8:7703
Change-Id: Ic9f6d9511bec557c6671aa6488b9545e353f968c
Reviewed-on: https://chromium-review.googlesource.com/c/1344155
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57679}
[modify] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/BUILD.gn
[modify] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/include/v8-internal.h
[modify] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/include/v8.h
[modify] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/src/api.cc
[modify] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/src/objects-debug.cc
[modify] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/src/objects-printer.cc
[modify] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/src/objects/embedder-data-array-inl.h
[modify] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/src/objects/embedder-data-array.h
[add] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/src/objects/embedder-data-slot-inl.h
[add] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/src/objects/embedder-data-slot.h
[modify] https://crrev.com/ea9f847d36a60036e1eff2bdf610b35a9ab2a1a7/test/cctest/test-api.cc

[bugdro… via monorail]

Comment #40 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c40

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/21c415735c74e47942987aa033bbf66bb2ee0aa7

commit 21c415735c74e47942987aa033bbf66bb2ee0aa7
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Nov 21 16:11:03 2018

[ptr-compr] Use EmbedderDataSlot for accessing embedder fields in JSObjects

and make the slot occupy two tagged words when pointer compression is enabled.

Tbr: bme...@chromium.org
Bug: v8:7703
Change-Id: Idcd3385cc7d5299d9bdaf6a69c7bd0591099f0bb
Reviewed-on: https://chromium-review.googlesource.com/c/1346489
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Yang Guo <yan...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57693}
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/include/v8-internal.h
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/api-natives.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/api.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/builtins/builtins-microtask-queue-gen.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/builtins/builtins-promise-gen.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/builtins/builtins-typed-array-gen.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/compiler/js-create-lowering.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/global-handles.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/globals.h
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/heap/heap.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/objects-printer.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/objects.cc
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/objects/embedder-data-array.h
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/objects/embedder-data-slot.h
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/objects/js-array-buffer.h
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/objects/js-objects-inl.h
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/objects/js-objects.h
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/objects/js-promise.h
[modify] https://crrev.com/21c415735c74e47942987aa033bbf66bb2ee0aa7/src/snapshot/partial-serializer.cc

[bugdro… via monorail]

Comment #41 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c41

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/d8f2878f323f206c306efdde3eacc1147291a729

commit d8f2878f323f206c306efdde3eacc1147291a729
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Nov 22 15:29:30 2018

[cleanup] Cleanup the way we visit NativeContext

this will allow to add raw fields to the native context in a pointer compression
friendly way.

This CL also adds a microtask_queue field to native context which will be used
in a follow-up CL.

Bug: v8:8238, v8:7703
Change-Id: I5ecf72dbc52e8261b694551cbc8476f967967723
Reviewed-on: https://chromium-review.googlesource.com/c/1348073

Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#57744}
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/include/v8-internal.h
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/contexts-inl.h
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/contexts.cc
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/contexts.h
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/heap/factory.cc
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/heap/objects-visiting.h
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/objects-debug.cc
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/objects-inl.h
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/objects-printer.cc
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/objects.cc
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/src/objects.h
[modify] https://crrev.com/d8f2878f323f206c306efdde3eacc1147291a729/tools/gen-postmortem-metadata.py

[bugdro… via monorail]

Comment #42 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c42

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/f3fd0b3c31a87937f6a792d8687468e096fb8e18

commit f3fd0b3c31a87937f6a792d8687468e096fb8e18
Author: Igor Sheludko <ish...@chromium.org>
Date: Fri Nov 23 12:43:30 2018

[ptr-compr] Make Code serialization pointer compression friendly

Bug: v8:7703
Change-Id: I47e6971bc99186cb6861164ec2a246ebcd770219
Reviewed-on: https://chromium-review.googlesource.com/c/1349230

Reviewed-by: Yang Guo <yan...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#57780}
[modify] https://crrev.com/f3fd0b3c31a87937f6a792d8687468e096fb8e18/src/objects/code-inl.h
[modify] https://crrev.com/f3fd0b3c31a87937f6a792d8687468e096fb8e18/src/objects/fixed-array-inl.h
[modify] https://crrev.com/f3fd0b3c31a87937f6a792d8687468e096fb8e18/src/objects/fixed-array.h
[modify] https://crrev.com/f3fd0b3c31a87937f6a792d8687468e096fb8e18/src/reloc-info.cc
[modify] https://crrev.com/f3fd0b3c31a87937f6a792d8687468e096fb8e18/src/reloc-info.h
[modify] https://crrev.com/f3fd0b3c31a87937f6a792d8687468e096fb8e18/src/snapshot/serializer.cc

[bugdro… via monorail]

Comment #43 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c43

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/3649dc187d314bcdc58c71bd86326526d3aa203b

commit 3649dc187d314bcdc58c71bd86326526d3aa203b
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Nov 27 16:06:46 2018

[ptr-compr] Use [Maybe]ObjectSlots as bottlenecks for accessing tagged fields

This CL introduces Tagged_t and AtomicTagged_t typedefs which represent
the storage type of tagged values in V8 heap.

Bug: v8:7703
Change-Id: Ib57e85ea073eaf896b6406cf0f62adcef9a114ce
Reviewed-on: https://chromium-review.googlesource.com/c/1352294
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57878}
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/elements.cc
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/feedback-vector-inl.h
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/globals.h
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/objects-inl.h
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/objects.cc
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/objects/embedder-data-slot.h
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/objects/fixed-array-inl.h
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/objects/heap-object-inl.h
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/objects/object-macros.h
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/objects/slots-atomic-inl.h
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/objects/slots-inl.h
[modify] https://crrev.com/3649dc187d314bcdc58c71bd86326526d3aa203b/src/objects/slots.h

[bugdro… via monorail]

Comment #45 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c45

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/8ed4e17273cc4d46a767a8791294882e66a2810f

commit 8ed4e17273cc4d46a767a8791294882e66a2810f
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Dec 06 19:50:06 2018

[ptr-compr] Don't use Code::cast for off-heap code objects

because attempt to decompress the off-heap map slot will fail.

Bug: v8:7703
Change-Id: Iad3884fb95ccb17b2992d190acb5914062a0e8f4
Reviewed-on: https://chromium-review.googlesource.com/c/1365286
Reviewed-by: Yang Guo <yan...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58076}
[modify] https://crrev.com/8ed4e17273cc4d46a767a8791294882e66a2810f/src/snapshot/serializer.cc

[bugdro… via monorail]

Comment #46 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c46

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/bc078ce4fc4081b8b599440be962e521be442245

commit bc078ce4fc4081b8b599440be962e521be442245
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Dec 13 12:07:03 2018

[ptr-compr] Introduce CompressedXxxSlots

for accessing compressed on-heap slots with corresponding contents.

Bug: v8:7703
Change-Id: Icb314f02f4d5e8d70b997dec02ee9a9568af5d5d
Reviewed-on: https://chromium-review.googlesource.com/c/1370040
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58215}
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/BUILD.gn
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/globals.h
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/heap/slot-set.h
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/objects.h
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/objects/heap-object.h
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/objects/slots-inl.h
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/objects/slots.h
[add] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/ptr-compr-inl.h
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/ptr-compr.h
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/runtime/runtime-scopes.cc
[modify] https://crrev.com/bc078ce4fc4081b8b599440be962e521be442245/src/utils.h

[bugdro… via monorail]

Comment #47 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c47

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/42afba5195869efc37e5458a5ecf267102a7b614

commit 42afba5195869efc37e5458a5ecf267102a7b614
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Dec 19 10:34:28 2018

[ptr-compr][x64] Introduce bottlenecks for accessing on-heap tagged fields

and fix platform builtins.

This CL also introduces MacroAssembler::xxx_tagged() operations which
operate on potentially compressed tagged values without doing decompression.

This CL also drive-by fixes compilation failures when pointer compression is
enabled.

Bug: v8:7703
Change-Id: Id417f2a78907e8911aaa79ef404f5bcc87d9a3b8
Reviewed-on: https://chromium-review.googlesource.com/c/1382740
Reviewed-by: Sigurd Schneider <sig...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58352}
[modify] https://crrev.com/42afba5195869efc37e5458a5ecf267102a7b614/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/42afba5195869efc37e5458a5ecf267102a7b614/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/42afba5195869efc37e5458a5ecf267102a7b614/src/debug/x64/debug-x64.cc
[modify] https://crrev.com/42afba5195869efc37e5458a5ecf267102a7b614/src/objects/maybe-object-inl.h
[modify] https://crrev.com/42afba5195869efc37e5458a5ecf267102a7b614/src/ptr-compr-inl.h
[modify] https://crrev.com/42afba5195869efc37e5458a5ecf267102a7b614/src/ptr-compr.h
[modify] https://crrev.com/42afba5195869efc37e5458a5ecf267102a7b614/src/x64/assembler-x64.h
[modify] https://crrev.com/42afba5195869efc37e5458a5ecf267102a7b614/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/42afba5195869efc37e5458a5ecf267102a7b614/src/x64/macro-assembler-x64.h

[bugdro… via monorail]

Comment #48 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c48

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/2f5817fcd29302791d16d22bacaacc37d000db13

commit 2f5817fcd29302791d16d22bacaacc37d000db13
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Dec 19 11:32:35 2018

[ptr-compr][Liftoff] Add macro operations for loading tagged pointer fields

These load operations will decompress values if pointer compression is
enabled.

Bug: v8:7703
Change-Id: I4c5cef39a735f3b03e36d27c0e5e7c21653bbbc0
Reviewed-on: https://chromium-review.googlesource.com/c/1382742
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Clemens Hammacher <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58356}
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/arm/liftoff-assembler-arm.h
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/arm64/liftoff-assembler-arm64.h
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/ia32/liftoff-assembler-ia32.h
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/liftoff-assembler.h
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/liftoff-compiler.cc
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/mips/liftoff-assembler-mips.h
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/mips64/liftoff-assembler-mips64.h
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/ppc/liftoff-assembler-ppc.h
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/s390/liftoff-assembler-s390.h
[modify] https://crrev.com/2f5817fcd29302791d16d22bacaacc37d000db13/src/wasm/baseline/x64/liftoff-assembler-x64.h

[bugdro… via monorail]

Comment #49 on issue 7703 by bugd...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c49

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/90698aee1819ce81c75286b6a42c76a9bb35f121

commit 90698aee1819ce81c75286b6a42c76a9bb35f121
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Dec 27 11:07:24 2018

[ptr-compr] Support decompression in include/v8.h and include/v8-internal.h

Bug: v8:7703
Change-Id: I2cc5ceb7b70a9b53d5bcc90b32276c011f89ffbe
Reviewed-on: https://chromium-review.googlesource.com/c/1388530
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58476}
[modify] https://crrev.com/90698aee1819ce81c75286b6a42c76a9bb35f121/include/v8-internal.h
[modify] https://crrev.com/90698aee1819ce81c75286b6a42c76a9bb35f121/include/v8.h
[modify] https://crrev.com/90698aee1819ce81c75286b6a42c76a9bb35f121/src/api.cc
[modify] https://crrev.com/90698aee1819ce81c75286b6a42c76a9bb35f121/src/roots-inl.h

[bugdroid via monorail]

Comment #50 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c50

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/88f17ba666e9bdad19cbbd3ac1e3566be9d8b015

commit 88f17ba666e9bdad19cbbd3ac1e3566be9d8b015
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Jan 30 12:40:04 2019

[ptr-compr][arm64] Implement decompression snippets for Arm64

Currently, in debug mode the snippets check that the result of decompression

equals to the full value stored in the field.

Bug: v8:7703

Change-Id: I43d20f15510de57582ee00ca23d676dfd4d06636
Reviewed-on: https://chromium-review.googlesource.com/c/1440049
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59200}
[modify] https://crrev.com/88f17ba666e9bdad19cbbd3ac1e3566be9d8b015/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/88f17ba666e9bdad19cbbd3ac1e3566be9d8b015/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/88f17ba666e9bdad19cbbd3ac1e3566be9d8b015/src/compiler/backend/arm64/code-generator-arm64.cc
[modify] https://crrev.com/88f17ba666e9bdad19cbbd3ac1e3566be9d8b015/src/compiler/backend/arm64/instruction-codes-arm64.h
[modify] https://crrev.com/88f17ba666e9bdad19cbbd3ac1e3566be9d8b015/src/compiler/backend/arm64/instruction-scheduler-arm64.cc
[modify] https://crrev.com/88f17ba666e9bdad19cbbd3ac1e3566be9d8b015/src/compiler/backend/arm64/instruction-selector-arm64.cc

[sola… via monorail]

Updates:
Cc: sol...@chromium.org

Comment #53 on issue 7703 by sol...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c53

(No comment was entered for this change.)

[bugdroid via monorail]

Comment #54 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c54

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/8a526a41535f7949359552de16309f0bf5e13152

commit 8a526a41535f7949359552de16309f0bf5e13152
Author: Igor Sheludko <ish...@chromium.org>
Date: Fri Feb 08 14:27:18 2019

[ptr-compr][x64] TurboFan support for compressing stores

This CL also stops using checked decompression for tagged values
in TurboFan backend.

Bug: v8:7703
Change-Id: I4ab7670301924a365a10bb78f43bce0bbf785862
Reviewed-on: https://chromium-review.googlesource.com/c/1459638

Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#59462}
[modify] https://crrev.com/8a526a41535f7949359552de16309f0bf5e13152/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/8a526a41535f7949359552de16309f0bf5e13152/src/compiler/backend/x64/instruction-codes-x64.h
[modify] https://crrev.com/8a526a41535f7949359552de16309f0bf5e13152/src/compiler/backend/x64/instruction-scheduler-x64.cc
[modify] https://crrev.com/8a526a41535f7949359552de16309f0bf5e13152/src/compiler/backend/x64/instruction-selector-x64.cc
[modify] https://crrev.com/8a526a41535f7949359552de16309f0bf5e13152/src/x64/macro-assembler-x64.h

[bugdroid via monorail]

Comment #55 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c55

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e

commit 93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e
Author: Igor Sheludko <ish...@chromium.org>
Date: Fri Feb 08 17:24:19 2019

[ptr-compr] Fix compressing stores in CSA/builtins

... and also loads of off-heap tagged values.

Bug: v8:7703
Change-Id: I0dd15ecda76cc35fe5f2f51a7103937a7ac238dc
Reviewed-on: https://chromium-review.googlesource.com/c/1459639
Commit-Queue: Igor Sheludko <ish...@chromium.org>

Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>

Reviewed-by: Ross McIlroy <rmci...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59468}
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/builtins/builtins-microtask-queue-gen.cc
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/code-stub-assembler.cc
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/code-stub-assembler.h
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/compiler/code-assembler.cc
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/compiler/code-assembler.h
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/elements.cc
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/interpreter/interpreter-assembler.cc
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/interpreter/interpreter-generator.cc
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/src/objects/slots-inl.h
[modify] https://crrev.com/93d92cfbbe0f9f7b7b9d46ad02080b2f3932a03e/test/unittests/interpreter/interpreter-assembler-unittest.cc

[bugdroid via monorail]

Comment #56 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c56

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/2ef4e3d7f1d249848a08801b6f83b184d1c5e1f7

commit 2ef4e3d7f1d249848a08801b6f83b184d1c5e1f7
Author: Santiago Aboy Solanes <sol...@chromium.org>
Date: Mon Feb 11 14:34:35 2019

[ptr-compr][arm64] Introduce bottlenecks for accessing on-heap tagged fields.

This CL introduces TurboAssembler::LoadTaggedPointerField() and
TurboAssembler::LoadAnyTaggedField(), which respectively loads a field
containing a HeapObject, or any tagged value, and decompresses it if necessary.

Bug: v8:7703
Change-Id: I71ace74d7433a3a78d56bdcef6d2ec041df630e4
Reviewed-on: https://chromium-review.googlesource.com/c/1456098
Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>
Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Reviewed-by: Sigurd Schneider <sig...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ross McIlroy <rmci...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59501}
[modify] https://crrev.com/2ef4e3d7f1d249848a08801b6f83b184d1c5e1f7/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/2ef4e3d7f1d249848a08801b6f83b184d1c5e1f7/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/2ef4e3d7f1d249848a08801b6f83b184d1c5e1f7/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/2ef4e3d7f1d249848a08801b6f83b184d1c5e1f7/src/compiler/backend/arm64/code-generator-arm64.cc
[modify] https://crrev.com/2ef4e3d7f1d249848a08801b6f83b184d1c5e1f7/src/debug/arm64/debug-arm64.cc

[bugdroid via monorail]

Comment #57 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c57

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/54d63acabf49f42d2e83bfa4a7d8d690ca4d12e2

commit 54d63acabf49f42d2e83bfa4a7d8d690ca4d12e2

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Mon Feb 11 14:42:15 2019

[ptr-compr][arm64] Finish introducing bottlenecks for accessing on-heap
tagged fields.

Implemented TurboAssembler::StoreTaggedField for tagged fields's store.
Instead of pushes like x64 does, in arm64 do loads due to doing a
load-poke combination rather than just a push.

See https://chromium-review.googlesource.com/c/v8/v8/+/1382740 for the x64
version.

Bug: v8:7703
Change-Id: I79fbba4b03260c0dba5624e990c5af51290b28c6
Reviewed-on: https://chromium-review.googlesource.com/c/1462956

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Reviewed-by: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ross McIlroy <rmci...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#59502}
[modify] https://crrev.com/54d63acabf49f42d2e83bfa4a7d8d690ca4d12e2/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/54d63acabf49f42d2e83bfa4a7d8d690ca4d12e2/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/54d63acabf49f42d2e83bfa4a7d8d690ca4d12e2/src/builtins/arm64/builtins-arm64.cc

[bugdroid via monorail]

Comment #58 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c58

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/34bcb7f062ef550b773580e1d935dcf3c600a315

commit 34bcb7f062ef550b773580e1d935dcf3c600a315
Author: Igor Sheludko <ish...@chromium.org>
Date: Mon Feb 11 16:13:21 2019

[ptr-compr] Fix tests that write tagged values to off-heap locations

Bug: v8:7703
Change-Id: I8fa2659814f1d9585d0e2313540e8c11997eec6b
Reviewed-on: https://chromium-review.googlesource.com/c/1459636
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Michael Starzinger <mstar...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59507}
[modify] https://crrev.com/34bcb7f062ef550b773580e1d935dcf3c600a315/test/cctest/compiler/codegen-tester.h
[modify] https://crrev.com/34bcb7f062ef550b773580e1d935dcf3c600a315/test/cctest/compiler/test-run-load-store.cc
[modify] https://crrev.com/34bcb7f062ef550b773580e1d935dcf3c600a315/test/cctest/compiler/test-run-machops.cc

[bugdroid via monorail]

Comment #59 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c59

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/3abc01f2848eb0784b3c61bf167cedd601659cf5

commit 3abc01f2848eb0784b3c61bf167cedd601659cf5

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Tue Feb 12 10:01:31 2019

[ptr-compr][arm64] Implementing SmiUntagField which loads a field
containing smi value and untags it.

This CL finishes up the parity with x64 with regards to
(https://chromium-review.googlesource.com/c/v8/v8/+/1382740)

Bug: v8:7703
Change-Id: I3c88fbbfd3e47e944a6891171d6555f330cd5fd2
Reviewed-on: https://chromium-review.googlesource.com/c/1463523
Reviewed-by: Ross McIlroy <rmci...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#59521}
[modify] https://crrev.com/3abc01f2848eb0784b3c61bf167cedd601659cf5/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/3abc01f2848eb0784b3c61bf167cedd601659cf5/src/arm64/macro-assembler-arm64.h
[modify] https://crrev.com/3abc01f2848eb0784b3c61bf167cedd601659cf5/src/builtins/arm64/builtins-arm64.cc

[bugdroid via monorail]

Comment #60 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c60

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/dae0f73f29071449f322a5bd888e20f61c2794f6

commit dae0f73f29071449f322a5bd888e20f61c2794f6

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Thu Feb 14 10:42:44 2019

[ptr-compr][arm64] TurboFan support for compressing stores

Similar to x64's CL (https://chromium-review.googlesource.com/c/v8/v8/+/1459638)

Bug: v8:7703
Change-Id: I4b4e06ccdb9f428559dfb6b74e8ac149f955745c
Reviewed-on: https://chromium-review.googlesource.com/c/1467181

Reviewed-by: Ross McIlroy <rmci...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>

Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#59591}
[modify] https://crrev.com/dae0f73f29071449f322a5bd888e20f61c2794f6/src/compiler/backend/arm64/code-generator-arm64.cc
[modify] https://crrev.com/dae0f73f29071449f322a5bd888e20f61c2794f6/src/compiler/backend/arm64/instruction-codes-arm64.h
[modify] https://crrev.com/dae0f73f29071449f322a5bd888e20f61c2794f6/src/compiler/backend/arm64/instruction-scheduler-arm64.cc
[modify] https://crrev.com/dae0f73f29071449f322a5bd888e20f61c2794f6/src/compiler/backend/arm64/instruction-selector-arm64.cc

[bugdroid via monorail]

Comment #61 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c61

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/89276f9f99bfbaff5ea196681fd2305df3fe6303

commit 89276f9f99bfbaff5ea196681fd2305df3fe6303
Author: Igor Sheludko <ish...@chromium.org>
Date: Fri Feb 15 15:12:19 2019

[ptr-compr][x64] Change compression scheme to zero upper 32-bits

... and verify that upper 32-bits of on-heap tagged values contain zero.

This CL also removes scratch register argument from decompression
snippets.

Bug: v8:7703
Change-Id: Ia69d1c5de423c465735719ed07d92df03d9db97c
Reviewed-on: https://chromium-review.googlesource.com/c/1460953
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59634}
[modify] https://crrev.com/89276f9f99bfbaff5ea196681fd2305df3fe6303/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/89276f9f99bfbaff5ea196681fd2305df3fe6303/src/debug/x64/debug-x64.cc
[modify] https://crrev.com/89276f9f99bfbaff5ea196681fd2305df3fe6303/src/objects-debug.cc
[modify] https://crrev.com/89276f9f99bfbaff5ea196681fd2305df3fe6303/src/objects-inl.h
[modify] https://crrev.com/89276f9f99bfbaff5ea196681fd2305df3fe6303/src/ptr-compr-inl.h
[modify] https://crrev.com/89276f9f99bfbaff5ea196681fd2305df3fe6303/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/89276f9f99bfbaff5ea196681fd2305df3fe6303/src/x64/macro-assembler-x64.h
[modify] https://crrev.com/89276f9f99bfbaff5ea196681fd2305df3fe6303/test/cctest/compiler/test-run-load-store.cc

[bugdroid via monorail]

Comment #62 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c62

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/706aa1fe6646c3907f6a68513fa1138a26f72ee6

commit 706aa1fe6646c3907f6a68513fa1138a26f72ee6

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Mon Feb 18 11:19:17 2019

[ptr-compr][arm64] Change compression scheme to zero upper 32-bits

Also adding LoadTaggedPointerField and LoadAnyTaggedField that were
missed on previous CLs.

Similar to X64's CL:
https://chromium-review.googlesource.com/c/v8/v8/+/1460953

Bug: v8:7703
Change-Id: I9c917aadace65d45204c3360aeeb7e9ece296e70
Reviewed-on: https://chromium-review.googlesource.com/c/1475474
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Sigurd Schneider <sig...@chromium.org>

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#59655}
[modify] https://crrev.com/706aa1fe6646c3907f6a68513fa1138a26f72ee6/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/706aa1fe6646c3907f6a68513fa1138a26f72ee6/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/706aa1fe6646c3907f6a68513fa1138a26f72ee6/src/compiler/backend/arm64/code-generator-arm64.cc

[bugdroid via monorail]

Comment #66 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c66

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/85b80cb7bfc36318949d1c1df5143ed0802e20c2

commit 85b80cb7bfc36318949d1c1df5143ed0802e20c2
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Feb 21 14:27:17 2019

[ptr-compr][wasm] Prepare wasm for 32-bit kTaggedSize

Bug: v8:7703
Change-Id: I06d4195597f0ac8ee771da49c9a402be48e91f15
Reviewed-on: https://chromium-review.googlesource.com/c/1480377
Reviewed-by: Clemens Hammacher <clem...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59764}
[modify] https://crrev.com/85b80cb7bfc36318949d1c1df5143ed0802e20c2/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/85b80cb7bfc36318949d1c1df5143ed0802e20c2/src/wasm/baseline/liftoff-compiler.cc
[modify] https://crrev.com/85b80cb7bfc36318949d1c1df5143ed0802e20c2/src/wasm/wasm-objects.h

[bugdroid via monorail]

Comment #67 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c67

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/69e7ded547fbb713d751818323d62f4e5f8a1e07

commit 69e7ded547fbb713d751818323d62f4e5f8a1e07
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Feb 21 15:03:33 2019

[ptr-compr] Fix string externalization

With 32-bit kTaggedSize small strings may be not externalizable.

Bug: v8:7703
Change-Id: I34002568214742dadb2358fca97dfb4b92a5342a
Reviewed-on: https://chromium-review.googlesource.com/c/1480373
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59770}
[modify] https://crrev.com/69e7ded547fbb713d751818323d62f4e5f8a1e07/src/api.cc
[modify] https://crrev.com/69e7ded547fbb713d751818323d62f4e5f8a1e07/src/objects/string.cc
[modify] https://crrev.com/69e7ded547fbb713d751818323d62f4e5f8a1e07/test/cctest/test-api.cc
[modify] https://crrev.com/69e7ded547fbb713d751818323d62f4e5f8a1e07/test/mjsunit/string-external-cached.js
[modify] https://crrev.com/69e7ded547fbb713d751818323d62f4e5f8a1e07/test/mjsunit/string-externalize.js

[bugdroid via monorail]

Comment #68 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c68

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/7909a5f5bb54dd50975de3f7d08f149cae1cc594

commit 7909a5f5bb54dd50975de3f7d08f149cae1cc594
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Feb 21 16:41:46 2019

[ptr-compr] Fix alignment issues in FastAsciiConvert()

With 32-bit kTaggedSize string data address may not be kSystemPointerSize
aligned.

Bug: v8:7703
Change-Id: I243e6844bed62d96f8b07328fffe23e83512e8e5
Reviewed-on: https://chromium-review.googlesource.com/c/1481217

Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#59772}
[modify] https://crrev.com/7909a5f5bb54dd50975de3f7d08f149cae1cc594/src/string-case.cc

[bugdroid via monorail]

Comment #69 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c69

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/acf741b9863bf921a37868888cfc89f6aa13b105

commit acf741b9863bf921a37868888cfc89f6aa13b105
Author: Igor Sheludko <ish...@chromium.org>
Date: Fri Feb 22 15:30:21 2019

[ptr-compr] Fix broken string externalization tests

... which will work for 32-bit kTaggedSize but we are not there yet.

Bug: v8:7703
Change-Id: Iaceb126ba316f37532221597cbd4f7e85ceb4fb9
Reviewed-on: https://chromium-review.googlesource.com/c/1482917

Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#59797}
[modify] https://crrev.com/acf741b9863bf921a37868888cfc89f6aa13b105/test/cctest/test-api.cc

[bugdroid via monorail]

Comment #70 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c70

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/03e13f7a47f4169d8e19c62168f669b12335d913

commit 03e13f7a47f4169d8e19c62168f669b12335d913

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Fri Feb 22 15:52:06 2019

[Turbofan] Introduce LoadStackArgument to represent loading arguments from the stack.

This now makes it so TurboFan now uses full pointer loads for arguments values
located on stack.

Bug: v8:8876, v8:7703
Change-Id: Ib82d6f3b0f4c8d33669c7f86ce803381d210c019
Reviewed-on: https://chromium-review.googlesource.com/c/1480382
Reviewed-by: Ross McIlroy <rmci...@chromium.org>
Reviewed-by: Tobias Tebbi <te...@chromium.org>

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#59798}
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/access-builder.cc
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/access-builder.h
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/effect-control-linearizer.cc
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/effect-control-linearizer.h
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/escape-analysis-reducer.cc
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/opcodes.h
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/simplified-operator.cc
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/simplified-operator.h
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/typer.cc
[modify] https://crrev.com/03e13f7a47f4169d8e19c62168f669b12335d913/src/compiler/verifier.cc

[bugdroid via monorail]

Comment #71 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c71

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8

commit f70bb59b57e2a66f165a728c1799e36ceb0e9fc8
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Feb 27 15:26:09 2019

[ptr-compr] Prepare for changing kTaggedSize, pt.1

Includes various fixes and cleanups here and there.

Bug: v8:7703, v8:8852
Change-Id: I603eb0212cab3fecabfa15dceb70ee23b81cdb5a
Reviewed-on: https://chromium-review.googlesource.com/c/1491595

Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#59909}
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/builtins/builtins-arguments-gen.cc
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/builtins/builtins-typed-array-gen.cc
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/code-stub-assembler.cc
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/globals.h
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/isolate.cc
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/objects-printer.cc
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/objects.cc
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/objects/code-inl.h
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/objects/code.h
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/objects/fixed-array.h
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/objects/js-array-buffer.h
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/objects/shared-function-info.h
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/test/cctest/test-api.cc
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/test/unittests/interpreter/interpreter-assembler-unittest.cc
[modify] https://crrev.com/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8/tools/gen-postmortem-metadata.py

[bugdroid via monorail]

Comment #72 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c72

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/6a5cd5987d4a4a297e5b138464e28297e43f4a20

commit 6a5cd5987d4a4a297e5b138464e28297e43f4a20
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Feb 27 16:00:05 2019

[ptr-compr] Prepare for changing kTaggedSize, pt.2

This CL also unifies CopyWords() and CopyBytes() implementations.

Bug: v8:7703
Change-Id: I0b2e2f35c0c651e46231c4e4286c705634dce02b
Reviewed-on: https://chromium-review.googlesource.com/c/1491602
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59912}
[modify] https://crrev.com/6a5cd5987d4a4a297e5b138464e28297e43f4a20/src/heap/heap-inl.h
[modify] https://crrev.com/6a5cd5987d4a4a297e5b138464e28297e43f4a20/src/heap/remembered-set.h
[modify] https://crrev.com/6a5cd5987d4a4a297e5b138464e28297e43f4a20/src/heap/scavenger-inl.h
[modify] https://crrev.com/6a5cd5987d4a4a297e5b138464e28297e43f4a20/src/heap/scavenger.cc
[modify] https://crrev.com/6a5cd5987d4a4a297e5b138464e28297e43f4a20/src/heap/spaces.h
[modify] https://crrev.com/6a5cd5987d4a4a297e5b138464e28297e43f4a20/src/memcopy.h
[modify] https://crrev.com/6a5cd5987d4a4a297e5b138464e28297e43f4a20/src/objects/slots-atomic-inl.h
[modify] https://crrev.com/6a5cd5987d4a4a297e5b138464e28297e43f4a20/src/objects/slots-inl.h

[bugdroid via monorail]

Comment #73 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c73

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/8308ba08644c64c1f3b459269e95b4ef13881874

commit 8308ba08644c64c1f3b459269e95b4ef13881874
Author: Junliang Yan <jy...@ca.ibm.com>
Date: Wed Feb 27 18:32:29 2019

PPC: [ptr-compr] Prepare for changing kTaggedSize, pt.1

Port f70bb59b57e2a66f165a728c1799e36ceb0e9fc8

Original Commit Message:

Includes various fixes and cleanups here and there.

R=ish...@chromium.org, jora...@ca.ibm.com, michael...@ca.ibm.com, mila...@ca.ibm.com

LOG=N

Bug: v8:7703, v8:8852

Change-Id: I1e25c6da6677aab64dabc052aee555f534386df7
Reviewed-on: https://chromium-review.googlesource.com/c/1491698
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Junliang Yan <jy...@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#59922}
[modify] https://crrev.com/8308ba08644c64c1f3b459269e95b4ef13881874/src/objects/code.h

[bugdroid via monorail]

Comment #74 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c74

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/4633c78207743adf853768bbf0a8f571c8e98272

commit 4633c78207743adf853768bbf0a8f571c8e98272
Author: Igor Sheludko <ish...@chromium.org>
Date: Mon Mar 04 13:47:42 2019

[ptr-compr][heap] Make all map checks pointer compression friendly

Bug: v8:7703
Change-Id: I3d521423eec725915d1a197c79c076ad54eeef14
Reviewed-on: https://chromium-review.googlesource.com/c/1496368

Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#60005}
[modify] https://crrev.com/4633c78207743adf853768bbf0a8f571c8e98272/src/heap/spaces.cc

[bugdroid via monorail]

Comment #75 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c75

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/1744803073948ab7e4ec00e34c62dee779fe7564

commit 1744803073948ab7e4ec00e34c62dee779fe7564
Author: Igor Sheludko <ish...@chromium.org>
Date: Mon Mar 04 15:40:02 2019

[ptr-compr] Prepare for changing kTaggedSize, pt.3

This CL also gives up trying to maintain double and system word
fields at aligned addresses because currently it's not always
maintained (v8:8875) and Torque object definitions do not support
padding fields (v8:8863).

Given that both platforms where pointer compression is going to be
enabled (x64 and arm64) support loading of doubles and full words
from 4-byte aligned addresses we are fine.

Bug: v8:7703
Change-Id: I99fc6da5a0927f4db9b8fb24c7cc0bfc416523bc
Reviewed-on: https://chromium-review.googlesource.com/c/1496974
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Ulan Degenbaev <ul...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60013}
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/include/v8-internal.h
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/include/v8.h
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/code-stub-assembler.cc
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/elements.cc
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/heap/heap.cc
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/heap/spaces-inl.h
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/objects-inl.h
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/objects/embedder-data-slot.h
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/objects/fixed-array.h
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/objects/foreign.h
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/objects/js-objects-inl.h
[modify] https://crrev.com/1744803073948ab7e4ec00e34c62dee779fe7564/src/objects/js-objects.h

[ish… via monorail]

Issue 7703: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703

This issue is now blocking issue 8948.
See https://bugs.chromium.org/p/v8/issues/detail?id=8948

[bugdroid via monorail]

Comment #77 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c77

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/392316ddd11104ad759131732dfe0805f3972ab2

commit 392316ddd11104ad759131732dfe0805f3972ab2
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Mar 06 12:27:39 2019

[ptr-compr][x64] Define kTaggedSize as kInt32Size

... when pointer compression is enabled and some number of cleanups.

Bug: v8:7703
Change-Id: If7344abf68a1c4d54e4a79d066dc185f25055d7d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1477737
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60056}
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/include/v8-internal.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/include/v8.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/globals.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/memcopy.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/objects-inl.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/objects/code.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/objects/embedder-data-slot-inl.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/objects/embedder-data-slot.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/objects/slots-atomic-inl.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/objects/slots-inl.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/objects/slots.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/ptr-compr-inl.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/ptr-compr.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/snapshot/partial-serializer.cc
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/x64/assembler-x64.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/src/x64/macro-assembler-x64.cc
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/test/cctest/compiler/codegen-tester.h
[modify] https://crrev.com/392316ddd11104ad759131732dfe0805f3972ab2/test/cctest/compiler/test-run-load-store.cc

[bugdroid via monorail]

Comment #78 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c78

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/ad49f12908644fa1dc7e5aa28839a85872084f8c

commit ad49f12908644fa1dc7e5aa28839a85872084f8c
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Mar 06 19:41:21 2019

[cleanup] Move Compressed[XXX]Slot definitions to separate header

... and fix header includes to please the respective bot.

Drive-by-fix: decompression implementation is now MSVC friendly.

Bug: v8:7703, v8:8834
Change-Id: Iaf589138e5bafb32b0d9feab5cf074b71f241a3c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505579
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60074}
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/BUILD.gn
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/base/macros.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/bootstrapper.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/heap/heap-write-barrier-inl.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/heap/slot-set.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/isolate.cc
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects.h
[add] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/compressed-slots-inl.h
[add] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/compressed-slots.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/embedder-data-array-inl.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/fixed-array-inl.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/fixed-array.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/maybe-object.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/ordered-hash-table-inl.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/ordered-hash-table.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/shared-function-info.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/slots-atomic-inl.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/objects/slots-inl.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/ptr-compr-inl.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/ptr-compr.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/src/visitors.h
[modify] https://crrev.com/ad49f12908644fa1dc7e5aa28839a85872084f8c/test/cctest/test-code-stub-assembler.cc

[rmcil… via monorail]

Updates:
Cc: rmci...@chromium.org

Comment #79 on issue 7703 by rmci...@chromium.org: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c79

(No comment was entered for this change.)

[bugdroid via monorail]

Comment #80 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c80

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/14f07a8b30dd28bd6508924fae01e0c2d1892aad

commit 14f07a8b30dd28bd6508924fae01e0c2d1892aad
Author: Junliang Yan <jy...@ca.ibm.com>
Date: Thu Mar 07 15:01:48 2019

[ptr-compr] Define kTaggedPayloadOffset correctly on Big Endian

smi size is sill 8 bytes when V8_COMPRESS_POINTERS is undefined.

Bug: v8:7703
Change-Id: I0d1e757e42e8b1e6b10960420135245e24553175
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508572
Commit-Queue: Junliang Yan <jy...@ca.ibm.com>
Auto-Submit: Junliang Yan <jy...@ca.ibm.com>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60097}
[modify] https://crrev.com/14f07a8b30dd28bd6508924fae01e0c2d1892aad/src/objects/embedder-data-slot.h

[bugdroid via monorail]

Comment #81 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c81

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/676014b36ffb28f9d25e5d232547deb5735baa44

commit 676014b36ffb28f9d25e5d232547deb5735baa44
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Mar 07 15:40:42 2019

[ptr-compr] Fix MSVC build

... which complained about truncating uintptr_t constant to uint32_t.

Bug: v8:7703
Change-Id: I6fae2bf1e5de79e6131479b84a8d8aa5b9de909f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508672
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60100}
[modify] https://crrev.com/676014b36ffb28f9d25e5d232547deb5735baa44/src/string-case.cc

[bugdroid via monorail]

Comment #82 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c82

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/afbfd7563d88b90b095b454344f91de6138cbbf3

commit afbfd7563d88b90b095b454344f91de6138cbbf3
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Mar 07 18:41:05 2019

[ptr-compr] Fix ptr-compr broken by 4e6a1a75

(https://chromium-review.googlesource.com/c/v8/v8/+/1467182)

Bug: v8:7703
Change-Id: Ia6b74b985735af67bde56b30e4a709247eb591be
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508674
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Ulan Degenbaev <ul...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60102}
[modify] https://crrev.com/afbfd7563d88b90b095b454344f91de6138cbbf3/src/heap/scavenger.cc

[bugdroid via monorail]

Comment #83 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c83

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/f792eb83a6501d44d4ef51b11894ce2ba9dc8f91

commit f792eb83a6501d44d4ef51b11894ce2ba9dc8f91

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Mon Mar 11 17:21:48 2019

[ptr-compr][arm64] Update pointer compression arm64's implementation

Since kTaggedSize got shrinked and we are actually compressing
the pointers (as oppposed to zeroing their upper bits),
we need to update the arm64 codebase to accommodate this change.

Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng
Bug: v8:7703
Change-Id: I890f3ab8c046f47232e80f85830f9ae8f4dbced4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499498

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Reviewed-by: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ross McIlroy <rmci...@chromium.org>
Reviewed-by: Clemens Hammacher <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60172}
[modify] https://crrev.com/f792eb83a6501d44d4ef51b11894ce2ba9dc8f91/src/arm64/macro-assembler-arm64-inl.h
[modify] https://crrev.com/f792eb83a6501d44d4ef51b11894ce2ba9dc8f91/src/arm64/macro-assembler-arm64.cc
[modify] https://crrev.com/f792eb83a6501d44d4ef51b11894ce2ba9dc8f91/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/f792eb83a6501d44d4ef51b11894ce2ba9dc8f91/src/wasm/baseline/arm64/liftoff-assembler-arm64.h

[bugdroid via monorail]

Comment #84 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c84

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/589d1a6b753e2bb4a5d732f49cd7f4724099b6b2

commit 589d1a6b753e2bb4a5d732f49cd7f4724099b6b2
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Mar 14 09:16:26 2019

[ptr-compr][x64] Temporarily enable pointer compression on x64

... and make sure that the x64 ptr-compr bots proceed testing V8 without
pointer compression in order to keep testing the full pointer mode.

Bug: v8:7703
Change-Id: Iee725deda813425a6f0722948b54976154f50909
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139
Reviewed-by: Michael Hablich <hab...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60230}
[modify] https://crrev.com/589d1a6b753e2bb4a5d732f49cd7f4724099b6b2/BUILD.gn
[modify] https://crrev.com/589d1a6b753e2bb4a5d732f49cd7f4724099b6b2/infra/mb/mb_config.pyl
[modify] https://crrev.com/589d1a6b753e2bb4a5d732f49cd7f4724099b6b2/tools/v8heapconst.py

[bugdroid via monorail]

Comment #85 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c85

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/77f9b2876779fd8c39875531c76dc006aa075648

commit 77f9b2876779fd8c39875531c76dc006aa075648
Author: Maya Lekova <msle...@chromium.org>
Date: Thu Mar 14 09:28:48 2019

Revert "[ptr-compr][x64] Temporarily enable pointer compression on x64"

This reverts commit 589d1a6b753e2bb4a5d732f49cd7f4724099b6b2.

Reason for revert: Breaking UBSan - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/5219

Original change's description:

> [ptr-compr][x64] Temporarily enable pointer compression on x64
>
> ... and make sure that the x64 ptr-compr bots proceed testing V8 without
> pointer compression in order to keep testing the full pointer mode.
>
> Bug: v8:7703
> Change-Id: Iee725deda813425a6f0722948b54976154f50909
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139
> Reviewed-by: Michael Hablich <hab...@chromium.org>
> Reviewed-by: Michael Achenbach <mache...@chromium.org>
> Commit-Queue: Michael Achenbach <mache...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60230}

TBR=mache...@chromium.org,hab...@chromium.org,ish...@chromium.org,verw...@chromium.org

Change-Id: I5a9f04acba1ef23ae944d97a029ea018808c7fcb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7703
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1522991
Reviewed-by: Maya Lekova <msle...@chromium.org>
Commit-Queue: Maya Lekova <msle...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60231}
[modify] https://crrev.com/77f9b2876779fd8c39875531c76dc006aa075648/BUILD.gn
[modify] https://crrev.com/77f9b2876779fd8c39875531c76dc006aa075648/infra/mb/mb_config.pyl
[modify] https://crrev.com/77f9b2876779fd8c39875531c76dc006aa075648/tools/v8heapconst.py

[bugdroid via monorail]

Comment #86 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c86

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/6861278461f2ac6a3bc8410a61d198f18e96d47a

commit 6861278461f2ac6a3bc8410a61d198f18e96d47a
Author: Leszek Swirski <les...@chromium.org>
Date: Thu Mar 14 10:48:17 2019

[build] Suppress UBSan alignment checks in pointer compression

It is a design decision of pointer compression to allow unaligned pointers,
so disable this check in UBSan.

Bug: v8:7703
Change-Id: I3fab34e77ad755cdef3cd385a3615e3d0e350c16
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523346
Commit-Queue: Leszek Swirski <les...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Auto-Submit: Leszek Swirski <les...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60235}
[modify] https://crrev.com/6861278461f2ac6a3bc8410a61d198f18e96d47a/BUILD.gn

[bugdroid via monorail]

Comment #87 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c87

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/43fa6bc9d26f2b50a39d56d14dd2cce03a2da025

commit 43fa6bc9d26f2b50a39d56d14dd2cce03a2da025
Author: Igor Sheludko <ish...@chromium.org>
Date: Mon Mar 18 12:31:48 2019

Revert "[build] Suppress UBSan alignment checks in pointer compression"

This reverts commit 6861278461f2ac6a3bc8410a61d198f18e96d47a.

Reason for revert: I'll follow Jakob's suggestion and fix unaligned accesses in C++ with ReadUnalignedValue().

Original change's description:

> [build] Suppress UBSan alignment checks in pointer compression
>
> It is a design decision of pointer compression to allow unaligned pointers,
> so disable this check in UBSan.
>
> Bug: v8:7703
> Change-Id: I3fab34e77ad755cdef3cd385a3615e3d0e350c16
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523346
> Commit-Queue: Leszek Swirski <les...@chromium.org>
> Commit-Queue: Michael Achenbach <mache...@chromium.org>
> Auto-Submit: Leszek Swirski <les...@chromium.org>
> Reviewed-by: Michael Achenbach <mache...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60235}

TBR=jkum...@chromium.org,mache...@chromium.org,les...@chromium.org,verw...@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7703
Change-Id: I17e669e7b5e2dea8f0686911730d27f3d2732b85
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526200
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60283}
[modify] https://crrev.com/43fa6bc9d26f2b50a39d56d14dd2cce03a2da025/BUILD.gn

[bugdroid via monorail]

Comment #88 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c88

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/123ca158b6f973809cf00d6eac995e01b026c7b4

commit 123ca158b6f973809cf00d6eac995e01b026c7b4
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Mar 19 10:44:05 2019

[ptr-compr][ubsan] Introduce UnalignedSlot<T> - unaligned pointer adapter

... which can be used with STL algorithms.

When pointer compression is enabled the [u]intptr_t and double fields are
only kTaggedSize aligned so in order to avoid undefined behavior in C++ code
we have to access these values in an unaligned pointer friendly way although
both x64 and arm64 architectures (where pointer compression is supported)
allow unaligned access.

These changes will be removed once v8:8875 is fixed and all the
kSystemPointerSize fields are properly aligned.

Bug: v8:7703
Change-Id: If581fc00d63ae759c73b2a0f115331eea336605f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528995
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60319}
[modify] https://crrev.com/123ca158b6f973809cf00d6eac995e01b026c7b4/src/elements.cc
[modify] https://crrev.com/123ca158b6f973809cf00d6eac995e01b026c7b4/src/objects/slots-atomic-inl.h
[modify] https://crrev.com/123ca158b6f973809cf00d6eac995e01b026c7b4/src/objects/slots.h
[modify] https://crrev.com/123ca158b6f973809cf00d6eac995e01b026c7b4/src/runtime/runtime-typedarray.cc

[bugdroid via monorail]

Comment #89 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c89

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/0188634ee523aef39ba71732b1ab9d422f449825

commit 0188634ee523aef39ba71732b1ab9d422f449825
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Mar 19 11:34:31 2019

[ptr-compr][ubsan] Use [Read/Write]UnalignedValue for unaligned fields

When pointer compression is enabled the [u]intptr_t and double fields are
only kTaggedSize aligned so in order to avoid undefined behavior in C++ code
we have to access these values in an unaligned pointer friendly way although
both x64 and arm64 architectures (where pointer compression is supported)
allow unaligned access.

These changes will be removed once v8:8875 is fixed and all the
kSystemPointerSize fields are properly aligned.

Bug: v8:7703

Change-Id: I4df477cbdeab806303bb4f675d52b61c06342c8e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528996

Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>

Reviewed-by: Jakob Gruber <jgr...@chromium.org>
Reviewed-by: Clemens Hammacher <clem...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60321}
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/include/v8-internal.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/include/v8.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/heap/heap-inl.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/objects/bigint.cc
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/objects/bigint.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/objects/embedder-data-slot-inl.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/objects/fixed-array-inl.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/objects/object-macros-undef.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/objects/object-macros.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/objects/string-inl.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/objects/string.h
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/snapshot/serializer.cc
[modify] https://crrev.com/0188634ee523aef39ba71732b1ab9d422f449825/src/wasm/wasm-objects-inl.h

[bugdroid via monorail]

Comment #90 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c90

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/aa068cfc68972fb00b730c64b0d788aa3b030d97

commit aa068cfc68972fb00b730c64b0d788aa3b030d97
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Mar 19 15:27:57 2019

[ptr-compr][tsan] Explicitly whitelist legitimate concurrent accesses to Map's bit fields

Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel
Bug: v8:7703
Change-Id: I3511710cead1c18b75783f71af3127693e7f17fd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529007

Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#60334}
[modify] https://crrev.com/aa068cfc68972fb00b730c64b0d788aa3b030d97/src/objects-body-descriptors-inl.h
[modify] https://crrev.com/aa068cfc68972fb00b730c64b0d788aa3b030d97/src/objects/map-inl.h
[modify] https://crrev.com/aa068cfc68972fb00b730c64b0d788aa3b030d97/src/objects/map.h

[bugdroid via monorail]

Comment #91 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c91

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/71dbb7fa495a845564c29eb682ca21e57d045ae8

commit 71dbb7fa495a845564c29eb682ca21e57d045ae8
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Mar 19 16:43:17 2019

[ptr-compr][ubsan] Use UnalignedSlot only for types which require bigger alignments

Bug: v8:7703
Change-Id: I497fe7e4ba81acbda8564142959f823c5195c5eb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529008
Reviewed-by: Ulan Degenbaev <ul...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60338}
[modify] https://crrev.com/71dbb7fa495a845564c29eb682ca21e57d045ae8/src/elements.cc
[modify] https://crrev.com/71dbb7fa495a845564c29eb682ca21e57d045ae8/src/runtime/runtime-typedarray.cc

[bugdroid via monorail]

Comment #92 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c92

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/4f051fd5da0b9b2b82ce87e762a87d4468f038ee

commit 4f051fd5da0b9b2b82ce87e762a87d4468f038ee
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Mar 19 17:19:57 2019

Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64"

This is a reland of 589d1a6b753e2bb4a5d732f49cd7f4724099b6b2

Relanding after fixing TSan and UBSan issues.

Original change's description:
> [ptr-compr][x64] Temporarily enable pointer compression on x64
>
> ... and make sure that the x64 ptr-compr bots proceed testing V8 without
> pointer compression in order to keep testing the full pointer mode.
>
> Bug: v8:7703
> Change-Id: Iee725deda813425a6f0722948b54976154f50909
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139
> Reviewed-by: Michael Hablich <hab...@chromium.org>
> Reviewed-by: Michael Achenbach <mache...@chromium.org>

> Commit-Queue: Michael Achenbach <mache...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60230}

Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel
Bug: v8:7703
Change-Id: Ied4e7bacf99c9d63e0459613fec522273f595de8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523327
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Auto-Submit: Leszek Swirski <les...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60339}
[modify] https://crrev.com/4f051fd5da0b9b2b82ce87e762a87d4468f038ee/BUILD.gn
[modify] https://crrev.com/4f051fd5da0b9b2b82ce87e762a87d4468f038ee/infra/mb/mb_config.pyl
[modify] https://crrev.com/4f051fd5da0b9b2b82ce87e762a87d4468f038ee/tools/v8heapconst.py

[bugdroid via monorail]

Comment #93 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c93

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/979b3a33d701729c91851597c37774df1cc56d8a

commit 979b3a33d701729c91851597c37774df1cc56d8a
Author: Deepti Gandluri <gde...@chromium.org>
Date: Tue Mar 19 17:51:00 2019

Revert "Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64""

This reverts commit 4f051fd5da0b9b2b82ce87e762a87d4468f038ee.

Reason for revert: Fails with custom snapshot on GC stress - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/24855

Original change's description:

> Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64"
>
> This is a reland of 589d1a6b753e2bb4a5d732f49cd7f4724099b6b2
>
> Relanding after fixing TSan and UBSan issues.
>
> Original change's description:
> > [ptr-compr][x64] Temporarily enable pointer compression on x64
> >
> > ... and make sure that the x64 ptr-compr bots proceed testing V8 without
> > pointer compression in order to keep testing the full pointer mode.
> >
> > Bug: v8:7703
> > Change-Id: Iee725deda813425a6f0722948b54976154f50909
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139
> > Reviewed-by: Michael Hablich <hab...@chromium.org>
> > Reviewed-by: Michael Achenbach <mache...@chromium.org>
> > Commit-Queue: Michael Achenbach <mache...@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#60230}
>
> Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel
> Bug: v8:7703
> Change-Id: Ied4e7bacf99c9d63e0459613fec522273f595de8
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523327
> Commit-Queue: Igor Sheludko <ish...@chromium.org>
> Auto-Submit: Leszek Swirski <les...@chromium.org>
> Reviewed-by: Michael Achenbach <mache...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60339}

TBR=mache...@chromium.org,hab...@chromium.org,les...@chromium.org,ish...@chromium.org,verw...@chromium.org

Change-Id: Ia06829e9dfdf09501ceebc0eef175d3261969d1f

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7703

Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng, v8_linux64_tsan_rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1531120
Reviewed-by: Deepti Gandluri <gde...@chromium.org>
Commit-Queue: Deepti Gandluri <gde...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60340}
[modify] https://crrev.com/979b3a33d701729c91851597c37774df1cc56d8a/BUILD.gn
[modify] https://crrev.com/979b3a33d701729c91851597c37774df1cc56d8a/infra/mb/mb_config.pyl
[modify] https://crrev.com/979b3a33d701729c91851597c37774df1cc56d8a/tools/v8heapconst.py

[bugdroid via monorail]

Comment #94 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c94

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/7b8968368d2f3928aa87e270f6b9ae57caba5e20

commit 7b8968368d2f3928aa87e270f6b9ae57caba5e20
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Mar 20 14:23:33 2019

Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64"

This is a reland of 4f051fd5da0b9b2b82ce87e762a87d4468f038ee

Relanding because last revert was caused by unrelated flakes.

Original change's description:
> [ptr-compr][x64] Temporarily enable pointer compression on x64
>
> ... and make sure that the x64 ptr-compr bots proceed testing V8 without
> pointer compression in order to keep testing the full pointer mode.
>

> Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel
> Bug: v8:7703
> Change-Id: Ied4e7bacf99c9d63e0459613fec522273f595de8
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523327
> Commit-Queue: Igor Sheludko <ish...@chromium.org>
> Auto-Submit: Leszek Swirski <les...@chromium.org>
> Reviewed-by: Michael Achenbach <mache...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60339}

Bug: v8:7703
Change-Id: I9c588de77070d4fbf1bb1a21ae58c398a22eed9c
Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng, v8_linux64_tsan_rel, v8_mac64_gc_stress_dbg
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530819
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60370}
[modify] https://crrev.com/7b8968368d2f3928aa87e270f6b9ae57caba5e20/BUILD.gn
[modify] https://crrev.com/7b8968368d2f3928aa87e270f6b9ae57caba5e20/infra/mb/mb_config.pyl
[modify] https://crrev.com/7b8968368d2f3928aa87e270f6b9ae57caba5e20/tools/v8heapconst.py

[bugdroid via monorail]

Comment #95 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c95

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/6e7c723883e459b73bdb2d35767611ef678dbb76

commit 6e7c723883e459b73bdb2d35767611ef678dbb76
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Mar 20 17:29:44 2019

[ptr-compr][arm64] Fix accesses to CodeDataContainer::kind_specific_flags

This field's size is kIntSize but it was read as a 8-byte value in
assembly code.

Bug: v8:7703
Change-Id: I16e8c845c27b224b368c8888073cff6d53f28a54
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532324
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Sigurd Schneider <sig...@chromium.org>
Reviewed-by: Sigurd Schneider <sig...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60377}
[modify] https://crrev.com/6e7c723883e459b73bdb2d35767611ef678dbb76/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/6e7c723883e459b73bdb2d35767611ef678dbb76/src/compiler/backend/arm64/code-generator-arm64.cc

[bugdroid via monorail]

Comment #96 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c96

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/64a94207f017f3bf96d23cadd950ba5de054509c

commit 64a94207f017f3bf96d23cadd950ba5de054509c
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Mar 21 13:56:21 2019

[Turbofan][ptr-compr][x64] Use kScratchRegister instead of a fresh one

... for decompression because the former is not used by register
allocator and therefore always available.

Bug: v8:7703
Change-Id: I72d738be69c339444311d75c69f04c104e90bb90
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533857
Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60390}
[modify] https://crrev.com/64a94207f017f3bf96d23cadd950ba5de054509c/src/compiler/backend/x64/code-generator-x64.cc
[modify] https://crrev.com/64a94207f017f3bf96d23cadd950ba5de054509c/src/compiler/backend/x64/instruction-selector-x64.cc
[modify] https://crrev.com/64a94207f017f3bf96d23cadd950ba5de054509c/src/x64/macro-assembler-x64.h

[bugdroid via monorail]

Comment #97 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c97

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/39fca64db94928f4a11ef8504bc0b4cd3865b68b

commit 39fca64db94928f4a11ef8504bc0b4cd3865b68b
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Mar 21 13:58:41 2019

[ptr-compr] Add a switch for branchless/branchful decompression

Bug: v8:7703
Change-Id: Ic6cd8b337813ecff2a0d030aa3a57304e784378a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511486
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60391}
[modify] https://crrev.com/39fca64db94928f4a11ef8504bc0b4cd3865b68b/src/globals.h
[modify] https://crrev.com/39fca64db94928f4a11ef8504bc0b4cd3865b68b/src/ptr-compr-inl.h
[modify] https://crrev.com/39fca64db94928f4a11ef8504bc0b4cd3865b68b/src/x64/macro-assembler-x64.cc

[bugdroid via monorail]

Comment #98 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c98

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/f936fb42582851dc8a9670d9d224ae8aa1c3f3f1

commit f936fb42582851dc8a9670d9d224ae8aa1c3f3f1
Author: Michael Achenbach <mache...@chromium.org>
Date: Thu Mar 21 17:57:15 2019

Revert "Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64""

This reverts commit 7b8968368d2f3928aa87e270f6b9ae57caba5e20.

Reason for revert: Lots of test failures on current roll:
https://chromium-review.googlesource.com/c/chromium/src/+/1534141

Original change's description:

> Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64"
>
> This is a reland of 4f051fd5da0b9b2b82ce87e762a87d4468f038ee
>
> Relanding because last revert was caused by unrelated flakes.
>
> Original change's description:
> > [ptr-compr][x64] Temporarily enable pointer compression on x64
> >
> > ... and make sure that the x64 ptr-compr bots proceed testing V8 without
> > pointer compression in order to keep testing the full pointer mode.
> >
> > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel
> > Bug: v8:7703
> > Change-Id: Ied4e7bacf99c9d63e0459613fec522273f595de8
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523327
> > Commit-Queue: Igor Sheludko <ish...@chromium.org>
> > Auto-Submit: Leszek Swirski <les...@chromium.org>
> > Reviewed-by: Michael Achenbach <mache...@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#60339}
>
> Bug: v8:7703
> Change-Id: I9c588de77070d4fbf1bb1a21ae58c398a22eed9c
> Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng, v8_linux64_tsan_rel, v8_mac64_gc_stress_dbg
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530819
> Commit-Queue: Igor Sheludko <ish...@chromium.org>
> Reviewed-by: Michael Achenbach <mache...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60370}

TBR=mache...@chromium.org,ish...@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7703

Change-Id: I1c037470b5895c4269c9574e6c93d0eed6fe90d5

Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng, v8_linux64_tsan_rel, v8_mac64_gc_stress_dbg

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533867
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60397}
[modify] https://crrev.com/f936fb42582851dc8a9670d9d224ae8aa1c3f3f1/BUILD.gn
[modify] https://crrev.com/f936fb42582851dc8a9670d9d224ae8aa1c3f3f1/infra/mb/mb_config.pyl
[modify] https://crrev.com/f936fb42582851dc8a9670d9d224ae8aa1c3f3f1/tools/v8heapconst.py

[bugdroid via monorail]

Comment #99 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c99

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/8d605323e5809c9b7ff6c3fb415a6efc2a898dbf

commit 8d605323e5809c9b7ff6c3fb415a6efc2a898dbf

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Fri Mar 22 14:54:55 2019

[ptr-compr][arm64] Add a switch for branchless/branchful decompression

Similar to x64's https://chromium-review.googlesource.com/c/v8/v8/+/1511486

Bug: v8:7703
Change-Id: Ifd634a36bb56a53cb9901d9dd0899b66229607ef
Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535828

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Commit-Queue: Igor Sheludko <ish...@chromium.org>
Auto-Submit: Santiago Aboy Solanes <sol...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60412}
[modify] https://crrev.com/8d605323e5809c9b7ff6c3fb415a6efc2a898dbf/src/arm64/macro-assembler-arm64.cc

[bugdroid via monorail]

Comment #100 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c100

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/b45518fe5a3b2c5d9494aed581a30a86192477a4

commit b45518fe5a3b2c5d9494aed581a30a86192477a4
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Mar 27 15:47:28 2019

[ptr-compr] Fix broken ptr-compr build

Bug: v8:7703
Change-Id: I2fe68c54e59fd452ee724ce7fbd80eca6ab5e096
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541106
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Ben Titzer <tit...@chromium.org>
Reviewed-by: Ben Titzer <tit...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60493}
[modify] https://crrev.com/b45518fe5a3b2c5d9494aed581a30a86192477a4/src/wasm/wasm-objects.h

[bugdroid via monorail]

Comment #101 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c101

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/d341a1a7c52f9fbde9167ecfa09e0dbeaf752c93

commit d341a1a7c52f9fbde9167ecfa09e0dbeaf752c93
Author: Igor Sheludko <ish...@chromium.org>
Date: Tue Apr 02 14:45:42 2019

[ptr-compr][Fuchsia] Adapt V8 heap reservation for Fuchsia

... which doesn't respect address hints when reserving an address space
region and therefore makes it impossible to fulfill V8 heap alignment
requirements.

As a workaround we just overreserve address space to ensure that we
will be able to find a properly aligned 4GB subregion.

Bug: v8:7703
Change-Id: Ibf54e5e13131c2640a448944e3a3bae937c8b938
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547861
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60574}
[modify] https://crrev.com/d341a1a7c52f9fbde9167ecfa09e0dbeaf752c93/src/isolate-allocator.cc
[modify] https://crrev.com/d341a1a7c52f9fbde9167ecfa09e0dbeaf752c93/src/isolate-allocator.h

[bugdroid via monorail]

Comment #102 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c102

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/6989f0a7ea7b0286eb80d179f75e943adf649f84

commit 6989f0a7ea7b0286eb80d179f75e943adf649f84
Author: ish...@chromium.org <ish...@chromium.org>
Date: Tue Apr 02 19:16:35 2019

[ptr-compr][page_allocator] Don't adjust address space limit

... before and after huge address space reservations since the Sandbox
on Linux does not limit the address space anymore (see
https://chromium-review.googlesource.com/c/chromium/src/+/1097553/).

Bug: v8:7703
Change-Id: Ia0dca0ce9e11c884522345cf2e9d5a25cdae275c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545292
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646910}
[modify] https://crrev.com/6989f0a7ea7b0286eb80d179f75e943adf649f84/base/allocator/partition_allocator/page_allocator.cc
[modify] https://crrev.com/6989f0a7ea7b0286eb80d179f75e943adf649f84/base/allocator/partition_allocator/page_allocator_internals_posix.h

[bugdroid via monorail]

Comment #103 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c103

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/42beed975e6f6d0151098dc46afddcd784fc9b1d

commit 42beed975e6f6d0151098dc46afddcd784fc9b1d
Author: Igor Sheludko <ish...@chromium.org>
Date: Wed Apr 03 07:27:03 2019

Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64"

This is a reland of 4f051fd5da0b9b2b82ce87e762a87d4468f038ee

Relanding after fixing Chromium issues.

Original change's description:
> [ptr-compr][x64] Temporarily enable pointer compression on x64
>
> ... and make sure that the x64 ptr-compr bots proceed testing V8 without
> pointer compression in order to keep testing the full pointer mode.
>

> Bug: v8:7703
> Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel

> Change-Id: Iee725deda813425a6f0722948b54976154f50909
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139
> Reviewed-by: Michael Hablich <hab...@chromium.org>

> Reviewed-by: Michael Achenbach <mache...@chromium.org>
> Commit-Queue: Michael Achenbach <mache...@chromium.org>

> Cr-Commit-Position: refs/heads/master@{#60230}

Bug: v8:7703
Change-Id: Ic2d1c2ae41ec645f34963f5f561c33199c72ef4b
Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel
Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535819
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60582}
[modify] https://crrev.com/42beed975e6f6d0151098dc46afddcd784fc9b1d/BUILD.gn
[modify] https://crrev.com/42beed975e6f6d0151098dc46afddcd784fc9b1d/infra/mb/mb_config.pyl
[modify] https://crrev.com/42beed975e6f6d0151098dc46afddcd784fc9b1d/tools/v8heapconst.py

[bugdroid via monorail]

Comment #104 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c104

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/e26ec8bd2df7ec571b6b22b32a4d053bab2f6eef

commit e26ec8bd2df7ec571b6b22b32a4d053bab2f6eef
Author: Adithya Srinivasan <adit...@chromium.org>
Date: Wed Apr 03 20:13:12 2019

Revert "Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64""

This reverts commit 42beed975e6f6d0151098dc46afddcd784fc9b1d.

Reason for revert: This commit seems to cause consistent failures in
some ProcessMemoryMetricsEmitterTest tests on Mac and ChromeOS. I'm
not sure what the exact reasoning behind this is. See https://crbug.com/949157.

Original change's description:

> Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64"
>
> This is a reland of 4f051fd5da0b9b2b82ce87e762a87d4468f038ee
>
> Relanding after fixing Chromium issues.
>
> Original change's description:
> > [ptr-compr][x64] Temporarily enable pointer compression on x64
> >
> > ... and make sure that the x64 ptr-compr bots proceed testing V8 without
> > pointer compression in order to keep testing the full pointer mode.
> >
> > Bug: v8:7703
> > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel
> > Change-Id: Iee725deda813425a6f0722948b54976154f50909
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139
> > Reviewed-by: Michael Hablich <hab...@chromium.org>
> > Reviewed-by: Michael Achenbach <mache...@chromium.org>
> > Commit-Queue: Michael Achenbach <mache...@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#60230}
>
> Bug: v8:7703
> Change-Id: Ic2d1c2ae41ec645f34963f5f561c33199c72ef4b
> Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel
> Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535819
> Commit-Queue: Igor Sheludko <ish...@chromium.org>
> Reviewed-by: Michael Achenbach <mache...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60582}

TBR=mache...@chromium.org,hab...@chromium.org,les...@chromium.org,ish...@chromium.org,verw...@chromium.org

Change-Id: Ib9737081e90dddcfe44af9da1275a610da209323

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7703

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550709
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60618}
[modify] https://crrev.com/e26ec8bd2df7ec571b6b22b32a4d053bab2f6eef/BUILD.gn
[modify] https://crrev.com/e26ec8bd2df7ec571b6b22b32a4d053bab2f6eef/infra/mb/mb_config.pyl
[modify] https://crrev.com/e26ec8bd2df7ec571b6b22b32a4d053bab2f6eef/tools/v8heapconst.py

[bugdroid via monorail]

Comment #105 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c105

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/ba1ce315e6f4012cbebadc06d3c76d56bc4d417b

commit ba1ce315e6f4012cbebadc06d3c76d56bc4d417b
Author: ish...@chromium.org <ish...@chromium.org>
Date: Wed Apr 10 21:13:33 2019

[ptr-compr] Update expectations in ProcessMemoryMetricsEmitterTest

With enabled pointer compression empty V8 instance reports memory usage
values less than 1 MB which makes the test fail for
Memory.Experimental.Renderer2.V8.* metrics.

Bug: v8:7703, chromium:949157
Change-Id: I285731326732157b592efc197c1fda1a5016c686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559141
Reviewed-by: Erik Chen <erik...@chromium.org>
Reviewed-by: Steven Holte <ho...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649646}
[modify] https://crrev.com/ba1ce315e6f4012cbebadc06d3c76d56bc4d417b/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc

[bugdroid via monorail]

Comment #106 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c106

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/e30792857a9906626e7159c723dbf510e5697be1

commit e30792857a9906626e7159c723dbf510e5697be1
Author: Igor Sheludko <ish...@chromium.org>
Date: Thu Apr 11 12:12:23 2019

[ptr-compr][wasm] Fix handling of reference argument/return types

... when pointer compression is enabled.

Bug: v8:7581, v8:7703
Change-Id: Ie0928f813458d2ffa9159f5098c4f91bf8cee437
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564052
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Michael Starzinger <mstar...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60773}
[modify] https://crrev.com/e30792857a9906626e7159c723dbf510e5697be1/src/compiler/wasm-compiler.cc

[bugdroid via monorail]

Comment #107 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c107

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/c3597280851b09f846041df29a0e5cc4f7290201

commit c3597280851b09f846041df29a0e5cc4f7290201
Author: Igor Sheludko <ish...@chromium.org>
Date: Fri Apr 12 11:43:55 2019

[ptr-compr] Fix handling of compressed spill slots

To keep things simple, we just ensure that the spill slots always
contain full uncompressed pointers before GC sees them.

Bug: v8:8977, v8:7703
Change-Id: I54eab1b3e79e8525200139e487ff64d82ae157e5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564198
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60811}
[modify] https://crrev.com/c3597280851b09f846041df29a0e5cc4f7290201/src/compiler/code-assembler.cc
[modify] https://crrev.com/c3597280851b09f846041df29a0e5cc4f7290201/src/compiler/code-assembler.h
[modify] https://crrev.com/c3597280851b09f846041df29a0e5cc4f7290201/src/frames.cc
[modify] https://crrev.com/c3597280851b09f846041df29a0e5cc4f7290201/src/ptr-compr-inl.h
[modify] https://crrev.com/c3597280851b09f846041df29a0e5cc4f7290201/test/cctest/test-code-stub-assembler.cc

[bugdroid via monorail]

Comment #108 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c108

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/20a93efef527152d84e8d0006d0d38313cbed7dc

commit 20a93efef527152d84e8d0006d0d38313cbed7dc

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Fri Apr 12 17:34:24 2019

[Turbofan][ptr-compr] Change native context specialisation for Compressed (Any)

This CL can be used as a base for specialising CompressedSigned and
CompressedPointer.

B

Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng,v8_linux64_arm64_pointer_compression_rel_ng

Bug: v8:8977, v8:7703

Change-Id: I43c8e7f57021ac506822aba5bbd4bdf6cc3159ba
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543731

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60827}
[modify] https://crrev.com/20a93efef527152d84e8d0006d0d38313cbed7dc/src/compiler/access-info.cc
[modify] https://crrev.com/20a93efef527152d84e8d0006d0d38313cbed7dc/src/compiler/js-native-context-specialization.cc
[modify] https://crrev.com/20a93efef527152d84e8d0006d0d38313cbed7dc/src/compiler/representation-change.cc
[modify] https://crrev.com/20a93efef527152d84e8d0006d0d38313cbed7dc/src/compiler/representation-change.h
[modify] https://crrev.com/20a93efef527152d84e8d0006d0d38313cbed7dc/src/compiler/simplified-lowering.cc

[bugdroid via monorail]

Comment #109 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c109

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/1d567568f632262f3a76f98b680f60c37062c3cf

commit 1d567568f632262f3a76f98b680f60c37062c3cf

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Tue Apr 16 14:28:20 2019

[ptr-compr][csa] Loading CompressedXXX (+ Change node) instead of TaggedXXX

We translate loads with TaggedXXX (XXX in {"", "Signed", "Pointer"})
representation in CSA into loads of CompressedXXX +
ChangeCompressedXXXToTaggedXXX in the raw-machine-assembler.

This way, CSA doesn't need to know about Compressed values since we
are introducing an explicit "decompress" node.

Also updating tests that were checking for the load nodes.

Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng

Bug: v8:8977, v8:7703

Change-Id: Ie22ca8123a25ef005c1ff7383776f9355020fa42
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565897
Reviewed-by: Michael Stanton <mvst...@chromium.org>
Reviewed-by: Ross McIlroy <rmci...@chromium.org>
Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#60873}
[modify] https://crrev.com/1d567568f632262f3a76f98b680f60c37062c3cf/src/compiler/raw-machine-assembler.h
[modify] https://crrev.com/1d567568f632262f3a76f98b680f60c37062c3cf/test/unittests/compiler/node-test-utils.cc
[modify] https://crrev.com/1d567568f632262f3a76f98b680f60c37062c3cf/test/unittests/compiler/node-test-utils.h
[modify] https://crrev.com/1d567568f632262f3a76f98b680f60c37062c3cf/test/unittests/interpreter/interpreter-assembler-unittest.cc

[bugdroid via monorail]

Comment #110 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c110

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/46327dda4df5f004900488951d6f8a37a52c392c

commit 46327dda4df5f004900488951d6f8a37a52c392c

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Tue Apr 16 14:44:31 2019

[turbofan][cleanup] Avoiding the GetXXXRepresentationFor chain for kCompressed

This is a cleanup CL that stemmed from the CompressedSigned one
https://chromium-review.googlesource.com/c/v8/v8/+/1547859

Bug: v8:8977, v8:7703

Change-Id: Icd217c43cc3430579dd79387d680205ef4440962

Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569428

Auto-Submit: Santiago Aboy Solanes <sol...@chromium.org>

Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#60874}
[modify] https://crrev.com/46327dda4df5f004900488951d6f8a37a52c392c/src/compiler/representation-change.cc

[bugdroid via monorail]

Comment #111 on issue 7703 by bugdroid: Compressed pointers in V8
https://bugs.chromium.org/p/v8/issues/detail?id=7703#c111

The following revision refers to this bug:

https://chromium.googlesource.com/v8/v8.git/+/dd29683f53e95a6a311dcbf0abf8879dc7e145fe

commit dd29683f53e95a6a311dcbf0abf8879dc7e145fe

Author: Santiago Aboy Solanes <sol...@chromium.org>

Date: Wed Apr 17 11:51:45 2019

[Turbofan][ptr-compr] Change native context specialisation for CompressedSigned

This CL adds the representation changes from/to CompressedSigned to the other
data types (excluding Tagged, which was done in a previous CL).

Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng

Bug: v8:8977, v8:7703

Change-Id: If967a1a0fc669c45a2764cf950cf02d8c06b08b1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547859

Commit-Queue: Santiago Aboy Solanes <sol...@chromium.org>

Reviewed-by: Jaroslav Sevcik <ja...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60903}
[modify] https://crrev.com/dd29683f53e95a6a311dcbf0abf8879dc7e145fe/src/compiler/access-info.cc
[modify] https://crrev.com/dd29683f53e95a6a311dcbf0abf8879dc7e145fe/src/compiler/representation-change.cc
[modify] https://crrev.com/dd29683f53e95a6a311dcbf0abf8879dc7e145fe/src/compiler/simplified-lowering.cc