[wasm][jspi] Fix exception async stack traces [v8/v8 : main]

0 views

Skip to first unread message

Thibaud Michaud (Gerrit)

unread,

11:23 AM (11 hours ago) 11:23 AM

to Eric Leese, v8-re...@googlegroups.com

Attention needed from Eric Leese

Thibaud Michaud added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Thibaud Michaud . resolved

Hi Eric, thanks for pointing out the still missing error stack trace frames on the issue, I completely missed it. PTAL.

Open in Gerrit

Related details

Attention is currently required from:

Eric Leese

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Eric Leese (Gerrit)

unread,

11:50 AM (11 hours ago) 11:50 AM

to Thibaud Michaud, v8-re...@googlegroups.com

Attention needed from Thibaud Michaud

Eric Leese added 1 comment

File src/execution/isolate.cc

Line 1287, Patchset 1 (Latest): isolate->factory()->promise_handled_by_symbol();

Eric Leese . unresolved

CaptureAsyncStackTrace is supposed to work if no debugger is attached, but this symbol is only set when one is attached, so it shouldn't be relied on. Also the test shows none of the async wasm callframes. (Compare expected to crrev.com/c/5594088) Is it still possible to walk the suspended wasm stack?

Open in Gerrit

Related details

Attention is currently required from:

Thibaud Michaud

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages