[regexp] Fuse greedy character-class consume loops in the compiler [v8/v8 : main]
Jakob Linke (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Patrick Thier
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Patrick Thier added 3 comments![]( "Open in Gerrit")
Unfortunately what I was afraid of seems to be true: It is very easy to miss cases that were previously supported with simple peephole.
E.g. cases I checked that this doesn't cover correctly:
`/[a]/` -> Doesn't get optimized to `SkipUntilChar`.
`/[a]/vi` -> Gets optimized to `SkipUntilBitInTable` whereas it was previously `SkipUntilCharAnd`.
In total I tried 3 patterns and all failed.
Also while trying out these patterns: It is not obvious at a glance why the optimizations fail. Please add more tracing.
if (!compiler->one_byte()) return false;This is a regression compared to the current implementation. All of the `Skip*` ops targeted by this CL support 2-byte.
Can this be fixed?
if (el.text_type() != TextElement::CLASS_RANGES) return false;This is also a regression.
E.g. `/a+/` right now produces a `SkipUntilChar`
Related details
- Jakob Linke
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/163c0ba3c90000
Related details
- Jakob Linke
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1080b7adc90000
Related details
- Jakob Linke
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |