Update weakrefs/minor-gc-* test flags [v8/v8 : main]

0 views
Skip to first unread message

Omer Katz (Gerrit)

unread,
Oct 24, 2025, 5:52:47 AM (yesterday) Oct 24
to Michael Achenbach, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michael Achenbach

Omer Katz added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Achenbach
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88a537f5ad41bffbf235bfe30da6e965ebff3cee
Gerrit-Change-Number: 7079807
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-Attention: Michael Achenbach <mache...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Oct 2025 09:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Omer Katz (Gerrit)

unread,
Oct 24, 2025, 7:57:25 AM (yesterday) Oct 24
to Michael Achenbach, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michael Achenbach

Omer Katz voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Achenbach
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88a537f5ad41bffbf235bfe30da6e965ebff3cee
Gerrit-Change-Number: 7079807
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-Attention: Michael Achenbach <mache...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Oct 2025 11:57:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Achenbach (Gerrit)

unread,
Oct 24, 2025, 8:00:29 AM (yesterday) Oct 24
to Omer Katz, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Omer Katz

Michael Achenbach voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Omer Katz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88a537f5ad41bffbf235bfe30da6e965ebff3cee
Gerrit-Change-Number: 7079807
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-Attention: Omer Katz <omer...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Oct 2025 12:00:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Oct 24, 2025, 8:01:54 AM (yesterday) Oct 24
to Omer Katz, Michael Achenbach, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
Update weakrefs/minor-gc-* test flags

Update the tests to require `--no-minor-ms` and
`--no-scavenger-chaos-mode`. This will tell the NumFuzz flag fuzzer that
test failures with --minor-ms or --scavenger-chaos-mode are expected.
Bug: 340777103
Change-Id: I88a537f5ad41bffbf235bfe30da6e965ebff3cee
Auto-Submit: Omer Katz <omer...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103337}
Files:
  • M test/mjsunit/weakrefs/minor-gc-cleanup-from-different-realm.js
  • M test/mjsunit/weakrefs/minor-gc-cleanup-is-not-a-microtask.js
  • M test/mjsunit/weakrefs/minor-gc-cleanup-on-detached-realm.js
  • M test/mjsunit/weakrefs/minor-gc-cleanup-proxy-from-different-realm.js
  • M test/mjsunit/weakrefs/minor-gc-cleanup.js
  • M test/mjsunit/weakrefs/minor-gc-dirty-finalization-registry-two-gcs.js
  • M test/mjsunit/weakrefs/minor-gc-finalizationregistry-and-weakref.js
  • M test/mjsunit/weakrefs/minor-gc-finalizationregistry-independent-lifetime-multiple.js
  • M test/mjsunit/weakrefs/minor-gc-finalizationregistry-independent-lifetime.js
  • M test/mjsunit/weakrefs/minor-gc-finalizationregistry-keeps-holdings-alive.js
  • M test/mjsunit/weakrefs/minor-gc-finalizationregistry-old-to-new-dirty.js
  • M test/mjsunit/weakrefs/minor-gc-finalizationregistry-scheduled-for-cleanup-multiple-times.js
  • M test/mjsunit/weakrefs/minor-gc-multiple-dirty-finalization-groups.js
  • M test/mjsunit/weakrefs/minor-gc-reclaims-unreachable-weak-cell-target.js
  • M test/mjsunit/weakrefs/minor-gc-reclaims-unreachable-weakref-target.js
  • M test/mjsunit/weakrefs/minor-gc-reentrant-gc-from-cleanup.js
  • M test/mjsunit/weakrefs/minor-gc-two-weakrefs.js
  • M test/mjsunit/weakrefs/minor-gc-undefined-holdings.js
  • M test/mjsunit/weakrefs/minor-gc-unregister-after-cleanup.js
  • M test/mjsunit/weakrefs/minor-gc-unregister-before-cleanup.js
  • M test/mjsunit/weakrefs/minor-gc-unregister-called-twice.js
  • M test/mjsunit/weakrefs/minor-gc-unregister-inside-cleanup.js
  • M test/mjsunit/weakrefs/minor-gc-unregister-inside-cleanup2.js
  • M test/mjsunit/weakrefs/minor-gc-unregister-inside-cleanup3.js
  • M test/mjsunit/weakrefs/minor-gc-unregister-many.js
  • M test/mjsunit/weakrefs/minor-gc-unregister-when-cleanup-already-scheduled.js
  • M test/mjsunit/weakrefs/minor-gc-weak-cell-basics.js
  • M test/mjsunit/weakrefs/minor-gc-weak-unregistertoken.js
  • M test/mjsunit/weakrefs/minor-gc-weakref-creation-keeps-alive.js
  • M test/mjsunit/weakrefs/minor-gc-weakref-deref-keeps-alive.js
Change size: M
Delta: 30 files changed, 30 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Achenbach
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88a537f5ad41bffbf235bfe30da6e965ebff3cee
Gerrit-Change-Number: 7079807
Gerrit-PatchSet: 2
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages