[intl] Implement Intl.NumberFormat V3 [v8/v8 : main]

Frank Tang (Gerrit)

unread,

Dec 28, 2021, 7:54:10 PM12/28/21

to Shu-yu Guo, Shane Carr, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Shu-yu Guo, Shane Carr.

View Change

1 comment:

File src/objects/js-number-format.cc:
- Patch Set #31, Line 832: }
  Shane- could you comment on the code below?
  Done

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Shane Carr (Gerrit)

unread,

Dec 29, 2021, 2:12:08 AM12/29/21

to Frank Tang, Shu-yu Guo, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Frank Tang, Shu-yu Guo.

View Change

6 comments:

Patchset:
- Patch Set #44:
  I left comments on the ICU bindings and tests.
File src/objects/js-number-format.cc:
- Patch Set #44, Line 652: "#r "
  Is it okay if this occurs at the end of the whole skeleton string? (You should except EOF as well as space)
- Patch Set #44, Line 664: "/w"
  Issue: "/w" is mostly likely too sensitive; it could hit things that are not related to trailingZeroDisplay
File src/objects/objects.cc:
- Patch Set #44, Line 348: IsBigInt
  Hmm? BigInt is convertible to Intl Mathematical Value.
File test/intl/number-format/format-range-v3.js:
- Patch Set #44, Line 36: RangeError
  Note: I think this line and the following line (and below) throw RangeError because of NaN, not because of ToNumeric
File test/intl/number-format/rounding-increment-value-v3.js:
- Patch Set #44, Line 8: minimumFractionDigits
  Is this statement correct: you are setting minimumFractionDigits == maximumFractionDigits as a minimal test while you wait for the resolution to https://github.com/tc39/proposal-intl-numberformat-v3/issues/81 ?

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Frank Tang (Gerrit)

unread,

Dec 29, 2021, 7:38:07 PM12/29/21

to Shu-yu Guo, Shane Carr, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Shu-yu Guo, Shane Carr.

View Change

5 comments:

Patchset:
- Patch Set #44:
  PTAL
File src/objects/js-number-format.cc:
- Patch Set #44, Line 664: "/w"
  Issue: "/w" is mostly likely too sensitive; it could hit things that are not related to trailingZero […]
  so how should I decide a pattern is trailingZeroDisplay if searching "/w" is too sensitive? what other setting may causing the emit of "/w" as substring now?
File src/objects/objects.cc:

- Patch Set #44, Line 348: IsBigInt
  Hmm? BigInt is convertible to Intl Mathematical Value.

- Done
File test/intl/number-format/format-range-v3.js:

- Patch Set #44, Line 36: RangeError

- Note: I think this line and the following line (and below) throw RangeError because of NaN, not beca […]
  Done
File test/intl/number-format/rounding-increment-value-v3.js:

- Patch Set #44, Line 8: minimumFractionDigits

- Is this statement correct: you are setting minimumFractionDigits == maximumFractionDigits as a minim […]
  I wrote that long time ago. I do not think that is the reason I put it there but I forgot why.

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Frank Tang (Gerrit)

unread,

Dec 29, 2021, 7:38:33 PM12/29/21

to Shu-yu Guo, Shane Carr, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Shu-yu Guo, Shane Carr.

View Change

1 comment:

File src/objects/js-number-format.cc:
- Patch Set #44, Line 652: "#r "
  Is it okay if this occurs at the end of the whole skeleton string? (You should except EOF as well a […]
  Done

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Shane Carr (Gerrit)

unread,

Jan 9, 2022, 4:55:10 AM1/9/22

to Frank Tang, Shu-yu Guo, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Frank Tang, Shu-yu Guo.

View Change

1 comment:

File src/objects/js-number-format.cc:
- Patch Set #44, Line 664: "/w"
  so how should I decide a pattern is trailingZeroDisplay if searching "/w" is too sensitive? what oth […]
  Checking that it is followed by a space or EOF is sufficient I believe, which your latest changeset resolves.

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Shu-yu Guo (Gerrit)

unread,

Jan 20, 2022, 8:24:26 PM1/20/22

to Frank Tang, Shane Carr, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Frank Tang.

View Change

1 comment:

Patchset:
- Patch Set #45:
  I'm having trouble reviewing CLs of this size.
  I see on the spec repo there are 4 different spec drafts. Is it also possible to split this CL into 4 smaller CLs, dealing with each of those sections?

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Shu-yu Guo (Gerrit)

unread,

Jan 20, 2022, 8:41:25 PM1/20/22

to Frank Tang, Shane Carr, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Frank Tang.

View Change

1 comment:

Patchset:
- Patch Set #45:
  I'm having trouble reviewing CLs of this size. […]
  Another possibility is to break it by feature as laid out on the explainer.
  Basically anything that helps me make progress incrementally. 😊

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Frank Tang (Gerrit)

unread,

Jan 21, 2022, 12:27:34 AM1/21/22

to Shu-yu Guo, Shane Carr, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Shu-yu Guo, Shane Carr.

View Change

1 comment:

Patchset:
- Patch Set #45:
  Another possibility is to break it by feature as laid out on the explainer. […]
  ok, let me try

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Frank Tang (Gerrit)

unread,

Feb 19, 2022, 5:09:35 AM2/19/22

to Shu-yu Guo, Shane Carr, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Patch set 49:Code-Review +1

View Change

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Frank Tang (Gerrit)

unread,

Jun 14, 2022, 3:04:59 PM6/14/22

to Shu-yu Guo, Shane Carr, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Frank Tang.

Frank Tang removed a vote from this change.

View Change

Removed Code-Review+1 by Frank Tang <ft...@chromium.org>

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Frank Tang (Gerrit)

unread,

Jun 14, 2022, 4:24:43 PM6/14/22

to Shu-yu Guo, Shane Carr, V8 LUCI CQ, Michael Hablich, v8-re...@googlegroups.com

Frank Tang abandoned this change.

View Change

Abandoned

obsoleted

To view, visit change 2336146. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward