Re: CVV8 Aligned Pointer Reference

[Stephan Beal]

On Tue, Dec 18, 2012 at 10:45 AM, Bionic Badger <bionic...@gmail.com> wrote:

According to this:

https://code.google.com/p/v8/source/detail?r=12849&path=/branches/bleeding_edge/include/v8.h

Hi, Badger! My apologies for the delayed response - poor health/exhaustion has kept me mostly offline since July and i'm just now getting around to reading emails.

Google has deprecated the following two functions:

Object::SetPointerInInternalField

Object::GetPointerInInternalField

...In CVV8, this change affects the following files:

ClassCreator.hpp 

detail/convert_core.hpp 

The syntax is exactly the same; so it is probably a drop-in replacement.  

I applied the changes to my copy.  The demo compiled fine and I think the messages from it are correct.  However, I'm not really familiar with the demo's expected output (it doesn't just say PASS like a regression test), so you might want to check yourself.

THANK YOU for the warning! Please feel free to commit the change and i'll be happy to confirm that it meets the test's expectations. (i _really_ should write proper unit tests :/) i wouldn't be surprised if there other incompatible v8 changes have been made the past few months, and i'll try to get some energy to confirm that everything still compiles against the v8 trunk.

--
----- stephan beal
http://wanderinghorse.net/home/stephan/

http://gplus.to/sgbeal