Issue 32 in v8-juice: Compiler error.

[v8-j...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 32 by nicokrui...@gmail.com: Compiler error.
http://code.google.com/p/v8-juice/issues/detail?id=32

In my application I have a class called Value in the global namespace,
which makes the compiler complain about the ClassCreator. The method
ctor_proxy contains:

using namespace v8;

and then uses Value, which normally would be v8::Value, but now results in
my global ::Value.

Could you apply the changes in the attached file?



Attachments:
ClassCreator.hpp 51.1 KB

[v8-j...@googlecode.com]

Comment #2 on issue 32 by sgb...@gmail.com: Compiler error.
http://code.google.com/p/v8-juice/issues/detail?id=32

I will fix this but i am not happy about it lbecause it means my library
has to fully-qualify the names due to a collision in your code. This is
proabably not the onlg place where i use "using".

[v8-j...@googlecode.com]

Updates:
Status: Accepted
Owner: sgb...@gmail.com

Comment #1 on issue 32 by sgb...@gmail.com: Compiler error.

[v8-j...@googlecode.com]

Updates:
Labels: Component-ClassBinding

Comment #3 on issue 32 by sgb...@gmail.com: Compiler error.
http://code.google.com/p/v8-juice/issues/detail?id=32

(No comment was entered for this change.)

[v8-j...@googlecode.com]

Comment #4 on issue 32 by nicokrui...@gmail.com: Compiler error.
http://code.google.com/p/v8-juice/issues/detail?id=32

Thanks for fixing this issue. I'll see whether there is a cleaner solution
that works for me as well.

[v8-j...@googlecode.com]

Comment #5 on issue 32 by sgb...@gmail.com: Compiler error.
http://code.google.com/p/v8-juice/issues/detail?id=32

i unfortunately won't have access to my dev machine until Friday night, but
will get this committed over the weekend. If you do not hear back from me
(via this ticket) by Saturday, please post a comment here and i'll see the
reminder.

[v8-j...@googlecode.com]

Comment #6 on issue 32 by sgb...@gmail.com: Compiler error.
http://code.google.com/p/v8-juice/issues/detail?id=32

i've thought this through some more and my initial reaction was wrong -
cvv8 should not use 'using' at all. i did not foresee this particular
problem at the time, but it is a real issue and will be fixed. i only have
my dev machine on the weekends, so it will have to wait until Friday or
Saturday, but i'll get this done soon.

Thanks for the bug report (and for nailing down the exact problem - it
would have taken me a long time to figure it out, probably!), and Happy
Hacking!

[v8-j...@googlecode.com]

Comment #7 on issue 32 by nicokrui...@gmail.com: Compiler error.
http://code.google.com/p/v8-juice/issues/detail?id=32

Thanks for the fast response and fix.

Happy coding to you too,
Nico

Sent from my iPad

On 18 jul. 2012, at 17:45, "v8-j...@googlecode.com"
<v8-j...@googlecode.com> wrote:

[v8-j...@googlecode.com]

Updates:
Status: Fixed

Comment #8 on issue 32 by sgb...@gmail.com: Compiler error.
http://code.google.com/p/v8-juice/issues/detail?id=32

This issue was closed by revision r2257.