[v8] r11212 committed - Adding missing SetCC before conditional branch....

0 views
Skip to first unread message

codesite...@google.com

unread,
Apr 2, 2012, 11:57:17 AM4/2/12
to v8-...@googlegroups.com
Revision: 11212
Author: da...@chromium.org
Date: Mon Apr 2 08:53:38 2012
Log: Adding missing SetCC before conditional branch.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9950015
Patch from Rodolph Perfetta <rodolph....@gmail.com>.
http://code.google.com/p/v8/source/detail?r=11212

Modified:
/branches/bleeding_edge/src/arm/full-codegen-arm.cc

=======================================
--- /branches/bleeding_edge/src/arm/full-codegen-arm.cc Tue Mar 27 04:21:27
2012
+++ /branches/bleeding_edge/src/arm/full-codegen-arm.cc Mon Apr 2 08:53:38
2012
@@ -3653,7 +3653,7 @@
__ ldrb(scratch1, FieldMemOperand(scratch1, Map::kInstanceTypeOffset));
__ JumpIfInstanceTypeIsNotSequentialAscii(scratch1, scratch2, &bailout);
__ ldr(scratch1, FieldMemOperand(string, SeqAsciiString::kLengthOffset));
- __ add(string_length, string_length, Operand(scratch1));
+ __ add(string_length, string_length, Operand(scratch1), SetCC);
__ b(vs, &bailout);
__ cmp(element, elements_end);
__ b(lt, &loop);
@@ -3690,7 +3690,7 @@
__ b(ne, &bailout);
__ tst(scratch2, Operand(0x80000000));
__ b(ne, &bailout);
- __ add(string_length, string_length, Operand(scratch2));
+ __ add(string_length, string_length, Operand(scratch2), SetCC);
__ b(vs, &bailout);
__ SmiUntag(string_length);

Reply all
Reply to author
Forward
0 new messages