Fix for BUILD.gn

14 views
Skip to first unread message

Paul Harris

unread,
Jul 19, 2022, 9:58:38 PM7/19/22
to v8-dev
Please see post here:

I notice that v8_heap_base_headers is a header-only target in BUILD.gn,
but it is defined as "v8_source_set()" which ends up as a lib.

It works if you change the line in BUILD.gn:
v8_source_set("v8_heap_base_headers") {
to
v8_header_set("v8_heap_base_headers") {

In this case, this is for MSVC2022.
I guess it works on other platforms as they are able to build an empty .a library file,
but MS's lib.exe doesn't generate .lib files if there are no source inputs.

So then the link call fails as one of the .lib inputs is missing.

cheers,
Paul

Reply all
Reply to author
Forward
0 new messages