Deprecate the version of MakeWeak which takes an Isolate. (issue 16528009)

3 views
Skip to first unread message

ma...@chromium.org

unread,
Jun 12, 2013, 7:36:08 AM6/12/13
to dca...@chromium.org, sven...@chromium.org, v8-...@googlegroups.com
Reviewers: dcarney, Sven Panne,

Message:
dcarney, svenpanne, ptal

Description:
Deprecate the version of MakeWeak which takes an Isolate.

BUG=NONE

Please review this at https://codereview.chromium.org/16528009/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M include/v8.h
M src/d8.cc
M src/runtime.cc
M test/cctest/test-api.cc
M test/cctest/test-heap-profiler.cc


sven...@chromium.org

unread,
Jun 12, 2013, 7:50:40 AM6/12/13
to ma...@chromium.org, dca...@chromium.org, v8-...@googlegroups.com
lgtm



https://codereview.chromium.org/16528009/

dca...@chromium.org

unread,
Jun 13, 2013, 3:23:31 AM6/13/13
to ma...@chromium.org, sven...@chromium.org, v8-...@googlegroups.com
Committed patchset #3 manually as r15105 (presubmit successful).

https://codereview.chromium.org/16528009/
Reply all
Reply to author
Forward
0 new messages