Issue 1804 in v8: GDBJIT: gdbjit cannot be enabled since NewGC landed

[codesite...@google.com]

Status: New
Owner: ----

New issue 1804 by kalm...@homejinni.com: GDBJIT: gdbjit cannot be enabled
since NewGC landed
http://code.google.com/p/v8/issues/detail?id=1804

Compiling with gdbjit=on (on any architecture) fails at two points.
First:

src/gdb-jit.cc:1130: error: 'JavaScriptFrameConstants' has not been declared
src/gdb-jit.cc:1178: error: 'JavaScriptFrameConstants' has not been declared
src/gdb-jit.cc:1190: error: 'JavaScriptFrameConstants' has not been declared
src/gdb-jit.cc:1201: error: 'StandardFrameConstants' has not been declared

This can be fixed by including frames-inl.h in gdb-jit.cc.

Second:
src/mark-compact.cc:471: error: 'compacting_collection_' was not declared
in this scope
This seems like leftover code from the old GC system, but I assume
something like this (disabled compacting) should be ported to NewGC.

[codesite...@google.com]

Updates:
Status: Accepted
Owner: mstar...@chromium.org
Cc: veg...@chromium.org
Labels: Priority-Medium NewGC

Comment #1 on issue 1804 by mstar...@chromium.org: GDBJIT: gdbjit cannot

be enabled since NewGC landed
http://code.google.com/p/v8/issues/detail?id=1804

The GDB JIT interface is a nice thing to have. Unfortunately we do not emit
code deletion notifications at the moment which GDB might require. We might
be lucky for the non-code-compacting mode, but once code-compaction is
enabled, GDB JIT is definitely broken.

I'll take this one and talk to Slava about how we could solve this.

[codesite...@google.com]

Updates:
Labels: -Priority-Medium Priority-Low

Comment #2 on issue 1804 by mstar...@chromium.org: GDBJIT: gdbjit cannot

be enabled since NewGC landed
http://code.google.com/p/v8/issues/detail?id=1804

When a get a round TUIT.

[codesite...@google.com]

Comment #3 on issue 1804 by yan...@chromium.org: GDBJIT: gdbjit cannot be

enabled since NewGC landed
http://code.google.com/p/v8/issues/detail?id=1804

Issue 1999 has been merged into this issue.

[codesite...@google.com]

Comment #4 on issue 1804 by yan...@chromium.org: GDBJIT: gdbjit cannot be

enabled since NewGC landed
http://code.google.com/p/v8/issues/detail?id=1804

Issue 2352 has been merged into this issue.

[codesite...@google.com]

Comment #5 on issue 1804 by yan...@chromium.org: GDBJIT: gdbjit cannot be

enabled since NewGC landed
http://code.google.com/p/v8/issues/detail?id=1804

Issue 2350 has been merged into this issue.

[codesite...@google.com]

Comment #6 on issue 1804 by JamesMi...@gmail.com: GDBJIT: gdbjit

cannot be enabled since NewGC landed
http://code.google.com/p/v8/issues/detail?id=1804

I have stubbed out the code so that it does compile but does not do
anything : https://github.com/h4ck3rm1k3/node

[codesite...@google.com]

Comment #7 on issue 1804 by mstar...@chromium.org: GDBJIT: gdbjit cannot

be enabled since NewGC landed
http://code.google.com/p/v8/issues/detail?id=1804

Fixed in r12679. Compilation fixed and smoke-tested functionality. We
thought about enabling GDBJIT in debug mode (the compile flag not the
runtime flag) to avoid future breakage, so I'll keep this issue open to
track that.

[codesite...@google.com]

Updates:
Status: Fixed

Comment #8 on issue 1804 by mstar...@chromium.org: GDBJIT: gdbjit cannot

be enabled since NewGC landed
http://code.google.com/p/v8/issues/detail?id=1804

Enabled compilation on Linux in r12685.