Issue 2380 in v8: snapshot build crashing when compiling C++ code to Thumb.

6 views
Skip to first unread message

codesite...@google.com

unread,
Oct 26, 2012, 9:35:33 AM10/26/12
to v8-...@googlegroups.com
Status: New
Owner: ----

New issue 2380 by rodolph....@gmail.com: snapshot build crashing when
compiling C++ code to Thumb.
http://code.google.com/p/v8/issues/detail?id=2380

in revision 12755 (Use movw/movt instead of constant pool on ARMv7) the
methods Assembler::target_address_at and Assembler::set_target_address_at
in assembler-arm-inl.h will clear the bottom two bits. According to the
comments it was put in as a "JIT hardening" measure to prevent switching
tho Thumb mode. While the JIT never emits Thumb code, the C++ code could be
compiled for Thumb. If this is the case then V8 with snapshots will crash
because the serializer will use the aforementioned methods when generating
the snapshots and any ExternalReference to C++ Thumb functions will have
its bottom bits cleared making it look like ARM code ...




codesite...@google.com

unread,
Oct 30, 2012, 4:44:55 AM10/30/12
to v8-...@googlegroups.com
Updates:
Status: Fixed
Owner: da...@chromium.org

Comment #1 on issue 2380 by da...@chromium.org: snapshot build crashing
when compiling C++ code to Thumb.
http://code.google.com/p/v8/issues/detail?id=2380

Fixed in r12832

Reply all
Reply to author
Forward
0 new messages