PSA: Change Builtins::Name to Builtin enum class

13 views
Skip to first unread message

Camillo Bruni

unread,
May 31, 2021, 4:17:59 AM5/31/21
to v8-dev
Background: 
- We currently have a mix of passing builtin ids as int or Builtins::Name enums in various places.
- Additionally we sometimes pass code-handles to builtins in the macro assembler

Goal: 
Clean up the existing code to only use the new Builtin enum class and avoid creating handles to builtins altogether in the macro-assembler.

Code Impact: largish
- Mechanical renaming is required in various codegen related places

Programmer Impact: minimal
- Just use Builtin:kXXX instead of Builtins:kXXX
- All static methods will keep on living in Bultins and not in Builtin

Cheers,
Camillo

Camillo Bruni | Software Engineer, V8 | Google Germany GmbH | Erika-Mann Str. 33, 80636 München 

Registergericht und -nummer: Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg | Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Diese E-Mail ist vertraulich. Falls Sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.  This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.
Reply all
Reply to author
Forward
0 new messages