Decouple allocation and creation of deopt tables (issue 11275145)

[da...@chromium.org]

Reviewers: Jakob,

Message:
PTAL

Description:
Decouple allocation and creation of deopt tables

This makes it possible to calculate the future address of a deopt entry
before
it is possible to generate the deopt table.

Please review this at http://codereview.chromium.org/11275145/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/api.cc
M src/deoptimizer.h
M src/deoptimizer.cc

[jkum...@chromium.org]

LGTM with nits.


http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode58
src/deoptimizer.cc:58: if (eager_deoptimization_entry_code_ != NULL) {
nit: you can simplify this a bit by removing the condition. |delete| is
safe to call on NULL pointers.

Again below.

http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode108
src/deoptimizer.cc:108: static const int kDeoptTableMaxEpilogueCodeSize
= 2 * 1024;
nit: 2 * KB

http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode478
src/deoptimizer.cc:478: Address Deoptimizer::GetDeoptimizationEntry(int
id, BailoutType type,
nit: one line per argument

http://codereview.chromium.org/11275145/

[da...@chromium.org]

Feedback addressed, I will land this after verifying there's not performance
regression.

http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode58
src/deoptimizer.cc:58: if (eager_deoptimization_entry_code_ != NULL) {

On 2012/11/06 11:40:50, Jakob wrote:
> nit: you can simplify this a bit by removing the condition. |delete|
is safe to
> call on NULL pointers.

> Again below.

Done.

http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode478
src/deoptimizer.cc:478: Address Deoptimizer::GetDeoptimizationEntry(int
id, BailoutType type,

On 2012/11/06 11:40:50, Jakob wrote:
> nit: one line per argument

Done.

http://codereview.chromium.org/11275145/