Adding `OutputStream` support to `CpuProfile`

[Juan José]

Hi! I want to work on adding support to CPU profile serialization via OutputStream as the heap snapshot does.

I was considering doing something like adding a new method to the CpuProfile class, it `serialize(outputStream, kJSON),` and re-using the "inspector" parser logic (to make it compatible with dev tools). 

Do you consider it worth creating a bug and start working on it? Should I get in contact with someone for pretty little beginner guidance?

Regards,

-Juan José Arboleda

[Camillo Bruni]

On Wed, 14 Sept 2022 at 23:09, Juan José <soyjua...@gmail.com> wrote:

Hi! I want to work on adding support to CPU profile serialization via OutputStream as the heap snapshot does.

That sounds reasonable to me :)

 

I was considering doing something like adding a new method to the CpuProfile class, it `serialize(outputStream, kJSON),` and re-using the "inspector" parser logic (to make it compatible with dev tools). 

Could you explain a bit more what you mean by "inspector parser logic"?

 

Do you consider it worth creating a bug and start working on it? Should I get in contact with someone for pretty little beginner guidance?

Maybe opening a bug to explain your use-case a bit better might make sense.

 

Regards,

-Juan José Arboleda

--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/69abc07b-8122-4641-800e-dd554e647736n%40googlegroups.com.

Camillo Bruni |

Software Engineer, V8 |

Google Germany GmbH |

Erika-Mann Str. 33, 80636 München

Registergericht und -nummer: Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg | Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Diese E-Mail ist vertraulich. Falls Ssie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.  This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.

[Juan José]

Thanks for taking the time to read!

I have opened a bug, https://bugs.chromium.org/p/v8/issues/detail?id=13291; I would like to have your opinions and ideas there.

Regards,

-Juan José Arboleda