Re: Issue 2166 in v8: Nested v8::TryCatch blocks don't rethrow properly

[codesite...@google.com]

Updates:
Cc: rossb...@chromium.org

Comment #1 on issue 2166 by rossb...@chromium.org: Nested v8::TryCatch
blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

(No comment was entered for this change.)

[codesite...@google.com]

Comment #2 on issue 2166 by mstar...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

Fixed in r11834.

[codesite...@google.com]

Updates:
Status: Fixed

Comment #3 on issue 2166 by mstar...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

[codesite...@google.com]

Updates:
Status: Assigned

Comment #4 on issue 2166 by mstar...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

Reverted in r11892 due to Chromium unit test failures. Issue reopened.

[codesite...@google.com]

Updates:
Owner: yan...@chromium.org

Comment #5 on issue 2166 by yan...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

[codesite...@google.com]

Comment #6 on issue 2166 by phi...@gmail.com: Nested v8::TryCatch blocks

don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

I think I just hit this problem in our own code. Is a fix for this still
planned (in the near future), or should I look for a workaround?

[codesite...@google.com]

Comment #7 on issue 2166 by yan...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

Apparently there are wrong usages of TryCatch in Chromium. TryCatch needs
to be stack allocated (not heap allocated with 'new'). Before those are
fixed, we can't land an existing fix to this issue.

[codesite...@google.com]

Comment #8 on issue 2166 by jsb...@chromium.org: Nested v8::TryCatch blocks

don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

Is there a Chromium or WebKit bug tracking those heap allocations?

[codesite...@google.com]

Comment #9 on issue 2166 by hara...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

Not yet probably.

Michael: would you file a bug for Chromium? (I don't know the place where
the TryCatch heap allocations are happening.)

[codesite...@google.com]

Updates:
Blockedon: chromium:152389

Comment #10 on issue 2166 by mstar...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

Done. https://code.google.com/p/chromium/issues/detail?id=152389

[codesite...@google.com]

Comment #11 on issue 2166 by phi...@gmail.com: Nested v8::TryCatch blocks

don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

Thanks for pursuing this problem!

[codesite...@google.com]

Comment #12 on issue 2166 by e...@dubbelboer.com: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

I have tested the code in r11834. It does work but the rethrow messes up
the file and linenumer of the error.

I'm hoping this gets fixed soon as it is really annoying to work around.

[codesite...@google.com]

Updates:
Owner: mstar...@chromium.org
Cc: yan...@chromium.org

Comment #13 on issue 2166 by mstar...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

The upstream Chromium change is being worked on. I'll reland the fix as
soon as it's done. It's on my radar.

[codesite...@google.com]

Comment #14 on issue 2166 by hara...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

The Chromium change was landed:
http://src.chromium.org/viewvc/chrome?view=rev&revision=170898

[codesite...@google.com]

Updates:
Status: Fixed
Cc: k...@chromium.org

Comment #15 on issue 2166 by mstar...@chromium.org: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

Fixed (again) in r13129 and r13130. Kudos go to koz@ for handling the
upstream issue.

[codesite...@google.com]

Comment #16 on issue 2166 by yihongw...@gmail.com: Nested v8::TryCatch

blocks don't rethrow properly
http://code.google.com/p/v8/issues/detail?id=2166

I am not able to run test-api/TryCatchNested twice within an v8::Isolate.
is this a expected behavior?

like this:
cctest test-api/TryCatchNested test-api/TryCatchNested

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings