Introduce helper functions to test parallel recompilation. (issue 11419012)

1 view
Skip to first unread message

yan...@chromium.org

unread,
Nov 15, 2012, 11:41:25 AM11/15/12
to jkum...@chromium.org, v8-...@googlegroups.com
Reviewers: Jakob,

Message:
PTAL.

Description:
Introduce helper functions to test parallel recompilation.


BUG=


Please review this at http://codereview.chromium.org/11419012/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/execution.cc
M src/flag-definitions.h
M src/optimizing-compiler-thread.h
M src/optimizing-compiler-thread.cc
M src/runtime-profiler.cc
M src/runtime.h
M src/runtime.cc
A + test/mjsunit/manual-parallel-recompile.js


jkum...@chromium.org

unread,
Nov 16, 2012, 5:34:01 AM11/16/12
to yan...@chromium.org, v8-...@googlegroups.com
lgtm




http://codereview.chromium.org/11419012/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/11419012/diff/1/src/runtime.cc#newcode8002
src/runtime.cc:8002: "Recompile queue is full."));
nit: I'd prefer to break the line after "Throw("

http://codereview.chromium.org/11419012/
Reply all
Reply to author
Forward
0 new messages