Fix compilation failure on ARM in r12685. (issue 11103004)

3 views
Skip to first unread message

mstar...@chromium.org

unread,
Oct 10, 2012, 7:55:36 AM10/10/12
to jkum...@chromium.org, v8-...@googlegroups.com
Reviewers: Jakob,

Description:
Fix compilation failure on ARM in r12685.

R=jkum...@chromium.org


Please review this at https://codereview.chromium.org/11103004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/gdb-jit.cc


Index: src/gdb-jit.cc
diff --git a/src/gdb-jit.cc b/src/gdb-jit.cc
index
74845b4822c659b1c4b810fc7862df1283f1fe7b..ecf645dcb2280ee6db6e50a12f333e52fac70ff1
100644
--- a/src/gdb-jit.cc
+++ b/src/gdb-jit.cc
@@ -677,7 +677,7 @@ class ELF BASE_EMBEDDED {
{ 0x7f, 'E', 'L', 'F', 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0};
#elif defined(V8_TARGET_ARCH_X64)
const uint8_t ident[16] =
- { 0x7f, 'E', 'L', 'F', 2, 1, 1, 0, 0, 0 , 0, 0, 0, 0, 0, 0};
+ { 0x7f, 'E', 'L', 'F', 2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0};
#else
#error Unsupported target architecture.
#endif
@@ -1110,6 +1110,8 @@ class DebugInfoSection : public DebugSection {
w->Write<uint8_t>(DW_OP_reg5); // The frame pointer's here on ia32
#elif defined(V8_TARGET_ARCH_X64)
w->Write<uint8_t>(DW_OP_reg6); // and here on x64.
+#elif defined(V8_TARGET_ARCH_ARM)
+ UNIMPLEMENTED();
#else
#error Unsupported target architecture.
#endif


jkum...@chromium.org

unread,
Oct 10, 2012, 7:56:35 AM10/10/12
to mstar...@chromium.org, v8-...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages