Re: Lattice-based representation inference, powered by left/right specific type feedback for BinaryOps … (issue 10837165)

4 views
Skip to first unread message

da...@chromium.org

unread,
Nov 14, 2012, 5:38:22 AM11/14/12
to jkum...@chromium.org, kmil...@chromium.org, v8-...@googlegroups.com
lgtm with nits


http://codereview.chromium.org/10837165/diff/30002/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/10837165/diff/30002/src/hydrogen-instructions.h#newcode1335
src/hydrogen-instructions.h:1335: REMOVABLE,
make this REMOVABLE_SIMULATE?

http://codereview.chromium.org/10837165/diff/33002/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

http://codereview.chromium.org/10837165/diff/33002/src/hydrogen-instructions.cc#newcode2632
src/hydrogen-instructions.cc:2632: Representation
HPhi::AllNonPhiUsesObserved() {
Add comment with what you described during the code review

http://codereview.chromium.org/10837165/diff/33002/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/10837165/diff/33002/src/ic.cc#newcode2429
src/ic.cc:2429: if (old_type == BinaryOpIC::UNINITIALIZED) return
new_type;
remove above?

http://codereview.chromium.org/10837165/

jkum...@chromium.org

unread,
Nov 14, 2012, 10:53:23 AM11/14/12
to kmil...@chromium.org, da...@chromium.org, v8-...@googlegroups.com

https://chromiumcodereview.appspot.com/10837165/diff/30002/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://chromiumcodereview.appspot.com/10837165/diff/30002/src/hydrogen-instructions.h#newcode1335
src/hydrogen-instructions.h:1335: REMOVABLE,
On 2012/11/14 10:38:22, danno wrote:
> make this REMOVABLE_SIMULATE?

Done.

https://chromiumcodereview.appspot.com/10837165/diff/33002/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://chromiumcodereview.appspot.com/10837165/diff/33002/src/hydrogen-instructions.cc#newcode2632
src/hydrogen-instructions.cc:2632: Representation
HPhi::AllNonPhiUsesObserved() {
On 2012/11/14 10:38:22, danno wrote:
> Add comment with what you described during the code review

Done.

https://chromiumcodereview.appspot.com/10837165/diff/33002/src/ic.cc
File src/ic.cc (right):

https://chromiumcodereview.appspot.com/10837165/diff/33002/src/ic.cc#newcode2429
src/ic.cc:2429: if (old_type == BinaryOpIC::UNINITIALIZED) return
new_type;
On 2012/11/14 10:38:22, danno wrote:
> remove above?

Done.

https://chromiumcodereview.appspot.com/10837165/
Reply all
Reply to author
Forward
0 new messages