[turbofan] Mark arm64 cbz/cbnz tbz/tbnz instructions as branch instructions. (issue 798553002 by baptiste.afsa@arm.com)

120 views
Skip to first unread message

baptis...@arm.com

unread,
Dec 11, 2014, 6:56:12 AM12/11/14
to bme...@chromium.org, v8-...@googlegroups.com
Reviewers: Benedikt Meurer,

Message:
PTAL

It improves performance on asm.js life and skinning benchmarks.


Description:
[turbofan] Mark arm64 cbz/cbnz tbz/tbnz instructions as branch instructions.

The instruction selector now selects pseudo instructions: CompareAndBranch
or
TestAndBranch which are associated with their continuations so that generic
code in the code generator will treat them as branch instruction and will be
able to apply optimization like avoiding branches when the code can
falltrhough.

R=bme...@chromium.org

Please review this at https://codereview.chromium.org/798553002/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+127, -109 lines):
M src/compiler/arm64/code-generator-arm64.cc
M src/compiler/arm64/instruction-codes-arm64.h
M src/compiler/arm64/instruction-selector-arm64.cc
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc


bme...@chromium.org

unread,
Dec 11, 2014, 7:08:30 AM12/11/14
to baptis...@arm.com, v8-...@googlegroups.com

commi...@chromium.org

unread,
Dec 11, 2014, 7:09:33 AM12/11/14
to baptis...@arm.com, bme...@chromium.org, v8-...@googlegroups.com

commi...@chromium.org

unread,
Dec 11, 2014, 7:45:33 AM12/11/14
to baptis...@arm.com, bme...@chromium.org, v8-...@googlegroups.com
Committed patchset #1 (id:1)

https://codereview.chromium.org/798553002/
Reply all
Reply to author
Forward
0 new messages